[State Management] State containers and redux middlewares types mismatch

[Dosant]

Kibana version: master

Elasticsearch version:

Server OS version:

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:

Was trying to use redux middlewares together with state containers and had to force cast to to make it work together.

Steps to reproduce:
Try to use redux-logger together with state containers and see the error

yarn add redux-logger @types/redux-logger

 import logger from 'redux-logger'
  const c = createStateContainer({ test: 'test' });
  c.addMiddleware(logger);

error:

TS2345: Argument of type 'Middleware' is not assignable to parameter of type 'Middleware<Readonly<{ test: string; }>>'.   Types of parameters 'api' and 'store' are incompatible.     
Type 'Pick<ReduxLikeStateContainer<Readonly<{ test: string; }>, any, {}>, "getState" | "dispatch">' is not assignable to type 'MiddlewareAPI<Readonly<{ readonly test: string; }>>'.      
Types of property 'dispatch' are incompatible.         
Type '(action: TransitionDescription<string, any[]>) => void' is not assignable to type 'Dispatch<Readonly<{ readonly test: string; }>>'. Types of parameters 'action' and 'action' are incompatible. 
Type 'A' is not assignable to type 'TransitionDescription<string, any[]>'.               Property 'args' is missing in type 'Action' but required in type 'TransitionDescription<string, any[]>'.

I've tried to make args optional on TransitionDescription, but it led to another error about type Dispatch mismatch.

Expected behavior:

stateContainer.addMiddleware() should work with redux middlewares without type casting.

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[streamich]

Is it because of the ReadOnly type? I was thinking maybe we should remove deep freeze readonly type from state container types.

[Dosant]

Is it because of the ReadOnly type? I was thinking maybe we should remove deep freeze readonly type from state container types.

Not completely sure if this particular one is because of readonly.

But I agree, that Readonly type makes things a lot more complicated and maybe having a runtime check would be enough ...

[streamich]

But I agree, that Readonly type makes things a lot more complicated and maybe having a runtime check would be enough ...

Agreed, in my expressions branch I actually removed the readonly type and left only the runtime check.

[ppisljar]

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.