Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[State Management] Transitions and selectors should know about state shape #54439

Closed
Dosant opened this issue Jan 10, 2020 · 2 comments
Closed

[State Management] Transitions and selectors should know about state shape #54439

Dosant opened this issue Jan 10, 2020 · 2 comments
Labels
Feature:StateManagement impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture
Projects
kibana-app-arch

Comments

@Dosant
Copy link
Contributor

Dosant commented Jan 10, 2020 •
edited
Loading

Currently when creating state container, transition and selectors allow to have state shape mismatch and typescript doesn't complain:

createStateContainer(
  { test: "string" },
  {
   transition: (state: {otherShape: string}) => () => state
  }
);

Also have to specify state for each transition / selector explicitly, typescript doesn't infer it:

createStateContainer(
  { test: "string" },
  {
   transition: (state) => () => state // state is considered any here
  }
);

Where, if possible, it should be:

createStateContainer(
  { test: "hello" },
  {
   transition: (state) => () => state // typescript understands that state is {test: "string"} here and doesn't allows to assign anything else
  }
);
@Dosant Dosant added this to To do in kibana-app-arch via automation Jan 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant mentioned this issue Jan 10, 2020
Merged
7 tasks
@streamich streamich removed their assignment Jan 10, 2020
Dosant added a commit that referenced this issue Jan 13, 2020
@Dosant
[State Management] State containers improvements (#54436)
a899df3 
Some maintenance and minor fixes to state containers based on experience while working with them in #53582

Patch unit tests to use current "terminology" (e.g. "transition" vs "mutation")
Fix docs where "store" was used instead of "state container"
Allow to create state container without transition.
Fix freeze function to deeply freeze objects.
Restrict State to BaseState with extends object.
in set() function, make sure the flow goes through dispatch to make sure middleware see this update
Improve type inference for useTransition()
Improve type inference for createStateContainer().

Other issues noticed, but didn't fix in reasonable time:
Can't use addMiddleware without explicit type casting #54438
Transitions and Selectors allow any state, not bind to container's state #54439
Dosant added a commit to Dosant/kibana that referenced this issue Jan 13, 2020
@Dosant
[State Management] State containers improvements (elastic#54436)
f3cbade 
Some maintenance and minor fixes to state containers based on experience while working with them in elastic#53582

Patch unit tests to use current "terminology" (e.g. "transition" vs "mutation")
Fix docs where "store" was used instead of "state container"
Allow to create state container without transition.
Fix freeze function to deeply freeze objects.
Restrict State to BaseState with extends object.
in set() function, make sure the flow goes through dispatch to make sure middleware see this update
Improve type inference for useTransition()
Improve type inference for createStateContainer().

Other issues noticed, but didn't fix in reasonable time:
Can't use addMiddleware without explicit type casting elastic#54438
Transitions and Selectors allow any state, not bind to container's state elastic#54439
Dosant added a commit that referenced this issue Jan 13, 2020
@Dosant
[State Management] State containers improvements (#54436) (#54562)
26b5cd8 
Some maintenance and minor fixes to state containers based on experience while working with them in #53582

Patch unit tests to use current "terminology" (e.g. "transition" vs "mutation")
Fix docs where "store" was used instead of "state container"
Allow to create state container without transition.
Fix freeze function to deeply freeze objects.
Restrict State to BaseState with extends object.
in set() function, make sure the flow goes through dispatch to make sure middleware see this update
Improve type inference for useTransition()
Improve type inference for createStateContainer().

Other issues noticed, but didn't fix in reasonable time:
Can't use addMiddleware without explicit type casting #54438
Transitions and Selectors allow any state, not bind to container's state #54439
chrisronline pushed a commit to chrisronline/kibana that referenced this issue Jan 13, 2020
@Dosant @chrisronline
[State Management] State containers improvements (elastic#54436)
c654d9d 
Some maintenance and minor fixes to state containers based on experience while working with them in elastic#53582

Patch unit tests to use current "terminology" (e.g. "transition" vs "mutation")
Fix docs where "store" was used instead of "state container"
Allow to create state container without transition.
Fix freeze function to deeply freeze objects.
Restrict State to BaseState with extends object.
in set() function, make sure the flow goes through dispatch to make sure middleware see this update
Improve type inference for useTransition()
Improve type inference for createStateContainer().

Other issues noticed, but didn't fix in reasonable time:
Can't use addMiddleware without explicit type casting elastic#54438
Transitions and Selectors allow any state, not bind to container's state elastic#54439
jkelastic pushed a commit to jkelastic/kibana that referenced this issue Jan 17, 2020
@Dosant @jkelastic
[State Management] State containers improvements (elastic#54436)
64b3f50 
Some maintenance and minor fixes to state containers based on experience while working with them in elastic#53582

Patch unit tests to use current "terminology" (e.g. "transition" vs "mutation")
Fix docs where "store" was used instead of "state container"
Allow to create state container without transition.
Fix freeze function to deeply freeze objects.
Restrict State to BaseState with extends object.
in set() function, make sure the flow goes through dispatch to make sure middleware see this update
Improve type inference for useTransition()
Improve type inference for createStateContainer().

Other issues noticed, but didn't fix in reasonable time:
Can't use addMiddleware without explicit type casting elastic#54438
Transitions and Selectors allow any state, not bind to container's state elastic#54439
@Dosant Dosant added the technical debt Improvement of the software architecture and operational architecture label May 28, 2020
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@ppisljar
Copy link
Member

ppisljar commented Aug 8, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as completed Aug 8, 2022
kibana-app-arch automation moved this from To triage to Done in current release Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:StateManagement impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture
Projects
kibana-app-arch
  
Done in current release
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Dosant @streamich @ppisljar @elasticmachine