[ML] Transforms/Analytics: Fix data grid column sorting

[walterra]

Moved from comment to this separate issue.

Two observations:

• When moving a column in the selection pop-up, the table reflects that change, but the pop-up still shows it in the old location
• When hiding the outlier_score column, all the feature_influence columns disappear from the column selection pop-up and they don't come back when I re-select the outlier_score column

[elasticmachine]

Pinging @elastic/ml-ui (:ml)

[peteharverson]

Testing latest master / 7.9.0, I can still reproduce:

• When moving a column in the selection pop-up, the table reflects that change, but the pop-up still shows it in the old location

But this appears to be fixed:

When hiding the outlier_score column, all the feature_influence columns disappear from the column selection pop-up and they don't come back when I re-select the outlier_score column

[alvarezmelissa87]

Digging into this, it looks like in data_grid.tsx, columnsWithChartsActionized - which gets passed as the columns prop for EuiDataGrid - is still in the old order even after the column has been moved in the column selection pop-up. (https://github.com/elastic/kibana/blob/master/x-pack/plugins/ml/public/application/components/data_grid/data_grid.tsx#L265)

Comparing with DataGrid demo in the docs (which doesn't have this issue - the https://elastic.github.io/eui/#/tabular-content/data-grid) where the columns going into the columns prop reflect the order of visibleColumns - the order after moving a column in the selection pop up.

[peteharverson]

The sorting order in the popover is fixed for visible columns for 7.10.0 by #80618.

The sorting order for hidden columns in the popover is dependent on EuiDataGrid adding a callback that exposes the full information of the sorting/visiblity popover.