Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add error handling: uploaded package missing from in-memory cache #82010

Closed
skh opened this issue Oct 29, 2020 · 5 comments
Closed

[Fleet] Add error handling: uploaded package missing from in-memory cache #82010

skh opened this issue Oct 29, 2020 · 5 comments
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@skh
Copy link
Contributor

skh commented Oct 29, 2020

Currently, when Kibana is restarted, all packages are gone from the in-memory cache, so further operations that need access to package content will potentially fail, even if the package assets (dashboards, visualizations, pipelines, mappings etc.) are still safely installed.

For registry packages, there is ensureCachedArchiveInfo() that re-fetches the package from the registry and re-fills the in-memory cache whenever necessary.

For uploaded packages, we need a strategy how to handle this case

  • Uninstall uploaded packages and log a warning about this during /setup?
  • Show a warning in the UI when uploaded packages with missing sources are detected?
  • Log a warning whenever an operation fails to access a package file and hope for the best?

This problem will be less urgent once we store all packages in a dedicated ES index (see #81110 ). It can still happen when the package storage index disappears, is accidentally deleted, wasn’t included in a backup etc.

@skh skh added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 29, 2020
@skh skh self-assigned this Oct 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph ph added the v7.11.0 label Oct 29, 2020
@ruflin
Copy link
Member

ruflin commented Oct 30, 2020

@skh Haven't been thinking of your last point so far that even if we store it, the user could "wipe" the storage index. Lets make sure we plan for this.

@kpollich
Copy link
Member

kpollich commented Feb 6, 2023

The in-memory cache implementation has been iterated on in the last few years, and I don't believe this relevant any longer. Package info objects and archive file listings are added to the cache as each package is requested or installed. Wiping out the in-memory cache on reboot does not appear to have any ill effects on Kibana/Fleet functionality at this time.

@kpollich kpollich closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

6 participants