Adding a search panel to a dashboard causes an error and clicking a visualization panel causes an error

[trevan]

With master, if you add a search/discover visualization to a dashboard, you'll get an error about "$scope.state is undefined".

It looks to have been caused by #9335. Before #9335, the dashboard_panel (https://github.com/elastic/kibana/blob/master/src/core_plugins/kibana/public/dashboard/directives/dashboard_panel.js) inherited the $scope from the dashboard. This included the "state" property (https://github.com/elastic/kibana/pull/9335/files#diff-c4bb79fe61d32ddedfa58bcf760ea323L31 even mentions it in a comment). The search panel expects to be able to access the state property (https://github.com/elastic/kibana/blob/master/src/core_plugins/kibana/public/dashboard/components/panel/lib/search.js#L9) and it is no longer available.

[trevan]

I just realized that the visualization panel also expects the state. It even has a comment about how it is not loved (https://github.com/elastic/kibana/blob/master/src/core_plugins/kibana/public/dashboard/components/panel/lib/visualization.js#L11).

So if you click on a visualization, it won't add a filter. Instead it will throw an error.

[stacey-gammon]

Dangit, I'm on it, thanks for digging into this.