Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass dashboard state through isolate scope #9559

Merged
merged 1 commit into from
Dec 20, 2016
Merged

Pass dashboard state through isolate scope #9559

merged 1 commit into from
Dec 20, 2016

Conversation

stacey-gammon
Copy link
Contributor

@stacey-gammon stacey-gammon commented Dec 19, 2016 •
edited
Loading

There are some dependencies on it.

Fixes #9558 that was broken by #9335

@stacey-gammon
Pass dashboard state through isolate scope
a058976 
There are some dependencies on it.

Fixes elastic#9558
kobelb
kobelb approved these changes Dec 19, 2016
View reviewed changes
Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

weltenwort
weltenwort approved these changes Dec 20, 2016
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too bad, but LGTM

@stacey-gammon stacey-gammon merged commit 1822db0 into elastic:master Dec 20, 2016
elastic-jasper added a commit that referenced this pull request Dec 20, 2016
@elastic-jasper
Pass dashboard state through isolate scope
51a2240 
Backports PR #9559

**Commit 1:**
Pass dashboard state through isolate scope

There are some dependencies on it.

Fixes #9558

* Original sha: a058976
* Authored by Stacey Gammon <gammon@elastic.co> on 2016-12-19T18:42:46Z
@elastic-jasper elastic-jasper mentioned this pull request Dec 20, 2016
Merged
stacey-gammon pushed a commit that referenced this pull request Dec 20, 2016
@elastic-jasper @stacey-gammon
Pass dashboard state through isolate scope (#9569)
18465ff 
Backports PR #9559

**Commit 1:**
Pass dashboard state through isolate scope

There are some dependencies on it.

Fixes #9558

* Original sha: a058976
* Authored by Stacey Gammon <gammon@elastic.co> on 2016-12-19T18:42:46Z
@stacey-gammon stacey-gammon deleted the dashboard-state-in-panel branch January 9, 2017 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobelb kobelb kobelb approved these changes

@weltenwort weltenwort weltenwort approved these changes

Assignees

@kobelb kobelb

@weltenwort weltenwort

Labels
v5.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stacey-gammon @kobelb @weltenwort @tbragin