Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core deprecations service] Add support for deprecation title #99625

Closed
alisonelizabeth opened this issue May 10, 2021 · 5 comments · Fixed by #109840
Closed

[Core deprecations service] Add support for deprecation title #99625

alisonelizabeth opened this issue May 10, 2021 · 5 comments · Fixed by #109840
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@alisonelizabeth
Copy link
Contributor

It's come up a few times that the title of a Kibana deprecation isn't very helpful. Most recently from the docs team here: #97159 (comment). The title is currently derived in Upgrade Assistant using the domainId, e.g., "''domain_id' is using a deprecated feature".

9-0-Upgrade-Assistant-Elastic

I think it's warranted to update the deprecations service to enforce the consumer provide a title and description.

interface DeprecationInfo {
  ... 
  title: string;
  message: string;
  ....
}
@alisonelizabeth alisonelizabeth added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result NeededFor:Elasticsearch UI labels May 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@alisonelizabeth
Copy link
Contributor Author

Hi @Bamieh! Is this something core will still be able to implement? I think it will greatly improve the user experience.

@Bamieh
Copy link
Member

Bamieh commented Jul 22, 2021

@alisonelizabeth I'll work with you this week to fully flush this issue so we can get started on it

@cjcenizal
Copy link
Contributor

@Bamieh FYI #109166 is blocked on this. In addition to the screenshot Alison shared above, the goal is also to enable a UI like this one:

image

@Bamieh
Copy link
Member

Bamieh commented Aug 24, 2021

@cjcenizal Core prioratized this task for this sprint and I've started working on it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants