Dashboard landing page #10003

stacey-gammon · 2017-01-23T16:06:10Z

Similar to #9605, implement for dashboards.

Columns are sortable
Breadcrumbs are links and removed 'New' and 'Open' top nav options.

Only thing missing from previous implementation is pagination.

Still TODO: - Add clickable breadcrumbs - Remove New and Open top nav options

improve tests

cjcenizal

Awesome!! This new UX feels so much better!

I had a few comments and noticed a couple bugs:

The "Reporting" menu item in the top nav is visible on the Dashboard Listing page.
We're showing "PromptForItems" when the user does a search and gets no matches. Instead, we should show "NoItems" in such a situation. "PromptForItems" should only be displayed if the user has zero Dashboards.

cjcenizal · 2017-01-23T23:25:36Z

src/ui/public/kbn_top_nav/bread_crumbs/bread_crumb_url.js

+ * will contain both the url for the given breadcrumb, as well as the breadcrumb the url
+ * was generated for.
+ */
+export function getBreadCrumbUrls(breadcrumbs, url) {


I think this file name should be bread_crumb_urls.js (plural) to match up with this function, right?

cjcenizal · 2017-01-23T23:43:37Z

src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.html

+
+        <div class="kuiPromptForItems__actions">
+          <a class="kuiButton kuiButton--primary kuiButton--iconText"
+                  href="#/dashboard/create">


This should be formatted like this:

<a class="kuiButton kuiButton--primary kuiButton--iconText" href="#/dashboard/create" >

cjcenizal · 2017-01-23T23:45:15Z

src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.html

+
+        <th class="kuiTableHeaderCell" ng-click="listingController.sortHits()">
+          Name
+          <i


Can you change this to a span? It's more semantic.

stacey-gammon · 2017-01-24T15:00:55Z

Comments addressed. Separate PR out for the issue with reporting here.

ppisljar · 2017-01-24T16:05:53Z

This looks great !

Would it be possible to share more code with implementation for visualize ?

stacey-gammon · 2017-01-24T17:34:39Z

jenkins test this

stacey-gammon · 2017-01-24T17:37:27Z

@ppisljar Refactor so dashboard + visualize don't duplicate so much code? I would love to do this, and even mentioned this to @cjcenizal when we were first talking about it (management also uses a similar table).

Given timing situation for 5.3 though, I was postponing that as a clean up task. Want to get view/edit mode in for 5.3 but this has to go first. Thought the refactor would take too long and didn't want to delay. Happy to create a task and assign it to myself so I don't forget though to come back to it.

cjcenizal

LGTM

ppisljar · 2017-01-24T19:09:31Z

selenium tests are failing ... apart from that it looks good to me

- rename bread_crumb_url => bread_crumb_urls - fix reporting link in dash (separate PR) - Use NoItems instead of PromptForItems when searching - Style fixes

Backports PR #10003 **Commit 1:** Introduce dashboard landing page Still TODO: - Add clickable breadcrumbs - Remove New and Open top nav options * Original sha: 416e618 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-01-23T14:40:14Z **Commit 2:** use clickable breadcrumbs instead of 'New' and 'Open' nav items * Original sha: 271dd35 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-01-23T15:47:59Z **Commit 3:** code cleanup improve tests * Original sha: c6354b1 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-01-23T15:53:53Z **Commit 4:** Add new empty dashboard styling * Original sha: 2641d8b * Authored by Stacey Gammon <gammon@elastic.co> on 2017-01-23T20:35:06Z **Commit 5:** Fix selenium tests * Original sha: a1b84ca * Authored by Stacey Gammon <gammon@elastic.co> on 2017-01-23T21:50:37Z **Commit 6:** Address code review comments - rename bread_crumb_url => bread_crumb_urls - fix reporting link in dash (separate PR) - Use NoItems instead of PromptForItems when searching - Style fixes * Original sha: fd857dc * Authored by Stacey Gammon <gammon@elastic.co> on 2017-01-24T14:44:43Z **Commit 7:** Use a constant for the landing page url * Original sha: fbdaa84 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-01-24T20:20:07Z **Commit 8:** Fix tests * Original sha: 33b4f24 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-01-24T20:53:08Z

* Introduce dashboard landing page Still TODO: - Add clickable breadcrumbs - Remove New and Open top nav options * use clickable breadcrumbs instead of 'New' and 'Open' nav items * code cleanup improve tests * Add new empty dashboard styling * Fix selenium tests * Address code review comments - rename bread_crumb_url => bread_crumb_urls - fix reporting link in dash (separate PR) - Use NoItems instead of PromptForItems when searching - Style fixes * Use a constant for the landing page url * Fix tests

* Introduce dashboard landing page Still TODO: - Add clickable breadcrumbs - Remove New and Open top nav options * use clickable breadcrumbs instead of 'New' and 'Open' nav items * code cleanup improve tests * Add new empty dashboard styling * Fix selenium tests * Address code review comments - rename bread_crumb_url => bread_crumb_urls - fix reporting link in dash (separate PR) - Use NoItems instead of PromptForItems when searching - Style fixes * Use a constant for the landing page url * Fix tests fix tests

stacey-gammon requested review from cjcenizal and ppisljar January 23, 2017 16:07

stacey-gammon assigned cjcenizal and ppisljar Jan 23, 2017

stacey-gammon added review v5.3.0 labels Jan 23, 2017

stacey-gammon added 3 commits January 23, 2017 15:30

Introduce dashboard landing page

416e618

Still TODO: - Add clickable breadcrumbs - Remove New and Open top nav options

use clickable breadcrumbs instead of 'New' and 'Open' nav items

271dd35

code cleanup

c6354b1

improve tests

stacey-gammon force-pushed the dashboard-landing-page branch from d9cf7d3 to c6354b1 Compare January 23, 2017 20:30

Add new empty dashboard styling

2641d8b

stacey-gammon mentioned this pull request Jan 23, 2017

View/edit mode for dashboards #9508

Closed

Fix selenium tests

a1b84ca

cjcenizal suggested changes Jan 23, 2017

View reviewed changes

stacey-gammon force-pushed the dashboard-landing-page branch from 34e0042 to 41f6495 Compare January 24, 2017 15:02

stacey-gammon added Feature:Dashboard Dashboard related features :Sharing labels Jan 24, 2017

cjcenizal approved these changes Jan 24, 2017

View reviewed changes

Address code review comments

fd857dc

- rename bread_crumb_url => bread_crumb_urls - fix reporting link in dash (separate PR) - Use NoItems instead of PromptForItems when searching - Style fixes

stacey-gammon force-pushed the dashboard-landing-page branch from 41f6495 to fd857dc Compare January 24, 2017 19:59

stacey-gammon added 2 commits January 24, 2017 15:20

Use a constant for the landing page url

fbdaa84

Fix tests

33b4f24

ppisljar approved these changes Jan 25, 2017

View reviewed changes

stacey-gammon merged commit 5ba6603 into elastic:master Jan 25, 2017

elastic-jasper mentioned this pull request Jan 25, 2017

[5.x] Dashboard landing page #10063

Closed

stacey-gammon mentioned this pull request Jan 25, 2017

[5.x] Dashboard landing page (#10003) #10065

Merged

tbragin mentioned this pull request Jan 26, 2017

Add landing page with table to Visualize app. #9605

Merged

12 tasks

cjcenizal mentioned this pull request Feb 7, 2017

Dashboard and Visualize landing pages #9722

Closed

stacey-gammon mentioned this pull request Apr 3, 2017

Dashboard url not based on saved dashboard broken in 5.3.0 #10951

Closed

stacey-gammon deleted the dashboard-landing-page branch April 6, 2017 11:05

This was referenced Jun 2, 2017

List dashboards instead of help message #3184

Closed

Load a default dashboard rather than starting new #5820

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dashboard landing page #10003

Dashboard landing page #10003

stacey-gammon commented Jan 23, 2017 •

edited

Loading

cjcenizal left a comment •

edited

Loading

cjcenizal Jan 23, 2017

cjcenizal Jan 23, 2017

cjcenizal Jan 23, 2017

stacey-gammon commented Jan 24, 2017 •

edited

Loading

ppisljar commented Jan 24, 2017 •

edited

Loading

stacey-gammon commented Jan 24, 2017

stacey-gammon commented Jan 24, 2017

cjcenizal left a comment

ppisljar commented Jan 24, 2017

Dashboard landing page #10003

Dashboard landing page #10003

Conversation

stacey-gammon commented Jan 23, 2017 • edited Loading

cjcenizal left a comment • edited Loading

Choose a reason for hiding this comment

cjcenizal Jan 23, 2017

Choose a reason for hiding this comment

cjcenizal Jan 23, 2017

Choose a reason for hiding this comment

cjcenizal Jan 23, 2017

Choose a reason for hiding this comment

stacey-gammon commented Jan 24, 2017 • edited Loading

ppisljar commented Jan 24, 2017 • edited Loading

stacey-gammon commented Jan 24, 2017

stacey-gammon commented Jan 24, 2017

cjcenizal left a comment

Choose a reason for hiding this comment

ppisljar commented Jan 24, 2017

stacey-gammon commented Jan 23, 2017 •

edited

Loading

cjcenizal left a comment •

edited

Loading

stacey-gammon commented Jan 24, 2017 •

edited

Loading

ppisljar commented Jan 24, 2017 •

edited

Loading