Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Set monitoring.ui.container.elasticsearch.enabled for all containers #115087

Merged
merged 2 commits into from Nov 5, 2021
Merged

[build] Set monitoring.ui.container.elasticsearch.enabled for all containers #115087

merged 2 commits into from Nov 5, 2021

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Oct 14, 2021 •
edited

We recently started automating our release to Ironbank which resulted in this setting being removed. Historically, this check was used to exclude the setting if we were running on oss build, where the setting wasn't available.

I believe we should set this for ALL container, but will await confirmation from @elastic/stack-monitoring-ui

[build] Set monitoring.ui.container.elasticsearch.enabled for all con…
b32a3a3 
…tainers

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated: Automatically backport this PR after it's merged v7.16.0 buildkite-ci v7.15.1 labels Oct 14, 2021
@tylersmalley tylersmalley requested a review from a team as a code owner October 14, 2021 19:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley requested a review from a team October 14, 2021 19:33
@jbudz
Copy link
Member

jbudz commented Oct 14, 2021

https://github.com/elastic/kibana-docker/blob/79df79dc0237b1849925fe21691b818a40efedc6/.tedi/template/kibana.yml.j2 for the history if anyone's curious.

@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@tylersmalley tylersmalley enabled auto-merge (squash) November 4, 2021 22:42
@tylersmalley
Copy link
Contributor Author

@elastic/stack-monitoring-ui, can you confirm this is what we want?

@tylersmalley tylersmalley merged commit 60340b5 into elastic:main Nov 5, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine mentioned this pull request Nov 5, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2021
@kibanamachine
[build] Set monitoring.ui.container.elasticsearch.enabled for all con…
01aa042 
…tainers (elastic#115087)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2021
@kibanamachine
[build] Set monitoring.ui.container.elasticsearch.enabled for all con…
45868a9 
…tainers (elastic#115087)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Nov 5, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2021
@kibanamachine
[build] Set monitoring.ui.container.elasticsearch.enabled for all con…
d597a4a 
…tainers (elastic#115087)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Nov 5, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16
✅ 7.15

The backport PRs will be merged automatically after passing CI.

@tylersmalley
Copy link
Contributor Author

Forgot the review request wasn't from codeowners, so didn't block the automerge. If this is not something we want, let me know and we can revert.

kibanamachine added a commit that referenced this pull request Nov 5, 2021
@kibanamachine
[build] Set monitoring.ui.container.elasticsearch.enabled for all con…
6c58f89 
…tainers (#115087) (#117612)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
kibanamachine added a commit that referenced this pull request Nov 5, 2021
@kibanamachine
[build] Set monitoring.ui.container.elasticsearch.enabled for all con…
6f08d62 
…tainers (#115087) (#117610)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
kibanamachine added a commit that referenced this pull request Nov 5, 2021
@kibanamachine
[build] Set monitoring.ui.container.elasticsearch.enabled for all con…
60ddfa3 
…tainers (#115087) (#117611)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 5, 2021
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/add-l…
55c195e 
…ink-to-kibana-app

* 'main' of github.com:elastic/kibana: (290 commits)
  [Connectors][ServiceNow] Remove SN flags (elastic#117511)
  [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503)
  [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488)
  [Visualize] [xyChart] filter labels by default (elastic#117288)
  Fix warning when setting description to undefined (elastic#117338)
  [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087)
  fix types
  [Alerting] UX fixes for execution duration chart (elastic#117193)
  [CI] Delete node_modules in between bootstrap attempts (elastic#117588)
  Flaky test fixes (elastic#117028)
  [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views  (elastic#114806)
  [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493)
  adjust the synthetics journey type (elastic#117316)
  Refines hasAnyData check for alerts (elastic#117499)
  [Fleet] Default to APM tutorial (elastic#117421)
  [Maps] update docs for index pattern -> data view rename (elastic#117400)
  [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821)
  [Fleet] Fix agent logs not reading query from URL (elastic#117286)
  Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917)
  [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
#	x-pack/plugins/reporting/public/shared_imports.ts
#	x-pack/plugins/reporting/server/routes/management/jobs.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged buildkite-ci release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.15.1 v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tylersmalley @elasticmachine @jbudz @kibanamachine @spalger