Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Add docs link to redundant groupBy detection #116822

Merged
merged 6 commits into from
Nov 4, 2021
Merged

[Metrics UI] Add docs link to redundant groupBy detection #116822

merged 6 commits into from
Nov 4, 2021

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Oct 29, 2021 •
edited
Loading

REDO OF #116695 which was accidentally merged before approval

Summary

Fixes #116195

UPDATE

Screen Shot 2021-11-01 at 3 01 33 PM

Instead of changing the logic, this PR will now add a docs link explaining how filtering and groupBy works.

Depends on this docs PR: elastic/observability-docs#1196

Previous Summary

In this PR, host.name will still be flagged as redundant in this case:
Screen Shot 2021-10-28 at 12 32 34 PM

But with these changes, it will NOT be flagged in this case:
Screen Shot 2021-10-28 at 12 34 46 PM
Screen Shot 2021-10-28 at 12 34 32 PM

@Zacqary Zacqary added release_note:fix v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 29, 2021
@Zacqary Zacqary requested a review from a team as a code owner October 29, 2021 18:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@Zacqary Zacqary added the v8.1.0 label Oct 29, 2021
@Zacqary Zacqary requested a review from a team as a code owner November 1, 2021 17:49
@Zacqary Zacqary changed the title [Metrics UI] Fix OR logic on redundant groupBy detection [Metrics UI] Add docs link to redundant groupBy detection Nov 1, 2021
@Zacqary @neptunian
Update x-pack/plugins/infra/public/alerting/metric_threshold/componen…
5856bae 
…ts/expression.tsx

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
@Zacqary Zacqary mentioned this pull request Nov 3, 2021
Closed
@Zacqary
Copy link
Contributor Author

Zacqary commented Nov 4, 2021

@elasticmachine merge upstream

@Zacqary Zacqary enabled auto-merge (squash) November 4, 2021 14:54
@Zacqary Zacqary merged commit e4982fe into elastic:main Nov 4, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 921.8KB 922.1KB +314.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 267.1KB 267.1KB -51.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine mentioned this pull request Nov 4, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
@Zacqary @neptunian @kibanamachine
[Metrics UI] Add docs link to redundant groupBy detection (elastic#11…
2f2abfc 
…6822)

* [Metrics UI] Fix OR logic on redundant groupBy detection

* Switch regex change to doc change

* Fix core docs links

* Update x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
@Zacqary @neptunian @kibanamachine
[Metrics UI] Add docs link to redundant groupBy detection (elastic#11…
8a69383 
…6822)

* [Metrics UI] Fix OR logic on redundant groupBy detection

* Switch regex change to doc change

* Fix core docs links

* Update x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Nov 4, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 4, 2021
@kibanamachine @Zacqary @neptunian
[Metrics UI] Add docs link to redundant groupBy detection (#116822) (#…
c24b8a6 
…117563)

* [Metrics UI] Fix OR logic on redundant groupBy detection

* Switch regex change to doc change

* Fix core docs links

* Update x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>
Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Nov 4, 2021
@kibanamachine @Zacqary @neptunian
[Metrics UI] Add docs link to redundant groupBy detection (#116822) (#…
6cda434 
…117564)

* [Metrics UI] Fix OR logic on redundant groupBy detection

* Switch regex change to doc change

* Fix core docs links

* Update x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>
Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 5, 2021
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/add-l…
55c195e 
…ink-to-kibana-app

* 'main' of github.com:elastic/kibana: (290 commits)
  [Connectors][ServiceNow] Remove SN flags (elastic#117511)
  [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503)
  [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488)
  [Visualize] [xyChart] filter labels by default (elastic#117288)
  Fix warning when setting description to undefined (elastic#117338)
  [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087)
  fix types
  [Alerting] UX fixes for execution duration chart (elastic#117193)
  [CI] Delete node_modules in between bootstrap attempts (elastic#117588)
  Flaky test fixes (elastic#117028)
  [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views  (elastic#114806)
  [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493)
  adjust the synthetics journey type (elastic#117316)
  Refines hasAnyData check for alerts (elastic#117499)
  [Fleet] Default to APM tutorial (elastic#117421)
  [Maps] update docs for index pattern -> data view rename (elastic#117400)
  [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821)
  [Fleet] Fix agent logs not reading query from URL (elastic#117286)
  Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917)
  [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
#	x-pack/plugins/reporting/public/shared_imports.ts
#	x-pack/plugins/reporting/server/routes/management/jobs.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neptunian neptunian neptunian approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Threshold alert redundant groupBy throws a false positive on OR matches
5 participants
@Zacqary @elasticmachine @kibanamachine @lukeelmers @neptunian