Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Default to APM tutorial #117421

Merged
merged 9 commits into from
Nov 4, 2021
Merged

[Fleet] Default to APM tutorial #117421

merged 9 commits into from
Nov 4, 2021

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Nov 3, 2021 •
edited
Loading

closes #116847

  • the APM tutorial card is now shown, regardless of the radio-button selection (recommended/elastic agent only/beats only)
  • the promoted card at the top of the integrations page now links to the APM tutorial
  • the empty state page for the APM app now links to the APM tutorial
  • the APM tutorial page no longer shows the "a newer version of this module is available as an Elastic Agent Integration" callout

@thomasneirynck thomasneirynck marked this pull request as ready for review November 3, 2021 20:00
@thomasneirynck thomasneirynck requested review from a team as code owners November 3, 2021 20:00
@thomasneirynck thomasneirynck added Feature:Unified Integrations Unified Integrations view feature release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Nov 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@cauemarcondes
Copy link
Contributor

@thomasneirynck would be nice if you could add some snapshots of the changes you made. Would be easier to understand the changes,

@thomasneirynck thomasneirynck added the auto-backport Deprecated: Automatically backport this PR after it's merged label Nov 4, 2021
@thomasneirynck
Copy link
Contributor Author

@cauemarcondes please see #116847 for screenshots of the changes

nchaulet
nchaulet approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment otherwise LGTM 🚀

criamico
criamico approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 615.1KB 615.2KB +46.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 8ae4275 into elastic:main Nov 4, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
@thomasneirynck @kibanamachine
[Fleet] Default to APM tutorial (elastic#117421)
e0c4179
@kibanamachine kibanamachine mentioned this pull request Nov 4, 2021
Open
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
✅ 8.0
❌ 7.16 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 117421

@thomasneirynck thomasneirynck mentioned this pull request Nov 4, 2021
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Nov 4, 2021
@thomasneirynck
[Fleet] Default to APM tutorial (elastic#117421)
9ed13b2 
# Conflicts:
#	test/api_integration/apis/custom_integration/integrations.ts
thomasneirynck added a commit that referenced this pull request Nov 4, 2021
@thomasneirynck
[Fleet] Default to APM tutorial (#117421) (#117581)
1a80a3b 
# Conflicts:
#	test/api_integration/apis/custom_integration/integrations.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 5, 2021
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/add-l…
55c195e 
…ink-to-kibana-app

* 'main' of github.com:elastic/kibana: (290 commits)
  [Connectors][ServiceNow] Remove SN flags (elastic#117511)
  [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503)
  [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488)
  [Visualize] [xyChart] filter labels by default (elastic#117288)
  Fix warning when setting description to undefined (elastic#117338)
  [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087)
  fix types
  [Alerting] UX fixes for execution duration chart (elastic#117193)
  [CI] Delete node_modules in between bootstrap attempts (elastic#117588)
  Flaky test fixes (elastic#117028)
  [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views  (elastic#114806)
  [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493)
  adjust the synthetics journey type (elastic#117316)
  Refines hasAnyData check for alerts (elastic#117499)
  [Fleet] Default to APM tutorial (elastic#117421)
  [Maps] update docs for index pattern -> data view rename (elastic#117400)
  [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821)
  [Fleet] Fix agent logs not reading query from URL (elastic#117286)
  Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917)
  [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
#	x-pack/plugins/reporting/public/shared_imports.ts
#	x-pack/plugins/reporting/server/routes/management/jobs.ts
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 8, 2021
@thomasneirynck thomasneirynck mentioned this pull request Nov 8, 2021
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Nov 8, 2021
@thomasneirynck
[Fleet] Default to APM tutorial (elastic#117421)
93aa982
thomasneirynck added a commit that referenced this pull request Nov 8, 2021
@thomasneirynck
[Fleet] Default to APM tutorial (#117421) (#117920)
f5bb715
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@thomasneirynck thomasneirynck removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 9, 2021
@thomasneirynck
Copy link
Contributor Author

backported to 7.16 #117581 and 8.0 #117920

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 10, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@thomasneirynck thomasneirynck removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 11, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 12, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 15, 2021
@jen-huang jen-huang mentioned this pull request Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

@criamico criamico criamico approved these changes

@justinkambic justinkambic justinkambic approved these changes

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@joshdover joshdover Awaiting requested review from joshdover

@mostlyjason mostlyjason Awaiting requested review from mostlyjason

@kpollich kpollich Awaiting requested review from kpollich

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged backported chore Feature:Unified Integrations Unified Integrations view feature release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Integrations] Fixes for APM onboarding flow
10 participants
@thomasneirynck @elasticmachine @cauemarcondes @alvarolobato @kibanamachine @nchaulet @criamico @justinkambic @spalger @jen-huang