-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Should be able to zoom-in on selected range of timeslider #122131
Conversation
…f kibana according selected time slice
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
I'd make one addition: set the timeslice to the entire range as well.
Otherwise the data "blips".
Step 2) click "zoom in" calendar button
^ note that the seleted timeslice is expanded so it is identical to the previous timeslice. This way, the data on-screen remains identical.
@thomasneirynck What if we change the current behavior of auto-select from:
to
This looks like a more appropriate solution here, because it also fixes the current behavior of the initial opening of the timeslider. This will allow you to get the entire period of the global time window, not just the range between the first and second ticks, and it will not change the data on the map. |
discussed with offline with @nreese @maksimkovalev #122131 (comment) We can discard this and keep the current behavior. We can keep #122131 (review) as a separate improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
Pinging @elastic/kibana-gis (Team:Geo) |
x-pack/plugins/maps/public/connected_components/timeslider/timeslider.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/connected_components/timeslider/time_utils.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/connected_components/timeslider/timeslider.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
buildkite test this |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Closes: #105596
This PR contains changes for the time slider component. Users can now set Kibana's global time range according to the selected time slice in the timeslider component by clicking calendar button.
cc @thomasneirynck