Fix a11y issues with cross cluster replication flyouts #149069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
release_note:fix
Project:Accessibility
Feature:CCR and Remote Clusters
Team:Kibana Management
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
|
@elasticmachine merge upstream |
sabarasaba
approved these changes
Jan 18, 2023
| @@ -269,7 +269,7 @@ describe('<AutoFollowPatternList />', () => { | |||
| test('should have a "settings" section', () => { | |||
| actions.clickAutoFollowPatternAt(0); | |||
| expect(find('settingsSection').find('h3').text()).toEqual('Settings'); | |||
| expect(exists('settingsValues')).toBe(true); | |||
| expect(exists('settingsValues', 4)).toBe(true); | |||
There was a problem hiding this comment.
nit: I think we could we make this a bit more readable. Perhaps if we do a find on settings value and check against its lenght, not sure what you think about that!
// These are the different sections that reflect the options of an autofollow pattern
const AVAILABLE_SETTINGS = 4;
expect(find('settingsValues').length).toBe(AVAILABLE_SETTINGS);
There was a problem hiding this comment.
Thanks for the suggestion @sabarasaba! It looks good to me so I added it in the next commit.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
kibanamachine
added
v8.7.0
backport:skip
wayneseymour
pushed a commit
to wayneseymour/kibana
that referenced
this pull request
Jan 19, 2023
Fixes elastic#135503, fixes elastic#135506 ## Summary This PR fixes the a11y issues in the Follower index flyout and the Auto follower index flyout from the Cross cluster replication plugin. Screenshots: <img height="500" alt="Screenshot 2023-01-17 at 17 46 08" src="https://user-images.githubusercontent.com/59341489/212985332-794a2b7e-3e12-4303-bcbd-ad63552f211c.png"> <img height="500" alt="Screenshot 2023-01-17 at 13 26 51" src="https://user-images.githubusercontent.com/59341489/212987803-40062d53-3b34-4286-98fc-736264491b08.png"> Followed [these instructions](https://www.elastic.co/guide/en/elasticsearch/reference/current/ccr-getting-started-tutorial.html#ccr-getting-started-tutorial) to set up the cross cluster replication and the follower and auto-follower indices. ### Checklist - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [X] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135503, fixes #135506
Summary
This PR fixes the a11y issues in the Follower index flyout and the Auto follower index flyout from the Cross cluster replication plugin.
Screenshots:
Followed these instructions to set up the cross cluster replication and the follower and auto-follower indices.
Checklist