Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a11y issues with cross cluster replication flyouts #149069

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Fix a11y issues with cross cluster replication flyouts #149069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9f81a7
Fix a11y issues with cross cluster replication flyouts
ElenaStoeva Jan 17, 2023
75a4378
Update a test
ElenaStoeva Jan 18, 2023
90362d7
Merge branch 'main' into a11y-cross-cluster-replication
kibanamachine Jan 18, 2023
2c61281
Improve test readability
ElenaStoeva Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...s_cluster_replication/public/__jest__/client_integration/auto_follow_pattern_list.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,10 @@ describe('<AutoFollowPatternList />', () => {
test('should have a "settings" section', () => {
actions.clickAutoFollowPatternAt(0);
expect(find('settingsSection').find('h3').text()).toEqual('Settings');
expect(exists('settingsValues')).toBe(true);

// The number of different settings of an auto-follower pattern
const AVAILABLE_SETTINGS = 4;
expect(find('settingsValues').length).toBe(AVAILABLE_SETTINGS);
});

test('should set the correct auto-follow pattern settings values', () => {
Expand Down
36 changes: 21 additions & 15 deletions ...public/app/sections/home/auto_follow_pattern_list/components/detail_panel/detail_panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ export class DetailPanel extends Component {

<EuiSpacer size="s" />

<EuiDescriptionList data-test-subj="settingsValues">
<EuiFlexGroup>
<EuiFlexItem>
<EuiFlexGroup>
<EuiFlexItem>
<EuiDescriptionList data-test-subj="settingsValues">
<EuiDescriptionListTitle>
<EuiTitle size="xs">
<FormattedMessage
Expand All @@ -117,9 +117,11 @@ export class DetailPanel extends Component {
<EuiDescriptionListDescription data-test-subj="remoteCluster">
{remoteCluster}
</EuiDescriptionListDescription>
</EuiFlexItem>
</EuiDescriptionList>
</EuiFlexItem>

<EuiFlexItem>
<EuiFlexItem>
<EuiDescriptionList data-test-subj="settingsValues">
<EuiDescriptionListTitle>
<EuiTitle size="xs">
<FormattedMessage
Expand All @@ -132,13 +134,15 @@ export class DetailPanel extends Component {
<EuiDescriptionListDescription data-test-subj="leaderIndexPatterns">
{leaderIndexPatterns.join(', ')}
</EuiDescriptionListDescription>
</EuiFlexItem>
</EuiFlexGroup>
</EuiDescriptionList>
</EuiFlexItem>
</EuiFlexGroup>

<EuiSpacer size="s" />
<EuiSpacer size="s" />

<EuiFlexGroup>
<EuiFlexItem>
<EuiFlexGroup>
<EuiFlexItem>
<EuiDescriptionList data-test-subj="settingsValues">
<EuiDescriptionListTitle>
<EuiTitle size="xs">
<FormattedMessage
Expand All @@ -158,9 +162,11 @@ export class DetailPanel extends Component {
</em>
)}
</EuiDescriptionListDescription>
</EuiFlexItem>
</EuiDescriptionList>
</EuiFlexItem>

<EuiFlexItem>
<EuiFlexItem>
<EuiDescriptionList data-test-subj="settingsValues">
<EuiDescriptionListTitle>
<EuiTitle size="xs">
<FormattedMessage
Expand All @@ -180,9 +186,9 @@ export class DetailPanel extends Component {
</em>
)}
</EuiDescriptionListDescription>
</EuiFlexItem>
</EuiFlexGroup>
</EuiDescriptionList>
</EuiDescriptionList>
</EuiFlexItem>
</EuiFlexGroup>
</section>
</>
);
Expand Down
Loading