Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Remove or move book-scoped attributes #155210

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 18, 2023

Summary

This PR removes unused attributes from the documentation. It also moves some attributes that are used only in a single page into that page in preparation for the new documentation system.

The blob attribute is replaced by the global kibana-blob attribute, which was created in elastic/docs#2666.

@lcawl lcawl added Team:Docs release_note:skip Skip the PR/issue when compiling release notes docs v8.8.0 v8.7.1 labels Apr 18, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl requested a review from a team April 19, 2023 19:21
@lcawl lcawl marked this pull request as ready for review April 20, 2023 01:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Lisa!

@lcawl lcawl merged commit 5120d69 into elastic:main Apr 20, 2023
@lcawl lcawl deleted the shared-attrs branch April 20, 2023 16:12
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 20, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 20, 2023
# Backport

This will backport the following commits from `main` to `8.7`:
- [[DOCS] Remove or move book-scoped attributes
(#155210)](#155210)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-04-20T16:12:09Z","message":"[DOCS]
Remove or move book-scoped attributes
(#155210)","sha":"5120d692c8c6a1545fbc40acff7b691523eb32d9","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","v8.8.0","v8.7.1"],"number":155210,"url":"https://github.com/elastic/kibana/pull/155210","mergeCommit":{"message":"[DOCS]
Remove or move book-scoped attributes
(#155210)","sha":"5120d692c8c6a1545fbc40acff7b691523eb32d9"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155210","number":155210,"mergeCommit":{"message":"[DOCS]
Remove or move book-scoped attributes
(#155210)","sha":"5120d692c8c6a1545fbc40acff7b691523eb32d9"}},{"branch":"8.7","label":"v8.7.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
rylnd added a commit that referenced this pull request Apr 21, 2023
* 8.7: (93 commits)
  [8.7] [Controls] Use EUI Selectable for Field search (#151231) (#155454)
  [8.7] [Synthetics] Fix  performance breakdown link from error details page (#155393) (#155427)
  [8.7] [DOCS] Remove or move book-scoped attributes (#155210) (#155426)
  [8.7] [Synthetics] add default email recovery message (#154862) (#155418)
  [8.7] [Uptime] Add both both ip filters for view host in uptime location for host and monitor (#155382) (#155399)
  [8.7] Setup Node.js environment before instrumenting Kibana with APM. (#155063) (#155300)
  [8.7] [Discover] Address react warnings for legacy table (#154579) (#155345)
  [8.7] [Fleet] Fix logs useless rerender (#155305) (#155310)
  [8.7] [kbn-failed-test-reporter-cli] truncate report message to fix github api call failure (#155141) (#155286)
  [8.7][APM] Fleet migration support for bundled APM package (#153159)  (#155281)
  [8.7] [Enterprise Search] Fix Connector scheduling show week information correctly (#155191) (#155227)
  [8.7] [Synthetics] Fix pending count in case of location filtering (#155200) (#155225)
  [8.7] [Controls] Add Expensive Queries Fallback (#155082) (#155189)
  [8.7] [data view field editor] Runtime field code editor - move state out of controller (#155107) (#155150)
  [8.7] [FullStory] Update snippet (#153570) (#155138)
  [8.7] [Security Solution][Exceptions] - Fix exception operator logic when mapping conflict (#155071) (#155094)
  [DOCS] Adds 8.7.1 release notes (#154844)
  [8.7] Sync bundled packages with Package Storage (#155042)
  [APM] plugin description (#154811)
  Update api.asciidoc (#155021)
  ...
nikitaindik pushed a commit to nikitaindik/kibana that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.7.1 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants