[Docs] remove Kibana book-scoped attributes from 7.17 #178759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shainaraskas
added
Team:Docs
release_note:skip
shainaraskas
force-pushed
the
kibana-book-vars-7-17
branch
from
2628b2b
to
294b0ae
Compare
shainaraskas
commented
Mar 14, 2024
| @@ -6,7 +6,7 @@ We use functional tests to make sure the {kib} UI works as expected. It replaces | |||
| [discrete] | |||
| === Running functional tests | |||
|
|
|||
| The `FunctionalTestRunner` is very bare bones and gets most of its functionality from its config file, located at {blob}test/functional/config.js[test/functional/config.js] or {blob}x-pack/test/functional/config.js[x-pack/test/functional/config.js]. If you’re writing a plugin outside the {kib} repo, you will have your own config file. | |||
| The `FunctionalTestRunner` is very bare bones and gets most of its functionality from its config file. If you’re writing a plugin outside the {kib} repo, you will have your own config file. | |||
There was a problem hiding this comment.
took out the links to match 8.14 because the links were dead - this file is referenced/linked to in the doc linked lower on the page
shainaraskas
commented
Mar 14, 2024
| @@ -64,7 +64,8 @@ export default async function ({ readConfigFile }) { | |||
| } | |||
|
|
|||
| // more settings, like timeouts, mochaOpts, etc are | |||
| // defined in the config schema. See {blob}src/functional_test_runner/lib/config/schema.js[src/functional_test_runner/lib/config/schema.js] | |||
| // defined in the config schema. | |||
| // See {kibana-blob}packages/kbn-test/src/functional_test_runner/lib/config/schema.ts | |||
There was a problem hiding this comment.
@shainaraskas follow up on this path change. need to also port this change forward to main
file was moved here
There was a problem hiding this comment.
Confirmed with the Kibana team that this new file is the correct replacement
|
Pinging @elastic/kibana-docs (Team:Docs) |
Fixed in elastic/docs#2963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes book-scoped docs attributes from 7.17 in preparation for eventual migration to Docsmobile
backports changes from #178676 and #155210
blobattribute is replaced by the globalkibana-blobattributedata-sourceanddata-sourcesare also present in the global attributesnote: looks like
data-sourceanddata-sourcesare not respecting the capitalization of the attribute so it's getting overridden by legacy attr. definitions, leading to a capitalization bug. prob should be fixed in the global attributes filehttps://github.com/elastic/kibana/blob/7.17/docs/user/dashboard/dashboard.asciidoc?plain=1#L380
