-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.11] [Fleet] Improve UX for policy secrets (#171405) #172098
Merged
Merged
Commits on Nov 28, 2023
-
[Fleet] Improve UX for policy secrets (elastic#171405)
## Summary Closes elastic#171225 - Highlights secrets during package policy creation with a distinct background and icon - Add tooltip + docs link for secrets where appropriate - Detect "new secrets" during policy upgrade and alert the user in a separate callout ## To do - [x] Fix any failing tests - [x] Add tests for "new secrets" detection logic ## Screenshots ![image](https://github.com/elastic/kibana/assets/6766512/e943a3e8-68db-40eb-a5c3-b108e7d299ff) ![image](https://github.com/elastic/kibana/assets/6766512/751bbe50-7553-4dcc-a8dc-b9802f331013) ![image](https://github.com/elastic/kibana/assets/6766512/6cceb4cd-0b8e-42cd-aafb-d2e3ddcd23a8) ## How to test There's probably an easier way to do this, but this is what I did 1. Clone https://github.com/elastic/package-registry and https://github.com/elastic/integrations 2. Add the following to `config.yml` in your package-registry repo ```yml package_paths: - path/to/your/integrations/build/packages ``` 3. Build a version of an integration with some `secrets: true` for various variables. I used `1password` ```shell cd integrations/packages/1password # Edit `manifest.yml` or a given `data_stream/*/manifest.yml` file to change some variables to `secret: true`. Also bump the version and update `changelog.yml` elastic-package build ``` 4. Run the local package registry e.g. ```shell cd package-registry go run . --feature-proxy-mode=true -proxy-to=https://epr.elastic.co # makes it so you can still see EPR packages in Kibana ``` 5. Update your `kibana.dev.yml` to point at your local package registry ```yml xpack.fleet.registryUrl: http://localhost:8080 ``` 6. Start Kibana and Elasticsearch and install, upgrade, etc your package in question to verify the changes --------- Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> (cherry picked from commit 9396ef3) # Conflicts: # packages/kbn-doc-links/src/get_doc_links.ts # packages/kbn-doc-links/src/types.ts # x-pack/plugins/translations/translations/fr-FR.json # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
Configuration menu - View commit details
-
Copy full SHA for 57d780a - Browse repository at this point
Copy the full SHA 57d780aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 615353b - Browse repository at this point
Copy the full SHA 615353bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 30909f9 - Browse repository at this point
Copy the full SHA 30909f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2fc78d - Browse repository at this point
Copy the full SHA e2fc78dView commit details
Commits on Nov 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 18dd8ae - Browse repository at this point
Copy the full SHA 18dd8aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d74a3c8 - Browse repository at this point
Copy the full SHA d74a3c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37ebc63 - Browse repository at this point
Copy the full SHA 37ebc63View commit details -
Configuration menu - View commit details
-
Copy full SHA for f74af73 - Browse repository at this point
Copy the full SHA f74af73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 129e831 - Browse repository at this point
Copy the full SHA 129e831View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.