Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] remove Kibana book-scoped variables #178676

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

shainaraskas
Copy link
Contributor

@shainaraskas shainaraskas commented Mar 13, 2024

Summary

Removes book-scoped docs variable in preparation for eventual migration to Docsmobile

@shainaraskas shainaraskas added Team:Docs release_note:skip Skip the PR/issue when compiling release notes docs v8.14.0 v8.13.1 labels Mar 13, 2024
@shainaraskas shainaraskas requested a review from a team March 13, 2024 18:38
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@shainaraskas shainaraskas marked this pull request as ready for review March 13, 2024 19:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shainaraskas shainaraskas merged commit a36a370 into elastic:main Mar 14, 2024
5 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 14, 2024
## Summary

Removes book-scoped docs variable in preparation for eventual migration
to Docsmobile

(cherry picked from commit a36a370)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 14, 2024
# Backport

This will backport the following commits from `main` to `8.13`:
- [[Docs] remove Kibana book-scoped variables
(#178676)](#178676)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"shainaraskas","email":"58563081+shainaraskas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-03-14T15:53:33Z","message":"[Docs]
remove Kibana book-scoped variables (#178676)\n\n##
Summary\r\n\r\nRemoves book-scoped docs variable in preparation for
eventual migration\r\nto
Docsmobile","sha":"a36a370878e75a0537e960bd580eb06acc0fd52e","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","v8.14.0","v8.13.1"],"title":"[Docs]
remove Kibana book-scoped
variables","number":178676,"url":"https://github.com/elastic/kibana/pull/178676","mergeCommit":{"message":"[Docs]
remove Kibana book-scoped variables (#178676)\n\n##
Summary\r\n\r\nRemoves book-scoped docs variable in preparation for
eventual migration\r\nto
Docsmobile","sha":"a36a370878e75a0537e960bd580eb06acc0fd52e"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178676","number":178676,"mergeCommit":{"message":"[Docs]
remove Kibana book-scoped variables (#178676)\n\n##
Summary\r\n\r\nRemoves book-scoped docs variable in preparation for
eventual migration\r\nto
Docsmobile","sha":"a36a370878e75a0537e960bd580eb06acc0fd52e"}},{"branch":"8.13","label":"v8.13.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
shainaraskas added a commit to shainaraskas/kibana that referenced this pull request Mar 14, 2024
shainaraskas added a commit to shainaraskas/kibana that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.13.0 v8.13.1 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants