Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rollups] Fix functional tests #186103

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

ElenaStoeva
Copy link
Contributor

@ElenaStoeva ElenaStoeva commented Jun 12, 2024

Fixes #183975
Fixes #183976
Fixes #183925
Fixes #183926
Fixes #183927
Fixes #104569
Fixes #56816
Fixes #168267

Summary

This PR fixes the failing Rollup functional tests. The reason for the failures is that, since 8.15, Es doesn't allow creating a new rollup job if there is no existing rollup usage in the cluster, where rollup usage is considered rollup jobs or rollup indices. To fix the tests, we create a mock rollup index which essentially is an index that has a _meta mappings property with rollup information.

Flaky test runner build x200: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6316

@ElenaStoeva ElenaStoeva added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Rollups labels Jun 12, 2024
@ElenaStoeva ElenaStoeva self-assigned this Jun 12, 2024
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner June 12, 2024 16:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6298

[❌] x-pack/test/functional/apps/rollup_job/config.ts: 0/200 tests passed.

see run history

@ElenaStoeva ElenaStoeva marked this pull request as draft June 13, 2024 08:46
@ElenaStoeva ElenaStoeva marked this pull request as ready for review June 13, 2024 09:03
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6316

[✅] x-pack/test/functional/apps/rollup_job/config.ts: 200/200 tests passed.

see run history

@ElenaStoeva ElenaStoeva merged commit b44e778 into elastic:main Jun 13, 2024
18 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 13, 2024
@ElenaStoeva ElenaStoeva deleted the rollups/fix-functional-tests branch June 24, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Rollups release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.15.0
Projects
None yet
5 participants