Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rollups] Add deprecated prompt #185896

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

ElenaStoeva
Copy link
Contributor

@ElenaStoeva ElenaStoeva commented Jun 10, 2024

Closes #185861

Summary

This PR replaces the empty prompt in Rollup Jobs with a deprecation prompt:

Screenshot 2024-06-10 at 17 55 38

How to test:

  1. Start Es and Kibana
  2. Go to Stack Management -> Rollup Jobs
  3. Since there are no existing rollup jobs, verify that the deprecation prompt is displayed and the Downsampling documentation link is correct.

Checklist

@ElenaStoeva
Copy link
Contributor Author

/ci

@ElenaStoeva ElenaStoeva self-assigned this Jun 10, 2024
@ElenaStoeva ElenaStoeva added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Rollups v8.15.0 labels Jun 10, 2024
@ElenaStoeva ElenaStoeva marked this pull request as ready for review June 10, 2024 17:50
@ElenaStoeva ElenaStoeva requested review from a team as code owners June 10, 2024 17:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@yuliacech yuliacech self-requested a review June 17, 2024 09:11
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @ElenaStoeva! The deprecated prompt works as expected, tested locally and changes LGTM 👍

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc link changes LGTM

@ElenaStoeva ElenaStoeva enabled auto-merge (squash) June 17, 2024 15:22
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #24 / Cloud Security Posture Test adding Cloud Security Posture Integrations KSPM EKS KSPM EKS Shared Credentials KSPM EKS Shared Credentials Workflow
  • [job] [logs] Jest Tests #16 / ManualRuleRunModal should render confirmation button disabled if invalid time range has been selected
  • [job] [logs] Jest Tests #16 / ManualRuleRunModal should render confirmation button disabled if selected end date is in future
  • [job] [logs] Jest Tests #16 / ManualRuleRunModal should render confirmation button disabled if selected start date is more than 90 days in the past

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
rollup 138 139 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 142.3KB 142.4KB +48.0B
rollup 114.3KB 114.3KB -39.0B
total +9.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 415.4KB 415.4KB +48.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

@ElenaStoeva ElenaStoeva merged commit 1cca809 into elastic:main Jun 17, 2024
23 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 17, 2024
@ElenaStoeva ElenaStoeva deleted the rollups/add-deprecated-prompt branch June 24, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Rollups release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rollup Jobs] Modify empty state to deprecation prompt
6 participants