Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #18838 incorrect 403 message when generating reports #19054

Merged
merged 3 commits into from
May 16, 2018
Merged

Fix #18838 incorrect 403 message when generating reports #19054

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07c7c3a
Fix #18838 incorrect 403 message when generating reports
chrisdavies May 14, 2018
ed256e6
Merge branch 'master' of github.com:elastic/kibana into bug/reporting…
chrisdavies May 16, 2018
57a0ebc
Attempt to fix broken tests
chrisdavies May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions x-pack/plugins/reporting/public/directives/export_config/export_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@ module.directive('exportConfig', ($rootScope, reportingDocumentControl, reportin
});
}

if (err.status === 403) {
return toastNotifications.addDanger({
title: 'Reporting error',
text: `You don't have permission to generate this report.`,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll have to add in 'data-test-subj': 'permissionReportError' and update the failing test so it now makes sure you get this error. Otherwise, LGTM!

}

toastNotifications.addDanger({
title: 'Reporting error',
text: err.message || `Can't reach the server. Please try again.`,
Expand Down