[Uptime] Localization #28183

justinkambic · 2019-01-07T16:47:04Z

Summary

Resolves #27524.

Add translations to uptime plugin.

Testing this PR

Load the Uptime plugin from the Kibana sidebar without any heartbeat data
Ensure the empty state loads correctly and the copy looks right
Start logging some heartbeat data for up/down services
- Check the Overview page, as well as a Monitor page

elasticmachine · 2019-01-07T16:47:06Z

Pinging @elastic/uptime

elasticmachine · 2019-01-07T17:22:00Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

x-pack/plugins/uptime/public/components/queries/error_list/error_list.tsx

elasticmachine · 2019-01-09T18:17:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

andrewvc

Found one tiny bug :(

x-pack/plugins/uptime/public/components/queries/ping_list/ping_list.tsx

andrewvc

LGTM

elasticmachine · 2019-01-09T20:27:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-10T18:35:29Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

x-pack/plugins/uptime/public/components/functional/snapshot_histogram.tsx

maryia-lapata

Good job!
I added some comments regarding message id naming, please fix the similar cases as well.
Also I noticed some not-translatable labels. If this PR implies translation of all labels, please take a look at the files again and add translations for missed labels.

Also there is a tool that validates translations for id duplicates, unused placeholders in values and so on. This tool is included in CI job. You can also run it manually: node scripts/i18n_check. More info in read.me

x-pack/plugins/uptime/public/components/functional/snapshot_histogram.tsx

x-pack/plugins/uptime/public/components/queries/empty_state/empty_state.tsx

x-pack/plugins/uptime/public/register_feature.ts

x-pack/plugins/uptime/public/uptime_app.tsx

maryia-lapata · 2019-01-11T11:53:56Z

x-pack/plugins/uptime/public/uptime_app.tsx

+                          <EuiDatePicker
+                            selected={moment(this.state.dateRangeStart)}
+                            isInvalid={dateRangeIsInvalid()}
+                            aria-label="Start Date"


I think this label should be translated as well.

Resolved in 689a403.

…stogram.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co>

justinkambic · 2019-01-11T22:11:23Z

jenkins test this

elasticmachine · 2019-01-11T22:54:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-14T21:20:22Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-15T15:14:35Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

maryia-lapata

Great! Please fix small comments.
Thank you for descriptions for messages!

I noticed the following untranslated labels:
https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/index.ts#L20
https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/components/queries/monitor_status_bar/monitor_status_bar.tsx#L51
https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/components/queries/snapshot/snapshot.tsx#L53
https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/components/queries/snapshot/snapshot.tsx#L56
https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/components/utility/date_range/date_range_picker.tsx 4 labels
https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/components/utility/date_range/option_definitions.ts 4 labels

x-pack/plugins/uptime/public/components/queries/snapshot/snapshot.tsx

x-pack/plugins/uptime/public/uptime_app.tsx

maryia-lapata · 2019-01-15T15:21:14Z

x-pack/plugins/uptime/public/components/queries/error_list/error_list.tsx

+                {
+                  field: 'type',
+                  name: i18n.translate('xpack.uptime.errorList.errorTypeColumnLabel', {
+                    defaultMessage: 'Error type',


Error Type -> Error type is it a typo?

I believe the guideline for copy when it relates to improper nouns and the like in headings and labels is to capitalize only the first word and lowercase the remaining words. More of a typo on my part originally.

Implement PR feedback. Co-Authored-By: justinkambic <justin.kambic@elastic.co>

…hot.tsx Implement a PR suggestion. Co-Authored-By: justinkambic <justin.kambic@elastic.co>

…hot.tsx Implement a PR change. Co-Authored-By: justinkambic <justin.kambic@elastic.co>

justinkambic · 2019-01-15T16:42:00Z

@maryia-lapata

https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/components/utility/date_range/date_range_picker.tsx 4 labels
https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/components/utility/date_range/option_definitions.ts 4 labels

This code is getting deleted in a later PR #28217 so there's no need to translate it.

The rest of the labels you spotted are translated in: 237e8ef.

elasticmachine · 2019-01-15T17:05:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

maryia-lapata

LGTM

justinkambic · 2019-01-16T14:44:30Z

jenkins test this

elasticmachine · 2019-01-16T15:16:25Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-16T15:54:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

justinkambic · 2019-01-16T15:56:22Z

jenkins test this

elasticmachine · 2019-01-16T20:56:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Add localization tokens. * Fix import errors. * Rename a translation key/message. Fix copy/paste mistake. * Make i18n provider root element of application. * Add xpack.uptime to .i18nrc.json. * Remove icon. * Update x-pack/plugins/uptime/public/components/functional/snapshot_histogram.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update x-pack/plugins/uptime/public/components/functional/snapshot_histogram.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update x-pack/plugins/uptime/public/components/queries/empty_state/empty_state.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Replace ... with …. * Update x-pack/plugins/uptime/public/components/queries/empty_state/empty_state.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update x-pack/plugins/uptime/public/components/queries/empty_state/empty_state.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update x-pack/plugins/uptime/public/components/queries/empty_state/empty_state.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Move a link to formatted message value prop. * Update x-pack/plugins/uptime/public/components/queries/error_list/error_list.tsx Reformat naming of column localization keys. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update error list table column localization keys. * Update x-pack/plugins/uptime/public/components/queries/filter_bar/filter_bar.tsx Update label key. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update label localization keys for filter bar. * Update x-pack/plugins/uptime/public/components/queries/filter_bar/filter_bar.tsx Update localization key for filter bar tooltip title. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update x-pack/plugins/uptime/public/components/queries/filter_bar/filter_bar.tsx Update localization key for filter bar tooltip text. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update x-pack/plugins/uptime/public/components/queries/monitor_charts/monitor_charts.tsx Improve RTT Breakdown title localization key. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Add description and update a localization key. * Update x-pack/plugins/uptime/public/components/queries/monitor_charts/monitor_charts.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update x-pack/plugins/uptime/public/components/queries/monitor_list/monitor_list.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update monitor charts localization keys. * Extract conditional message values into separate translate calls. * Update x-pack/plugins/uptime/public/components/queries/monitor_list/monitor_list.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update monitor list column header localization keys. * Update x-pack/plugins/uptime/public/components/queries/monitor_list/monitor_list.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Monitor list update localization key of series label. * Update x-pack/plugins/uptime/public/components/queries/monitor_list/monitor_list.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update x-pack/plugins/uptime/public/components/queries/monitor_status_bar/monitor_status_bar.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Improve destructuring in monitor status bar, extract conditional values to separate translations. * Update x-pack/plugins/uptime/public/components/queries/monitor_status_bar/monitor_status_bar.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update x-pack/plugins/uptime/public/components/queries/monitor_status_bar/monitor_status_bar.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Apply suggestions from code review Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update localization keys for ping list. * Apply suggestions from code review Implement PR suggestions for PingList component. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Apply suggestions from code review Add PR suggestions for Snapshot component. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update localization keys for Snapshot component. * Remove unneeded translation. * Update x-pack/plugins/uptime/public/register_feature.ts Implement PR suggestion for register_feature.ts Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Apply suggestions from code review Implement PR suggestions for uptime app. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update localization, add translations for UptimeApp. * Run prettier to fix style problem. * Fix duplicate localization keys. * Update x-pack/plugins/uptime/public/uptime_app.tsx Implement PR feedback. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update x-pack/plugins/uptime/public/components/queries/snapshot/snapshot.tsx Implement a PR suggestion. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Update x-pack/plugins/uptime/public/components/queries/snapshot/snapshot.tsx Implement a PR change. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Implement PR feedback.

justinkambic · 2019-01-16T23:03:23Z

Backported to:
6.x/6.7.0 4be203c
#28879

justinkambic added v7.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v6.7.0 labels Jan 7, 2019

justinkambic requested a review from mattapperson January 9, 2019 16:55

justinkambic mentioned this pull request Jan 9, 2019

[Uptime] 6.7/7.0 Meta Issue #28090

Closed

31 tasks

justinkambic requested review from andrewvc and removed request for mattapperson January 9, 2019 17:37

justinkambic added 2 commits January 9, 2019 12:39

Add localization tokens.

b3b5fbc

Fix import errors.

10c51cf

justinkambic force-pushed the uptime_translate branch from 2345d47 to 10c51cf Compare January 9, 2019 17:40

andrewvc reviewed Jan 9, 2019

View reviewed changes

x-pack/plugins/uptime/public/components/queries/error_list/error_list.tsx Outdated Show resolved Hide resolved

andrewvc requested changes Jan 9, 2019

View reviewed changes

x-pack/plugins/uptime/public/components/queries/ping_list/ping_list.tsx Outdated Show resolved Hide resolved

Rename a translation key/message. Fix copy/paste mistake.

994eb8c

justinkambic added the review label Jan 9, 2019

andrewvc approved these changes Jan 9, 2019

View reviewed changes

justinkambic requested a review from azasypkin January 10, 2019 15:56

azasypkin requested a review from maryia-lapata January 10, 2019 16:06

justinkambic added 2 commits January 10, 2019 13:04

Make i18n provider root element of application.

e448335

Add xpack.uptime to .i18nrc.json.

9e51e5e

maryia-lapata reviewed Jan 11, 2019

View reviewed changes

x-pack/plugins/uptime/public/components/functional/snapshot_histogram.tsx Outdated Show resolved Hide resolved

maryia-lapata suggested changes Jan 11, 2019

View reviewed changes

justinkambic and others added 4 commits January 11, 2019 09:19

Merge branch 'master' into uptime_translate

224cd0d

Remove icon.

7ee3a02

Update x-pack/plugins/uptime/public/components/functional/snapshot_hi…

85605bc

…stogram.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co>

Update x-pack/plugins/uptime/public/components/functional/snapshot_hi…

fb1edbf

…stogram.tsx Co-Authored-By: justinkambic <justin.kambic@elastic.co>

azasypkin removed their request for review January 14, 2019 11:12

Merge branch 'master' into uptime_translate

192c3be

Merge branch 'master' into uptime_translate

8e42e80

maryia-lapata reviewed Jan 15, 2019

View reviewed changes

maryia-lapata and others added 4 commits January 15, 2019 11:20

Update x-pack/plugins/uptime/public/uptime_app.tsx

3875b30

Implement PR feedback. Co-Authored-By: justinkambic <justin.kambic@elastic.co>

Update x-pack/plugins/uptime/public/components/queries/snapshot/snaps…

f8728ae

…hot.tsx Implement a PR suggestion. Co-Authored-By: justinkambic <justin.kambic@elastic.co>

Update x-pack/plugins/uptime/public/components/queries/snapshot/snaps…

f206bae

…hot.tsx Implement a PR change. Co-Authored-By: justinkambic <justin.kambic@elastic.co>

Implement PR feedback.

237e8ef

maryia-lapata approved these changes Jan 16, 2019

View reviewed changes

Merge branch 'master' into uptime_translate

d881a4b

Merge branch 'master' into uptime_translate

d4f7de1

justinkambic merged commit a7f249d into elastic:master Jan 16, 2019

justinkambic mentioned this pull request Jan 16, 2019

[Uptime] Localization (#28183) Backport #28879

Merged

justinkambic deleted the uptime_translate branch January 16, 2019 22:06

justinkambic removed the review label Jan 17, 2019

justinkambic mentioned this pull request Jan 17, 2019

[Uptime] Implement EuiSuperDatePicker #28217

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Localization #28183

[Uptime] Localization #28183

justinkambic commented Jan 7, 2019 •

edited

Loading

elasticmachine commented Jan 7, 2019

elasticmachine commented Jan 7, 2019

elasticmachine commented Jan 9, 2019

andrewvc left a comment

andrewvc left a comment

elasticmachine commented Jan 9, 2019

elasticmachine commented Jan 10, 2019

maryia-lapata left a comment •

edited

Loading

maryia-lapata Jan 11, 2019

justinkambic Jan 11, 2019

justinkambic commented Jan 11, 2019

elasticmachine commented Jan 11, 2019

elasticmachine commented Jan 14, 2019

elasticmachine commented Jan 15, 2019

maryia-lapata left a comment

maryia-lapata Jan 15, 2019

justinkambic Jan 15, 2019

justinkambic commented Jan 15, 2019 •

edited

Loading

elasticmachine commented Jan 15, 2019

maryia-lapata left a comment

justinkambic commented Jan 16, 2019

elasticmachine commented Jan 16, 2019

elasticmachine commented Jan 16, 2019

justinkambic commented Jan 16, 2019

elasticmachine commented Jan 16, 2019

justinkambic commented Jan 16, 2019

[Uptime] Localization #28183

[Uptime] Localization #28183

Conversation

justinkambic commented Jan 7, 2019 • edited Loading

Summary

Testing this PR

elasticmachine commented Jan 7, 2019

elasticmachine commented Jan 7, 2019

💔 Build Failed

elasticmachine commented Jan 9, 2019

💚 Build Succeeded

andrewvc left a comment

Choose a reason for hiding this comment

andrewvc left a comment

Choose a reason for hiding this comment

elasticmachine commented Jan 9, 2019

💚 Build Succeeded

elasticmachine commented Jan 10, 2019

💔 Build Failed

maryia-lapata left a comment • edited Loading

Choose a reason for hiding this comment

maryia-lapata Jan 11, 2019

Choose a reason for hiding this comment

justinkambic Jan 11, 2019

Choose a reason for hiding this comment

justinkambic commented Jan 11, 2019

elasticmachine commented Jan 11, 2019

💚 Build Succeeded

elasticmachine commented Jan 14, 2019

💔 Build Failed

elasticmachine commented Jan 15, 2019

💔 Build Failed

maryia-lapata left a comment

Choose a reason for hiding this comment

maryia-lapata Jan 15, 2019

Choose a reason for hiding this comment

justinkambic Jan 15, 2019

Choose a reason for hiding this comment

justinkambic commented Jan 15, 2019 • edited Loading

elasticmachine commented Jan 15, 2019

💔 Build Failed

maryia-lapata left a comment

Choose a reason for hiding this comment

justinkambic commented Jan 16, 2019

elasticmachine commented Jan 16, 2019

💔 Build Failed

elasticmachine commented Jan 16, 2019

💔 Build Failed

justinkambic commented Jan 16, 2019

elasticmachine commented Jan 16, 2019

💚 Build Succeeded

justinkambic commented Jan 16, 2019

justinkambic commented Jan 7, 2019 •

edited

Loading

maryia-lapata left a comment •

edited

Loading

justinkambic commented Jan 15, 2019 •

edited

Loading