chore: remove duplicate include path from tsconfig #31499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w33ble
added
review
Team:Core
|
Pinging @elastic/kibana-platform |
|
Pinging @elastic/kibana-operations |
💔 Build Failed |
jbudz
approved these changes
Feb 19, 2019
💔 Build Failed |
in x-pack tsconfig
w33ble
force-pushed
the
chore/dedupe-typings-includes
branch
from
43c68b9
to
369a260
Compare
💚 Build Succeeded |
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Feb 19, 2019
in x-pack tsconfig
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Feb 19, 2019
in x-pack tsconfig
w33ble
added a commit
that referenced
this pull request
Feb 20, 2019
w33ble
added a commit
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tsconfigfile in X-Pack had a duplicate path in"include".It looks like #29951 and #29663 both added
"typings/**/*", the first at the top, and the second at the bottom. As a result, the path ended up being included twice once both PR's were merged.This PR keeps the first occurrence and removes the second.
Since #29951 is 7.0+ only, the list in 6.7 is correct, and this only needs backporting to 7.0+.