Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Fix unsigned integer parsing error and add tests #40526

Merged
merged 5 commits into from
Jul 9, 2019
Merged

[Uptime] Fix unsigned integer parsing error and add tests #40526

merged 5 commits into from
Jul 9, 2019

Conversation

justinkambic
Copy link
Contributor

Summary

We are seeing bad values for our timestamps in the UI today:
image

The cause of this is our reliance on the UnsignedInteger custom scalar. This patch seeks to add some tests and stability to support passing Date strings like '2019-07-08T16:59:09.796Z' to the resolver, to support proper serialization when passing these values down to the client.

Testing this PR

  1. To test this PR, run Heartbeat and Kibana master, you should be able to see erroneous reporting of 'X months ago' on the Overview page like the screenshot above.
  2. Run this patch and ensure that when you refresh the Overview page, you are seeing accurate readings on the timestamp.
    image

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.3.0 v7.4.0 labels Jul 8, 2019
@justinkambic justinkambic self-assigned this Jul 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

@elasticmachine
Copy link
Contributor

💔 Build Failed

jasonrhodes
jasonrhodes approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic justinkambic merged commit ece704b into elastic:master Jul 9, 2019
@justinkambic justinkambic mentioned this pull request Jul 9, 2019
Merged
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jul 9, 2019
@justinkambic
[Uptime] Fix unsigned integer parsing error and add tests (elastic#40526
ab22088 
)

* Fix unsigned integer parsing error and add tests.

* Fix new defect, improve serialization function and add another test.

* Fix redundant code.

* Remove redundant function call.
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jul 9, 2019
@justinkambic
[Uptime] Fix unsigned integer parsing error and add tests (elastic#40526
9792913 
)

* Fix unsigned integer parsing error and add tests.

* Fix new defect, improve serialization function and add another test.

* Fix redundant code.

* Remove redundant function call.
This was referenced Jul 9, 2019
Merged
Merged
justinkambic added a commit that referenced this pull request Jul 9, 2019
@justinkambic
[Uptime] Fix unsigned integer parsing error and add tests (#40526) (#…
d64dbb2 
…40616)

* Fix unsigned integer parsing error and add tests.

* Fix new defect, improve serialization function and add another test.

* Fix redundant code.

* Remove redundant function call.
@justinkambic
Copy link
Contributor Author

justinkambic commented Jul 9, 2019 •
edited
Loading

Backported to:

justinkambic added a commit to justinkambic/kibana that referenced this pull request Jul 9, 2019
@justinkambic
[Uptime] Fix unsigned integer parsing error and add tests (elastic#40526
707adf2 
)

* Fix unsigned integer parsing error and add tests.

* Fix new defect, improve serialization function and add another test.

* Fix redundant code.

* Remove redundant function call.
toddself pushed a commit to toddself/kibana that referenced this pull request Jul 9, 2019
@justinkambic @toddself
[Uptime] Fix unsigned integer parsing error and add tests (elastic#40526
8644345 
)

* Fix unsigned integer parsing error and add tests.

* Fix new defect, improve serialization function and add another test.

* Fix redundant code.

* Remove redundant function call.
justinkambic added a commit that referenced this pull request Jul 9, 2019
@justinkambic
[Uptime] Fix unsigned integer parsing error and add tests (#40526) (#…
b10f7e9 
…40617)

* Fix unsigned integer parsing error and add tests.

* Fix new defect, improve serialization function and add another test.

* Fix redundant code.

* Remove redundant function call.
@justinkambic justinkambic deleted the uptime_unsigned-int-parsing-fix branch July 9, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrhodes jasonrhodes jasonrhodes approved these changes

@andrewvc andrewvc Awaiting requested review from andrewvc

Assignees

@justinkambic justinkambic

Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.3.0 v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinkambic @elasticmachine @jasonrhodes