Add retry to find.existsByDisplayedByCssSelector #48734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
added
test_ui_functional
v8.0.0
release_note:skip
9 tasks
💚 Build Succeeded |
dmlemeshko
reviewed
Oct 22, 2019
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
retest |
💔 Build Failed |
pheyos
changed the title
|
@elasticmachine merge upstream |
💔 Build Failed |
💔 Build Failed |
|
retest |
dmlemeshko
approved these changes
Nov 15, 2019
💚 Build Succeeded |
|
Dashboard snapshot test (oss ciGroup3) passed 20x with this PR, see https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/5/ |
|
retest |
💚 Build Succeeded |
|
Dashboard snapshot test (oss ciGroup3) passed another 20x with this PR, see https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/6/ |
|
retest |
LeeDr
approved these changes
Nov 15, 2019
There was a problem hiding this comment.
LGTM and Thanks for making this improvement!
At some point we should refactor the save visualization functionality to be consistent with this;
https://github.com/elastic/kibana/blob/master/test/functional/page_objects/visualize_page.js#L766
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Nov 18, 2019
This PR fixes timeout handling in `find.existsByDisplayedByCssSelector` for elements that are found but (not yet) displayed.
pheyos
added a commit
that referenced
this pull request
Nov 18, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 18, 2019
…her [skip ci] * upstream/master: (54 commits) allows plugins to define validation schema for "enabled" flag (elastic#50286) Add retry to find.existsByDisplayedByCssSelector (elastic#48734) [i18n] integrate latest translations (elastic#50864) ui/resize_checker 👉 src/plugins/kibana_utils (elastic#44750) Fix @reach/router types (elastic#50863) [ML] Adding ML node warning to overview and analytics pages (elastic#50766) Bump storybook dependencies (elastic#50752) [APM Replace usage of idx with optional chaining (elastic#50849) [SIEM] Fix eslint errors (elastic#49713) Improve "Browser client is out of date" error message (elastic#50296) [SIEM][Detection Engine] REST API improvements and changes from UI/UX feedback (elastic#50797) Move @kbn/es-query into data plugin - es-query folder (elastic#50182) Index Management new platform migration (elastic#49359) Increase retry for cloud snapshot to finish (elastic#50781) Removing EuiCode from inside EuiPanel (elastic#50683) [SIEM] Tests for search_after and bulk index (elastic#50129) Make babel understand TypeScript 3.7 syntax (elastic#50772) Fixing mocha tests and broken password change status codes (elastic#50704) [Canvas] Use compressed forms in sidebar (elastic#49419) Add labels to shell scripts in Jenkins (elastic#49657) ...
This was referenced Nov 20, 2019
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Dec 3, 2019
This PR fixes timeout handling in `find.existsByDisplayedByCssSelector` for elements that are found but (not yet) displayed.
pheyos
added a commit
that referenced
this pull request
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are scenarios where
testSubjects.existOrFailfails earlier than the provided timeout because the timeout is only applied to the find operation and not to the filter for displayed elements, e.g.may fail after a few milliseconds, if
myTestSubjectis found that fast but is not visible yet.In order to make the whole
existOrFailoperation follow the provided timeout, this PR adds a retry to the underlyingfind.existsByDisplayedByCssSelector.