[SIEM] Fix eslint errors #49713
Merged
[SIEM] Fix eslint errors #49713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykkopycinski
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
| @@ -40,14 +40,14 @@ export const getHumanReadableLogonType = (endgameLogonType: number | null | unde | |||
| export const getHostNameSeparator = (eventAction: string | null | undefined): string => | |||
| eventAction === 'explicit_user_logon' ? i18n.TO : '@'; | |||
|
|
|||
| export const useTargetUserAndTargetDomain = (eventAction: string | null | undefined): boolean => | |||
There was a problem hiding this comment.
@andrew-goldstein seems only hooks can start with use, are you ok to change the name to get or maybe do you have some other suggestion for the name?
patrykkopycinski
requested review from
andrew-goldstein,
stephmilovic and
spong
💔 Build Failed |
| @@ -175,7 +175,7 @@ const DraggableWrapperComponent = React.memo<Props>( | |||
| return () => { | |||
| unRegisterProvider!({ id: dataProvider.id }); | |||
| }; | |||
| }, []); | |||
There was a problem hiding this comment.
@spalger what in case we want to treat useEffect as componentDidMount should we use eslint-disable-line for that?
💔 Build Failed |
spong
reviewed
Oct 30, 2019
x-pack/legacy/plugins/siem/public/components/embeddables/embedded_map.tsx
Outdated
Show resolved
Hide resolved
patrykkopycinski
force-pushed
the
fix/siem-eslint
branch
from
4aa4dbf
to
f29c872
Compare
💔 Build Failed |
|
jenkins, test this |
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💔 Build Failed |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💔 Build Failed |
|
@elasticmachine merge upstream |
💔 Build Failed |
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 18, 2019
…her [skip ci] * upstream/master: (54 commits) allows plugins to define validation schema for "enabled" flag (elastic#50286) Add retry to find.existsByDisplayedByCssSelector (elastic#48734) [i18n] integrate latest translations (elastic#50864) ui/resize_checker 👉 src/plugins/kibana_utils (elastic#44750) Fix @reach/router types (elastic#50863) [ML] Adding ML node warning to overview and analytics pages (elastic#50766) Bump storybook dependencies (elastic#50752) [APM Replace usage of idx with optional chaining (elastic#50849) [SIEM] Fix eslint errors (elastic#49713) Improve "Browser client is out of date" error message (elastic#50296) [SIEM][Detection Engine] REST API improvements and changes from UI/UX feedback (elastic#50797) Move @kbn/es-query into data plugin - es-query folder (elastic#50182) Index Management new platform migration (elastic#49359) Increase retry for cloud snapshot to finish (elastic#50781) Removing EuiCode from inside EuiPanel (elastic#50683) [SIEM] Tests for search_after and bulk index (elastic#50129) Make babel understand TypeScript 3.7 syntax (elastic#50772) Fixing mocha tests and broken password change status codes (elastic#50704) [Canvas] Use compressed forms in sidebar (elastic#49419) Add labels to shell scripts in Jenkins (elastic#49657) ...
patrykkopycinski
added a commit
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SIEM related eslint issues #49244
#49571
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately