Make babel understand TypeScript 3.7 syntax #50772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
timroes
commented
Nov 15, 2019
| @@ -54,7 +54,7 @@ class RequestAdapter extends EventEmitter { | |||
| name, | |||
| startTime: Date.now(), | |||
| status: RequestStatus.PENDING, | |||
| id: _.get(params, 'id', uuid()), | |||
| id: params.id ?? uuid(), | |||
There was a problem hiding this comment.
ℹ️ I just changed this line to see if it actually passes on CI too (and not just locally).
timroes
added
the
release_note:skip
tylersmalley
approved these changes
Nov 15, 2019
|
@elasticmachine merge upstream |
|
There were some flaky tests I skipped in master since you opened this PR. To avoid the chance they would effect this CI run I merged the updates in from master. Since we are not currently canceling in-flight CI jobs we should still see the originating job reported. Hoping this cuts down on the waiting. |
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
💚 Build Succeeded |
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Nov 15, 2019
* Use correct babel plugins * Make one change using new operator * Fix i18n babel config
timroes
pushed a commit
that referenced
this pull request
Nov 16, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 18, 2019
…her [skip ci] * upstream/master: (54 commits) allows plugins to define validation schema for "enabled" flag (elastic#50286) Add retry to find.existsByDisplayedByCssSelector (elastic#48734) [i18n] integrate latest translations (elastic#50864) ui/resize_checker 👉 src/plugins/kibana_utils (elastic#44750) Fix @reach/router types (elastic#50863) [ML] Adding ML node warning to overview and analytics pages (elastic#50766) Bump storybook dependencies (elastic#50752) [APM Replace usage of idx with optional chaining (elastic#50849) [SIEM] Fix eslint errors (elastic#49713) Improve "Browser client is out of date" error message (elastic#50296) [SIEM][Detection Engine] REST API improvements and changes from UI/UX feedback (elastic#50797) Move @kbn/es-query into data plugin - es-query folder (elastic#50182) Index Management new platform migration (elastic#49359) Increase retry for cloud snapshot to finish (elastic#50781) Removing EuiCode from inside EuiPanel (elastic#50683) [SIEM] Tests for search_after and bulk index (elastic#50129) Make babel understand TypeScript 3.7 syntax (elastic#50772) Fixing mocha tests and broken password change status codes (elastic#50704) [Canvas] Use compressed forms in sidebar (elastic#49419) Add labels to shell scripts in Jenkins (elastic#49657) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR actually adds support for the TS 3.7 syntax into babel, since we're not using
tscto compile but babel. This will also allow using those operators in JS code, which should be fine, given that both proposals are stage 3, which is our usual requirement for babel plugins.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately