Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport to 4.3: Fix IndexPattern leaking #5469

Closed
wants to merge 14 commits into from
Closed

Backport to 4.3: Fix IndexPattern leaking #5469

wants to merge 14 commits into from

Commits on Nov 23, 2015

  1. [promise/Constructor] remove non-standard defer arg 

    At some point I added a `defer` arg to the Promise constructor in our promises library. This arg is not a part of ECMA promises or bluebird promises, so I'm removing it to keep compatibility.
    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    54d50cd View commit details
    Browse the repository at this point in the history

  2. [courier/requestQueue] fix get(), added getStartable() 

    get() implies that it will get all pending requests that match a strategy, but it is actually filtering by wether a require is startable. Added getStartable() to accomplish that task and get() now returns all requests that match a strategy.
    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    a7faca6 View commit details
    Browse the repository at this point in the history

  3. [courier/dataSource] also cancel non-startable requests

    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    3f77a90 View commit details
    Browse the repository at this point in the history

  4. [courier] added tests for requesQueue, DocSource, and SearchSource

    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    f8b768a View commit details
    Browse the repository at this point in the history

  5. [courier/DataSource] remove private _myQueued method

    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    7c34d44 View commit details
    Browse the repository at this point in the history

  6. [indexPattern] added early return

    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    a1bc2a2 View commit details
    Browse the repository at this point in the history

  7. [indexPattern] added delete method, call on delete

    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    198fc8c View commit details
    Browse the repository at this point in the history

  8. [indexPattern] don't cache indexPatterns without ids 

    In a few places we are creating index patterners that don't have ids. A primary location is in indexPattern creation, where we will end up setting the id. If we cache the indexPattern before it has an id the cache gets out of sync, so we need to not cache indexPatterns without ids.
    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    6de4f6f View commit details
    Browse the repository at this point in the history

  9. [indexPattern] destroy index patterns that are overwritten

    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    fd025ec View commit details
    Browse the repository at this point in the history

  10. [indexPattern] remove from cache on #destroy()

    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    0c70830 View commit details
    Browse the repository at this point in the history

  11. [indexPattern] protect against changing ids

    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    a7357ea View commit details
    Browse the repository at this point in the history

  12. [indexPattern] prevent excess self.id = ...

    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    98c4f56 View commit details
    Browse the repository at this point in the history

  13. [indexPatterns] revert unneeded change

    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    772f898 View commit details
    Browse the repository at this point in the history

  14. [indexPattern/test] prevent changing ids

    spalger committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    98d303e View commit details
    Browse the repository at this point in the history