[Watcher] Move out of legacy

[jloleysens]

Summary

Continuation of work started in #50908. This is the final step of the New Platform (NP) migration.

TODOs before review

• Figure out what to do with TimeBuckets and MANAGEMENT_SECTION dependencies. Currently this lives inside of a folder called legacy in the watcher NP folder.
• Figure out how we can work around the requirement of style sheets for now (there are a smaller number of styles in watcher, but they should be ported over too)
• More testing on server side, how do we handle un-registering routes? Does the app restart both client and server side?
• Fix tests and CI

How to Review

• I would recommend looking mainly at public/plugin.ts and server/plugin.ts. Most important changes are there - how the plugin starts up and the services it uses.
• For TimeBucket dep we copied the code to the watcher plugin (per [ML] Copy over TimeBuckets into ML code #44249)
• Could be helpful to have a second local copy of the kibana repo so that you can use git-diff like git diff --no-index ../current-master/watcher/public/np_ready/application ./x-pack/plugins/watcher/public/application for a cleaner summary of application specific changes
  • Removed the license expired state as the plugin will not render under those conditions at all now
  • Fixed a router warning issued from license_management, we can move this to another PR but it's quite a small fix
  • legacy folder contains TimeBucket and MANAGEMENT_BREADCRUMB.
• Otherwise, run through UI and ensure that nothing looks weird, create a threshold watch and a JSON watch and let them fire.

TODO

• Revert removal of license error placeholder for now

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[jloleysens]

@joshdover

There are two issues I'm noticing as I was working on this:

1

I'm seeing a situation with watcher when I am on a license that permits use of watcher (e.g., platinum) then run:

curl -XDELETE -v http://elastic:changeme@localhost:9200/_license
curl -XPOST -v http://elastic:changeme@localhost:9200/_license/start_basic\?acknowledge\=true

which reverts to basic, then do a page refresh my links still renders. Clicking on it then hides it as this causes a re-render.

2

The functionality in src/core/public/chrome/ui/header/header.tsx (extendNavLink I think) can get lead into a situation where if the user was on a page in management (like watcher) that is now disabled (as above), they won't be able to get back into management because the app is no longer registered and current default behaviour is to go back to Kibana home, not management home. Perhaps not something new :) just wondering if this is worth creating an issue.

[joshdover]

1

I'm seeing a situation with watcher when I am on a license that permits use of watcher (e.g., platinum) then run:

curl -XDELETE -v http://elastic:changeme@localhost:9200/_license
curl -XPOST -v http://elastic:changeme@localhost:9200/_license/start_basic\?acknowledge\=true

which reverts to basic, then do a page refresh my links still renders. Clicking on it then hides it as this causes a re-render.

It only does this when you revert from trial to basic, or also when starting with basic?

And by link, you mean the management section link, correct?

If you put logs in your license check code, are the logs also broken? This would be helpful in narrowing down whether or not this is a UI issue or an issue with the licensing plugin.

2

The functionality in src/core/public/chrome/ui/header/header.tsx (extendNavLink I think) can get lead into a situation where if the user was on a page in management (like watcher) that is now disabled (as above), they won't be able to get back into management because the app is no longer registered and current default behaviour is to go back to Kibana home, not management home. Perhaps not something new :) just wondering if this is worth creating an issue.

I'm not sure if that is new behavior either, but if so, that would be an issue that maybe the @mattkime could help with. I know he's been digging in the Manaagement app recently for the migration to the New Platform.

[joshdover]

Regarding problem (1):

After reading the code, I think this problems stems from the code around trying to conditionally register the Watcher section based on licensing updates and what not.

I don't think this is the right approach (though the only possible one right now). Instead, I think the Management API needs to support a similar updater$ API to the Application Service (#50223). This would allow plugins to toggle their management app's visibility in the Management navigation based on licensing, feature controls, or other factors. @mattkime what do you think?

[joshdover]

All of this logic could be great simplified if an API like this existed, similar to the Application API:

esSection.registerApp({
  id: 'watcher',
  title: 'Watcher',
  updater$: licensing.license$.pipe(map(license => {
    const { state } = license.check(PLUGIN.ID, PLUGIN.MINIMUM_LICENSE_REQUIRED);
    const hasValidLicense =
      state === LICENSE_CHECK_STATE.Valid && license.getFeature(PLUGIN.ID).isAvailable;
    return {
      status: hasValidLicense ? ManagementAppStatus.accessible : ManagementAppStatus.inaccessible
    };
  })),
  mount(...) { ... },
});

[jloleysens]

@joshdover , for further clarification on scenario 1:

Console logs:

Code changes to emit log:

This speaks to what you've pointed out.

It's specific to the scenario where I've issued a request directly against ES (not from my browser session) to revert to basic. I suppose this would also happen if another user changed the license while I was in Kibana and there was a second emission on the license$. So even though we've disabled the app and prevented it from rendering at all, the management side menu still renders Watcher.

For the second issue I was encountering, I've opened this issue (not sure if there already is one): #55170

[jloleysens]

@elasticmachine merge upstream

[cjcenizal]

Thanks for the orderly commit history! I was able to follow along pretty well. Code LGTM. I've run out of time today so if you'd like me to test locally just hold off on merging and I will get to it tomorrow. Otherwise feel free to merge if you're confident there are no regressions. Might be worth asking @cuff-links to QA this after 7.6 is released.

[cjcenizal]

I haven't dug around for this, so apologies for the dumb question, but what's the data dependency?

[jloleysens]

Looks like a collection of data access functions (based on src/plugins/data/README.md) 😂. There is functionality in there that was pulled from legacy in the TimeBuckets which have been included here.

[jloleysens]

@elasticmachine merge upstream

[cjcenizal]

Tested locally by creating, editing, and deleting both threshold and JSON watches. I also verified that the request flyouts, execution histories, and activation/deactivation actions all work as expected.

[jloleysens]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 923c2d5

History

• 💚 Build #21861 succeeded 7f14e02
• 💔 Build #21836 failed 94296d3
• 💚 Build #21434 succeeded b680298
• 💔 Build #21423 failed ea6fbbe
• 💚 Build #21335 succeeded e47beee

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream