[Uptime] [Test] Add functional test for monitor with location name but no geo #55915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
test_xpack_functional
v8.0.0
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
justinkambic
added
the
release_note:skip
justinkambic
force-pushed
the
uptime_test-location-no-geo
branch
2 times, most recently
from
df76b3c
to
f7bb1f0
Compare
|
@elasticmachine merge upstream |
justinkambic
force-pushed
the
uptime_test-location-no-geo
branch
from
6718cfd
to
5716051
Compare
andrewvc
reviewed
Jan 27, 2020
| before(async () => { | ||
| /** | ||
| * This mogrify function will strip the documents of their location | ||
| * data (but preserve their locaion name), which is necessary for |
There was a problem hiding this comment.
Thanks for catching this. We will blame it on awful 2017 MBP keyboard 😆.
There was a problem hiding this comment.
Repaired in eb1d96e.
| ) { | ||
| await pageObjects.common.navigateToApp('uptime'); | ||
| await pageObjects.timePicker.setAbsoluteRange(datePickerStartValue, datePickerEndValue); | ||
| await uptimeService.navigateToMonitorWithId(monitorId); | ||
| if ((await uptimeService.getMonitorNameDisplayedOnPageTitle()) !== monitorName) { | ||
| if ( | ||
| !!monitorName && |
There was a problem hiding this comment.
Do we need !! in javascript? It's useful when you want to return a bool, but isn't it equivalent as just omitting it in a boolean expression?
There was a problem hiding this comment.
Deleted in 2056471.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jan 29, 2020
…t no geo (elastic#55915) * Add unit test for missing geo on named location. * WIP writing a functional test. * New named-location with no geo data test is functioning. * Update snaps for functional test attribute. * Rename test. * Remove unnecessary async syntax. * Delete unneeded symbols. * Remove unnecessary boolean conversion. * Fix typo in a comment.
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jan 29, 2020
…t no geo (elastic#55915) * Add unit test for missing geo on named location. * WIP writing a functional test. * New named-location with no geo data test is functioning. * Update snaps for functional test attribute. * Rename test. * Remove unnecessary async syntax. * Delete unneeded symbols. * Remove unnecessary boolean conversion. * Fix typo in a comment.
justinkambic
added a commit
that referenced
this pull request
Jan 29, 2020
…t no geo (#55915) (#56330) * Add unit test for missing geo on named location. * WIP writing a functional test. * New named-location with no geo data test is functioning. * Update snaps for functional test attribute. * Rename test. * Remove unnecessary async syntax. * Delete unneeded symbols. * Remove unnecessary boolean conversion. * Fix typo in a comment.
justinkambic
added a commit
that referenced
this pull request
Jan 29, 2020
…t no geo (#55915) (#56331) * Add unit test for missing geo on named location. * WIP writing a functional test. * New named-location with no geo data test is functioning. * Update snaps for functional test attribute. * Rename test. * Remove unnecessary async syntax. * Delete unneeded symbols. * Remove unnecessary boolean conversion. * Fix typo in a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes elastic/uptime#141.
Test if the appropriate UI is displayed when monitor has a name but no geo data.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers