Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detection of "system requests" in plugins #57149

Merged
merged 8 commits into from
Feb 13, 2020
Merged

Fix detection of "system requests" in plugins #57149

merged 8 commits into from
Feb 13, 2020

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Feb 7, 2020

This aligns plugin usage with the new way that the Kibana Platform handles checking for system requests that was introduced in #53734.

Resolves #57119.

@jportner jportner added v7.7.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 7, 2020
@jportner
Fix detection of "system requests"
898e2d5 
This aligns plugin usage with the new way that the Kibana Platform
handles checking for system requests.
@jportner
Update tests
34987b1
@jportner jportner force-pushed the issue-57119-fix-system-request-header branch from 66b2917 to 34987b1 Compare February 7, 2020 20:16
@jportner
Copy link
Contributor Author

jportner commented Feb 7, 2020

Jenkins test this

@jportner jportner marked this pull request as ready for review February 9, 2020 13:42
@jportner jportner requested a review from a team February 9, 2020 13:42
@jportner jportner requested a review from a team as a code owner February 9, 2020 13:42
kobelb
kobelb reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two more stray usages of kbn-system-api here and here, you mind changing those as well?

src/legacy/core_plugins/kibana/server/lib/system_api.js Outdated Show resolved Hide resolved
src/plugins/kibana_legacy/public/utils/system_api.ts Show resolved Hide resolved
@jportner
Copy link
Contributor Author

There are two more stray usages of kbn-system-api here and here, you mind changing those as well?

Good catch, not sure how I missed those. Updated in e158fc4.

I don't know why I can't currently reply in the "thread" for your other comment, but I'll wait to hear from the Platform team.

flash1293
flash1293 approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana app changes lgtm

@jportner
Copy link
Contributor Author

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner merged commit 5b5421c into elastic:master Feb 13, 2020
@jportner jportner deleted the issue-57119-fix-system-request-header branch February 13, 2020 21:33
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 13, 2020
@gmmorris
Merge branch 'master' into alerting/instance-pagination
f79227a 
* master: (22 commits)
  skip flaky suite (elastic#50018)
  skip settings tests (elastic#57608)
  skip failing suite (elastic#44631)
  [SIEM] [Case] Initial UI (elastic#57283)
  handle viewing sample dashboards on default dist (elastic#57510)
  Fix detection of "system requests" in plugins (elastic#57149)
  [ML] New Platform server shim: update job service schema (elastic#57614)
  skip flaky suite (elastic#44631)
  [APM] Update monospace font family variable (elastic#57555)
  skip flaky test (elastic#57377)
  Skip save query tests (elastic#57589)
  [Maps] allow simultaneous opening of multiple tooltips (elastic#57226)
  [Uptime] Fix/host connected components (elastic#56969)
  [logs][metrics][docs] Update screenshots for 7.6 (elastic#57254)
  [ML] New Platform server shim: update job service routes to use new platform router (elastic#57403)
  [Maps] Fix document source top hits split by scripted field (elastic#57481)
  Use log4j pattern syntax (elastic#57433)
  [ML] Categorization field example endpoint tests (elastic#57471)
  [Lens] Filter out pinned filters from saved object of Lens (elastic#57197)
  Lens client side shim cleanup (elastic#56976)
  ...
@jportner jportner mentioned this pull request Feb 13, 2020
Merged
jportner added a commit that referenced this pull request Feb 14, 2020
@jportner
Fix detection of "system requests" in plugins (#57149) (#57639)
65f065e 
This aligns plugin usage with the new way that the Kibana Platform
handles checking for system requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov left review comments

@kobelb kobelb kobelb approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backported release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idle sessions never expire
5 participants
@jportner @kibanamachine @kobelb @flash1293 @mshustov