Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle viewing sample dashboards on default dist #57510

Merged
merged 3 commits into from
Feb 13, 2020

Conversation

LeeDr
Copy link
Contributor

@LeeDr LeeDr commented Feb 12, 2020

Summary

Fixes: #55795

Fixes sample data oss tests so they can launch the sample Dashboards regardless of an OSS or Default Dist build (including Cloud). The difference mainly being the View button in the sample data panels in OSS opens the dashboards directly because it's the only sample item. But on the default distribution there are other items that appear in a list so we have to select Dashboard for that method to work the same.

I used isOss, but in Kibana it's really "is there more than one item". So if we add some other sample data app to OSS, we'll have to fix this differently.

Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately

@LeeDr LeeDr requested a review from a team February 12, 2020 21:32
@LeeDr LeeDr added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@LeeDr LeeDr added the release_note:skip Skip the PR/issue when compiling release notes label Feb 12, 2020
@LeeDr
Copy link
Contributor Author

LeeDr commented Feb 12, 2020

Looks like I need to change the fix a bit;

FAIL  src/legacy/core_plugins/kibana/public/home/np_ready/components/sample_data_view_data_button.test.js
  ● should render popover when appLinks is not empty

    expect(received).toMatchSnapshot()

    Snapshot name: `should render popover when appLinks is not empty 1`

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor

LGTM ...locally tested by porting the changes- works good.

@LeeDr LeeDr added the review label Feb 13, 2020
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported the changes from these changed files to mine, and my tests work. LGTM

Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App changes LGTM.

@LeeDr LeeDr merged commit 04ec353 into elastic:master Feb 13, 2020
LeeDr pushed a commit to LeeDr/kibana that referenced this pull request Feb 13, 2020
* handle viewing sample dashboards on default dist

* re-work change to not break jest test

* Update snap for addition of data-test-subj
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 13, 2020
* master: (22 commits)
  skip flaky suite (elastic#50018)
  skip settings tests (elastic#57608)
  skip failing suite (elastic#44631)
  [SIEM] [Case] Initial UI (elastic#57283)
  handle viewing sample dashboards on default dist (elastic#57510)
  Fix detection of "system requests" in plugins (elastic#57149)
  [ML] New Platform server shim: update job service schema (elastic#57614)
  skip flaky suite (elastic#44631)
  [APM] Update monospace font family variable (elastic#57555)
  skip flaky test (elastic#57377)
  Skip save query tests (elastic#57589)
  [Maps] allow simultaneous opening of multiple tooltips (elastic#57226)
  [Uptime] Fix/host connected components (elastic#56969)
  [logs][metrics][docs] Update screenshots for 7.6 (elastic#57254)
  [ML] New Platform server shim: update job service routes to use new platform router (elastic#57403)
  [Maps] Fix document source top hits split by scripted field (elastic#57481)
  Use log4j pattern syntax (elastic#57433)
  [ML] Categorization field example endpoint tests (elastic#57471)
  [Lens] Filter out pinned filters from saved object of Lens (elastic#57197)
  Lens client side shim cleanup (elastic#56976)
  ...
LeeDr pushed a commit that referenced this pull request Feb 13, 2020
* handle viewing sample dashboards on default dist

* re-work change to not break jest test

* Update snap for addition of data-test-subj
LeeDr pushed a commit that referenced this pull request Feb 14, 2020
* handle viewing sample dashboards on default dist

* re-work change to not break jest test

* Update snap for addition of data-test-subj

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@LeeDr LeeDr deleted the sampleDataTestFix branch February 14, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Home Kibana home application release_note:skip Skip the PR/issue when compiling release notes review Team:Visualizations Visualization editors, elastic-charts and infrastructure test_ui_functional v7.6.1 v7.7.0 v8.0.0
Projects
None yet
5 participants