[Lens] Adds using queries/filters for field existence endpoint #59033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Feature:Lens
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
added
the
release_note:skip
timroes
added
release_note:fix
and removed
release_note:skip
mbondyra
force-pushed
the
IS-52826_field-existence-endpoint-respects-filters
branch
from
63b80fd
to
b321b4d
Compare
mbondyra
force-pushed
the
IS-52826_field-existence-endpoint-respects-filters
branch
from
b933faf
to
f2aca43
Compare
mbondyra
changed the title
mbondyra
changed the title
wylieconlon
suggested changes
Mar 4, 2020
| @@ -113,6 +116,7 @@ async function fetchFieldExistence({ | |||
| const docs = await fetchIndexPatternStats({ | |||
| fromDate, | |||
| toDate, | |||
| dslQuery: JSON.parse(dslQuery), | |||
There was a problem hiding this comment.
Nitpick: You've chosen to keep this as a GET request, so the query is passed as a string. Would it make sense to turn this into a POST request with a query body?
| @@ -150,7 +151,7 @@ export default ({ getService }: FtrProviderContext) => { | |||
| .get( | |||
| `/api/lens/existing_fields/${encodeURIComponent( | |||
| 'logstash-*' | |||
| )}?fromDate=${TEST_START_TIME}&toDate=${TEST_END_TIME}` | |||
| )}?fromDate=${TEST_START_TIME}&toDate=${TEST_END_TIME}&dslQuery=${DSL_QUERY}` | |||
There was a problem hiding this comment.
Nitpick: dslQuery is now required, but could we provide a default match_all query? But since this is only used by our client, this is probably fine.
|
@elasticmachine merge upstream |
wylieconlon
approved these changes
Mar 11, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Mar 12, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 12, 2020
* master: (45 commits) skip flaky suite (elastic#59717) UI Metrics use findAll to retrieve all Saved Objects (elastic#59891) [Discover] Migrate Context mocha tests to use Jest (elastic#59658) [Maps] Move redux reducers and store logic to NP (elastic#58294) rebalance x-pack groups (elastic#58930) [Discover] Reimplement $route.reload when index pattern changes (elastic#59877) [Upgrade Assistant Meta] Breaking changes issue template (elastic#59745) Skip CI based on changes in PR (elastic#59939) [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic#59723) [ML] Functional tests - stabilize date_nanos test (elastic#59986) [ML] Typescripting client side endpoint functions (elastic#59928) a11y tests on adding columns to discover table (elastic#59375) fix graph plugin config path (elastic#59540) fix vega config issues (elastic#59737) [Upgrade Assistant] Open And Close Slight Refactor (elastic#59890) [ML] Adding shared services to ml setup contract (elastic#59730) [Visualize] Fix linked search behavior (elastic#59690) [ML] Register NP ML plugin for Kibana management section. (elastic#59762) [Lens] Adds using queries/filters for field existence endpoint (elastic#59033) Delete FilterStateManager and QueryFilter :-D (elastic#59872) ...
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field existence endpoint now uses queries/filters to get the list of fields that contain data.
Fixes #52826
Checklist
Delete any items that are not applicable to this PR.
For maintainers