Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y tests on adding columns to discover table #59375

Merged
merged 13 commits into from
Mar 12, 2020

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Mar 4, 2020

meta: #51456

@bhavyarm bhavyarm self-assigned this Mar 4, 2020
@bhavyarm bhavyarm requested a review from myasonik March 4, 2020 21:09
@bhavyarm bhavyarm marked this pull request as ready for review March 4, 2020 22:28
@bhavyarm bhavyarm requested a review from dmlemeshko March 4, 2020 22:28
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Mar 5, 2020

@myasonik I have this test passing in local and failing in CI. Giving it another run. Also fixed type errors.

 it('Click on new to clear the search', async () => {
      await PageObjects.discover.clickNewSearchButton();
      await a11y.testAppSnapshot();
    });

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Mar 5, 2020

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Mar 6, 2020

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Mar 6, 2020

@myasonik will wait for your input before I skip this test again:
It passes in local - fails in CI


  1) Discover
       Click on new to clear the search:
     Error: a11y report:

VIOLATION
  [aria-valid-attr-value]: Ensures all ARIA attributes have valid values
    Help: https://dequeuniversity.com/rules/axe/3.5/aria-valid-attr-value?application=axeAPI
    Elements:
      - .dscFieldList--selected
      at Accessibility.testAxeReport (test/accessibility/services/a11y/a11y.ts:85:15)
      at Accessibility.testAppSnapshot (test/accessibility/services/a11y/a11y.ts:58:18)
      at process._tickCallback (internal/process/next_tick.js:68:7)

           └- ✖ fail: "Discover Click on new to clear the search"
           │
         └-> "after all" hook
     │
     │4 passing (1.0m)
     │1 failing

@bhavyarm bhavyarm mentioned this pull request Mar 6, 2020
77 tasks
@myasonik
Copy link
Contributor

myasonik commented Mar 9, 2020

🤔 That's pretty odd that it passes locally... My only thought is that it might be because of different data used in each environment? But I thought it was the same...

Either way, this will all change with the EUIification so let's just wait till then to deal with it. Let's skip it until that's done. Maybe also make an issue and link it to #47559 and assign it to @kertal and I. We'll deal with it then.

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

@myasonik ready!!!!

Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+

@bhavyarm bhavyarm merged commit 078ff55 into elastic:master Mar 12, 2020
@bhavyarm
Copy link
Contributor Author

@kertal this is the PR with the skipped a11y tests. I am going to create an issue to track along with your pr #47559. Thank you!

@kertal
Copy link
Member

kertal commented Mar 12, 2020

thanks @bhavyarm, will make it work in #47559

bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Mar 12, 2020
bhavyarm added a commit that referenced this pull request Mar 12, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 12, 2020
* master: (45 commits)
  skip flaky suite (elastic#59717)
  UI Metrics use findAll to retrieve all Saved Objects (elastic#59891)
  [Discover] Migrate Context mocha tests to use Jest (elastic#59658)
  [Maps] Move redux reducers and store logic to NP (elastic#58294)
  rebalance x-pack groups (elastic#58930)
  [Discover] Reimplement $route.reload when index pattern changes (elastic#59877)
  [Upgrade Assistant Meta] Breaking changes issue template (elastic#59745)
  Skip CI based on changes in PR (elastic#59939)
  [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic#59723)
  [ML] Functional tests - stabilize date_nanos test (elastic#59986)
  [ML] Typescripting client side endpoint functions (elastic#59928)
  a11y tests on adding columns to discover table (elastic#59375)
  fix graph plugin config path (elastic#59540)
  fix vega config issues (elastic#59737)
  [Upgrade Assistant] Open And Close Slight Refactor (elastic#59890)
  [ML] Adding shared services to ml setup contract (elastic#59730)
  [Visualize] Fix linked search behavior (elastic#59690)
  [ML] Register NP ML plugin for Kibana management section. (elastic#59762)
  [Lens] Adds using queries/filters for field existence endpoint (elastic#59033)
  Delete FilterStateManager and QueryFilter :-D (elastic#59872)
  ...
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Mar 12, 2020
@timroes timroes added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants