[ML] Register NP ML plugin for Kibana management section. #59762
Conversation
|
@joshdover I'm working on this PR which migrates the ML section in Kibana management to use the NP services. Unfortunately I'm not able to successfully register the section+menu item, it's not showing up. Any feedback very much appreciated. |
|
@joshdover just a ping to let you know i was able to solve it! revisiting with a fresh mind helped :) |
walterra
force-pushed
the
ml-management-np
branch
from
3303de6
to
9903dd5
Compare
walterra
requested review from
darnautov,
peteharverson,
jgowdyelastic and
alvarezmelissa87
walterra
added
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
| @@ -10,22 +10,27 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
|
|
|||
| import { npSetup } from 'ui/new_platform'; | |||
| import { management } from 'ui/management'; | |||
| import { npSetup, npStart } from 'ui/new_platform'; | |||
There was a problem hiding this comment.
i don't think we should be importing anything from ui/new_platform anymore.
I wonder if this whole file needs to go and for the management section registration to happen in our root plugin.ts file? or at least get called from there
There was a problem hiding this comment.
I'm not sure this can be done as part of this PR. The only reference that ties into this code is managementSections: ['plugins/ml/application/management'] in plugins/ml/index.ts and I can't see how I'd pass on something to here. If we can think of a solution I'm happy to do it in this PR, however, the original scope here was only to migrate away from angular :). For transforms, the "cut-over" PR was not just moving files but it also included updating the plugins/transfrom/index.ts file to work again after the move, maybe we need to do it this way.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* master: (45 commits) skip flaky suite (elastic#59717) UI Metrics use findAll to retrieve all Saved Objects (elastic#59891) [Discover] Migrate Context mocha tests to use Jest (elastic#59658) [Maps] Move redux reducers and store logic to NP (elastic#58294) rebalance x-pack groups (elastic#58930) [Discover] Reimplement $route.reload when index pattern changes (elastic#59877) [Upgrade Assistant Meta] Breaking changes issue template (elastic#59745) Skip CI based on changes in PR (elastic#59939) [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic#59723) [ML] Functional tests - stabilize date_nanos test (elastic#59986) [ML] Typescripting client side endpoint functions (elastic#59928) a11y tests on adding columns to discover table (elastic#59375) fix graph plugin config path (elastic#59540) fix vega config issues (elastic#59737) [Upgrade Assistant] Open And Close Slight Refactor (elastic#59890) [ML] Adding shared services to ml setup contract (elastic#59730) [Visualize] Fix linked search behavior (elastic#59690) [ML] Register NP ML plugin for Kibana management section. (elastic#59762) [Lens] Adds using queries/filters for field existence endpoint (elastic#59033) Delete FilterStateManager and QueryFilter :-D (elastic#59872) ...
@walterra To be able to help other teams that might encounter the same issue as you did, what was the problem and how did you fix it? |
Summary
Migrates registering the ML management section using React only, deprecates the angularJS approach.
Checklist
Delete any items that are not applicable to this PR.
For maintainers