Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Error Exception Type Column #59596

Merged
merged 10 commits into from Apr 8, 2020
Merged

Add Error Exception Type Column #59596

merged 10 commits into from Apr 8, 2020

Conversation

brittanyjoiner15
Copy link
Contributor

@brittanyjoiner15 brittanyjoiner15 commented Mar 6, 2020 •
edited

Fixes #22329

Shows the user the error exception type in the column next to group ID. Text is truncated if it's too long, but on hover, it shows the title of the error. When you click the error, it filters to that exception type.

image

@brittanyjoiner15 brittanyjoiner15 self-assigned this Mar 13, 2020
@brittanyjoiner15 brittanyjoiner15 changed the title start of error exception type Add Error Exception Type Column Mar 13, 2020
@brittanyjoiner15 brittanyjoiner15 marked this pull request as ready for review March 13, 2020 19:05
@brittanyjoiner15 brittanyjoiner15 requested a review from a team as a code owner March 13, 2020 19:05
@smith
Copy link
Contributor

smith commented Mar 20, 2020

@elasticmachine merge upstream

@smith smith added v7.8.0 and removed v7.7.0 labels Mar 27, 2020
@brittanyjoiner15
Copy link
Contributor Author

@elasticmachine merge upstream

@smith
Copy link
Contributor

smith commented Apr 7, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

smith
smith approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-190810733

@smith smith merged commit 0c35762 into elastic:master Apr 8, 2020
smith added a commit to smith/kibana that referenced this pull request Apr 8, 2020
@brittanyjoiner15 @elasticmachine @smith
Add Error Exception Type Column (elastic#59596)
634f92d 
* start of error exception type

* width and link

* removed extra line

* updated snapshot

* updated snapshots

* updated snapshots

* Update snapshots

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Nathan L Smith <smith@nlsmith.com>
@smith smith mentioned this pull request Apr 8, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 9, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into es_ui_shared/…
43763b0 
…chore/put-all-xjson-together

* 'master' of github.com:elastic/kibana: (35 commits)
  [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013)
  [SIEM][Detection Engine] Fix rule notification critical bugs
  Add Error Exception Type Column (elastic#59596)
  [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282)
  [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772)
  FTR: add chromium-based Edge browser support (elastic#61684)
  [Ingest] Data source configuration validation UI (elastic#61180)
  restore empty_kibana after saved objects test (elastic#62951)
  Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594)
  Add basic StatusService (elastic#60335)
  [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720)
  [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887)
  Exclude disabled datasources and streams from agent config (elastic#62869)
  [Alerting] Fix validation support for nested IErrorObjects (elastic#62833)
  [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837)
  Add --filter option to API docs script (elastic#62888)
  [Maps] fix attribution overflow with exit full screen button (elastic#62699)
  [Uptime]Alerting UI text in case filter is selected (elastic#62570)
  [Maps] Show create filter button for top-term tooltip property (elastic#62461)
  skip flaky suite (elastic#59030)
  ...

# Conflicts:
#	src/plugins/es_ui_shared/public/index.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 9, 2020
@gmmorris
Merge branch 'master' into alerting/es-query
e9106a8 
* master: (40 commits)
  [ML] Functional transform tests - stabilize source selection (elastic#63087)
  add embed flag to saved object url as well (elastic#62926)
  [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013)
  [SIEM][Detection Engine] Fix rule notification critical bugs
  Add Error Exception Type Column (elastic#59596)
  [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282)
  [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772)
  FTR: add chromium-based Edge browser support (elastic#61684)
  [Ingest] Data source configuration validation UI (elastic#61180)
  restore empty_kibana after saved objects test (elastic#62951)
  Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594)
  Add basic StatusService (elastic#60335)
  [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720)
  [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887)
  Exclude disabled datasources and streams from agent config (elastic#62869)
  [Alerting] Fix validation support for nested IErrorObjects (elastic#62833)
  [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837)
  Add --filter option to API docs script (elastic#62888)
  [Maps] fix attribution overflow with exit full screen button (elastic#62699)
  [Uptime]Alerting UI text in case filter is selected (elastic#62570)
  ...
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 10, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 17, 2020
smith added a commit that referenced this pull request Apr 17, 2020
@smith @brittanyjoiner15 @elasticmachine
Add Error Exception Type Column (#59596) (#63072)
c123aff 
* start of error exception type

* width and link

* removed extra line

* updated snapshot

* updated snapshots

* updated snapshots

* Update snapshots

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Nathan L Smith <smith@nlsmith.com>

Co-authored-by: Brittany Joiner <brittanyjoiner15@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@rayafratkina rayafratkina added the Team:APM All issues that need APM UI Team support label Jun 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist formgeist mentioned this pull request Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

Assignees

@brittanyjoiner15 brittanyjoiner15

Labels
release_note:enhancement Team:APM All issues that need APM UI Team support v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Add error.exception.type to Errors pages
5 participants
@brittanyjoiner15 @smith @kibanamachine @elasticmachine @rayafratkina