[kbn/optimizer] link to kibanaReact/kibanaUtils plugins #62720

spalger · 2020-04-06T22:54:39Z

In order to deal with the excessive size of Kibana platform plugin bundles, caused by a number of issues (outlined in #62238), this PR updates the bootstrap logic to load the kibanaReact, and kibanaUtils plugins before the application/core bundle and rewrites all imports to plugins/{id}/public for these two plugins to reference the exports from the plugin bundles directly, without bundling their source directly into the separate plugin bundles.

We can merge this into master and backport to 7.7 to keep things consistent, but there are a few plans bouncing around that might make this unnecessary as soon as 7.8.

spalger · 2020-04-07T00:08:43Z

@elasticmachine merge upstream

elasticmachine · 2020-04-07T00:13:34Z

Pinging @elastic/kibana-operations (Team:Operations)

…k-data-plugin

tylersmalley · 2020-04-07T05:55:43Z

I am getting Definition of plugin "kibanaUtils" should be a function (/bundles/plugin/kibanaUtils/kibanaUtils.plugin.js). in IE.

mshustov · 2020-04-07T13:52:43Z

@spalger there is https://github.com/elastic/kibana/tree/f86dac77da8bcd16d12d41f27bc34220a2ac8b82/src/plugins/es_ui_shared used by several plugins. Shouldn't we add it to the current PR as it contains quite a heavy brace editor?

…k-data-plugin

spalger · 2020-04-07T16:18:22Z

@elasticmachine merge upstream

… implement/link-data-plugin

This reverts commit f14e9ee.

This reverts commit a64b2a7.

…k-data-plugin

tylersmalley

LGTM. This reduces the downloaded JS assets by 5MB. Setting async=false in the bootstrap loader results in more efficient parallelizing of download while still maintaining the execution order.

flash1293

Kibana app changes LGTM, just changing imports to public instead of common. Code review only

flash1293 · 2020-04-08T07:47:52Z

@spalger We are currently working on moving the vis_default_editor plugin and all of the individual visualizations (markdown, vislib, vega, tag cloud, ...) to the new platform. They will probably have a similar problem as kibana_utils and kibana_react, because vis_default_editor is just a static code bundle imported by a lot of other plugins. It seems possible to use the same trick there.

but there are a few plans bouncing around that might make this unnecessary as soon as 7.8

This would be even better, just mentioning it here in case it becomes relevant.

src/legacy/ui/ui_render/bootstrap/template.js.hbs

src/plugins/kibana_react/public/index.ts

src/legacy/ui/ui_render/bootstrap/template.js.hbs

…k-data-plugin # Conflicts: # src/legacy/core_plugins/kibana/public/discover/kibana_services.ts

…k-data-plugin

spalger · 2020-04-08T17:19:09Z

Skipped flaky test #59030

streamich

AppArch changes LGTM.

kibanamachine · 2020-04-08T19:12:49Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 06f5afb

History

💔 Build #39619 failed 4970b54
💚 Build #39494 succeeded 4d71565
💔 Build #39464 failed 5eed7a9
💔 Build #39378 failed 1da77f8
💔 Build #39335 failed d77a892

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [kbn/optimizer] link to data/kibanaReact/kibanaUtils plugins * depend on normalize-path package * typos * avoid loading kibanaUtils and kibanaReact from urls * update types and tests, now that whole plugin is exported to window * update snapshot, removed export of `plugins` property * fix condition, ignore things NOT in data/react/utils * make es_ui_shared a "static bundle" too * move kibana_utils/common usage to /public * convert some more /common usage to /public * use async-download/ordered-execution for bootstrap script * fix typo * remove kibanaUtils bundle * remove kibanaReact bundle * Revert "remove kibanaReact bundle" This reverts commit f14e9ee. * Revert "remove kibanaUtils bundle" This reverts commit a64b2a7. * stop linking to the data plugin * add comment pointing to async-download info Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [kbn/optimizer] link to data/kibanaReact/kibanaUtils plugins * depend on normalize-path package * typos * avoid loading kibanaUtils and kibanaReact from urls * update types and tests, now that whole plugin is exported to window * update snapshot, removed export of `plugins` property * fix condition, ignore things NOT in data/react/utils * make es_ui_shared a "static bundle" too * move kibana_utils/common usage to /public * convert some more /common usage to /public * use async-download/ordered-execution for bootstrap script * fix typo * remove kibanaUtils bundle * remove kibanaReact bundle * Revert "remove kibanaReact bundle" This reverts commit f14e9ee. * Revert "remove kibanaUtils bundle" This reverts commit a64b2a7. * stop linking to the data plugin * add comment pointing to async-download info Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/legacy/core_plugins/kibana/public/discover/kibana_services.ts # src/legacy/core_plugins/vis_type_metric/public/services.ts # src/legacy/core_plugins/vis_type_table/public/services.ts # src/legacy/core_plugins/vis_type_vislib/public/services.ts # src/legacy/core_plugins/visualizations/public/np_ready/public/legacy.ts

…chore/put-all-xjson-together * 'master' of github.com:elastic/kibana: (35 commits) [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013) [SIEM][Detection Engine] Fix rule notification critical bugs Add Error Exception Type Column (elastic#59596) [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282) [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772) FTR: add chromium-based Edge browser support (elastic#61684) [Ingest] Data source configuration validation UI (elastic#61180) restore empty_kibana after saved objects test (elastic#62951) Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594) Add basic StatusService (elastic#60335) [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720) [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887) Exclude disabled datasources and streams from agent config (elastic#62869) [Alerting] Fix validation support for nested IErrorObjects (elastic#62833) [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837) Add --filter option to API docs script (elastic#62888) [Maps] fix attribution overflow with exit full screen button (elastic#62699) [Uptime]Alerting UI text in case filter is selected (elastic#62570) [Maps] Show create filter button for top-term tooltip property (elastic#62461) skip flaky suite (elastic#59030) ... # Conflicts: # src/plugins/es_ui_shared/public/index.ts

* master: (40 commits) [ML] Functional transform tests - stabilize source selection (elastic#63087) add embed flag to saved object url as well (elastic#62926) [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013) [SIEM][Detection Engine] Fix rule notification critical bugs Add Error Exception Type Column (elastic#59596) [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282) [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772) FTR: add chromium-based Edge browser support (elastic#61684) [Ingest] Data source configuration validation UI (elastic#61180) restore empty_kibana after saved objects test (elastic#62951) Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594) Add basic StatusService (elastic#60335) [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720) [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887) Exclude disabled datasources and streams from agent config (elastic#62869) [Alerting] Fix validation support for nested IErrorObjects (elastic#62833) [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837) Add --filter option to API docs script (elastic#62888) [Maps] fix attribution overflow with exit full screen button (elastic#62699) [Uptime]Alerting UI text in case filter is selected (elastic#62570) ...

spalger added 4 commits April 6, 2020 15:47

[kbn/optimizer] link to data/kibanaReact/kibanaUtils plugins

5fed504

depend on normalize-path package

3a4d545

typos

916cc3f

avoid loading kibanaUtils and kibanaReact from urls

959650f

Merge branch 'master' into implement/link-data-plugin

aa2c3c2

spalger added v7.7.0 v7.8.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team labels Apr 7, 2020

spalger marked this pull request as ready for review April 7, 2020 00:13

spalger requested review from a team as code owners April 7, 2020 00:13

spalger added 3 commits April 6, 2020 19:53

update types and tests, now that whole plugin is exported to window

70e72eb

update snapshot, removed export of plugins property

7c9c51e

Merge branch 'master' of github.com:elastic/kibana into implement/lin…

dbac5f9

…k-data-plugin

This comment has been minimized.

Sign in to view

spalger added 5 commits April 7, 2020 07:17

fix condition, ignore things NOT in data/react/utils

0c94376

Merge branch 'master' of github.com:elastic/kibana into implement/lin…

3a3fbe7

…k-data-plugin

make es_ui_shared a "static bundle" too

08d881f

Merge branch 'master' of github.com:elastic/kibana into implement/lin…

a8bac54

…k-data-plugin

Merge branch 'master' of github.com:elastic/kibana into implement/lin…

26a99ce

…k-data-plugin

elasticmachine and others added 2 commits April 7, 2020 12:18

Merge branch 'master' into implement/link-data-plugin

d3ae538

Merge remote-tracking branch 'origin/implement/link-data-plugin' into…

d77a892

… implement/link-data-plugin

spalger added 6 commits April 7, 2020 15:20

fix typo

5eed7a9

remove kibanaUtils bundle

a64b2a7

remove kibanaReact bundle

f14e9ee

Revert "remove kibanaReact bundle"

3a2b7dc

This reverts commit f14e9ee.

Revert "remove kibanaUtils bundle"

7f3b819

This reverts commit a64b2a7.

stop linking to the data plugin

4d71565

spalger changed the title ~~[kbn/optimizer] link to data/kibanaReact/kibanaUtils plugins~~ [kbn/optimizer] link to kibanaReact/kibanaUtils plugins Apr 8, 2020

Merge branch 'master' of github.com:elastic/kibana into implement/lin…

5195a80

…k-data-plugin

tylersmalley approved these changes Apr 8, 2020

View reviewed changes

flash1293 approved these changes Apr 8, 2020

View reviewed changes

mshustov reviewed Apr 8, 2020

View reviewed changes

src/legacy/ui/ui_render/bootstrap/template.js.hbs Show resolved Hide resolved

mshustov reviewed Apr 8, 2020

View reviewed changes

src/plugins/kibana_react/public/index.ts Show resolved Hide resolved

mshustov reviewed Apr 8, 2020

View reviewed changes

src/legacy/ui/ui_render/bootstrap/template.js.hbs Show resolved Hide resolved

Merge branch 'master' of github.com:elastic/kibana into implement/lin…

2761f4d

…k-data-plugin # Conflicts: # src/legacy/core_plugins/kibana/public/discover/kibana_services.ts

mshustov approved these changes Apr 8, 2020

View reviewed changes

spalger added 2 commits April 8, 2020 08:31

add comment pointing to async-download info

4970b54

Merge branch 'master' of github.com:elastic/kibana into implement/lin…

06f5afb

…k-data-plugin

mattkime approved these changes Apr 8, 2020

View reviewed changes

streamich approved these changes Apr 8, 2020

View reviewed changes

spalger merged commit 369ddff into elastic:master Apr 8, 2020

spalger mentioned this pull request Apr 8, 2020

[7.x] [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (#62720) #63009

Merged

spalger mentioned this pull request Apr 8, 2020

[7.7] [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (#62720) #63011

Merged

spalger deleted the implement/link-data-plugin branch April 8, 2020 21:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[kbn/optimizer] link to kibanaReact/kibanaUtils plugins #62720

[kbn/optimizer] link to kibanaReact/kibanaUtils plugins #62720

spalger commented Apr 6, 2020 •

edited

spalger commented Apr 7, 2020

elasticmachine commented Apr 7, 2020

tylersmalley commented Apr 7, 2020 •

edited

This comment has been minimized.

mshustov commented Apr 7, 2020

spalger commented Apr 7, 2020

tylersmalley left a comment

flash1293 left a comment

flash1293 commented Apr 8, 2020 •

edited

spalger commented Apr 8, 2020

streamich left a comment

kibanamachine commented Apr 8, 2020

[kbn/optimizer] link to kibanaReact/kibanaUtils plugins #62720

[kbn/optimizer] link to kibanaReact/kibanaUtils plugins #62720

Conversation

spalger commented Apr 6, 2020 • edited

spalger commented Apr 7, 2020

elasticmachine commented Apr 7, 2020

tylersmalley commented Apr 7, 2020 • edited

This comment has been minimized.

mshustov commented Apr 7, 2020

spalger commented Apr 7, 2020

tylersmalley left a comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 commented Apr 8, 2020 • edited

spalger commented Apr 8, 2020

streamich left a comment

Choose a reason for hiding this comment

kibanamachine commented Apr 8, 2020

💚 Build Succeeded

History

spalger commented Apr 6, 2020 •

edited

tylersmalley commented Apr 7, 2020 •

edited

flash1293 commented Apr 8, 2020 •

edited