Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin #62594

Merged
merged 17 commits into from Apr 8, 2020

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Apr 6, 2020

Summary

Create Index Pattern Management plugin -

Moves existing legacy management API to new platform - used to for rollup index pattern functionality.

Part of #51322

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@mattkime mattkime changed the title Index pattern plugin Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin Apr 6, 2020
@mattkime mattkime changed the title Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin Apr 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@mattkime mattkime added v7.8.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Apr 7, 2020
@mattkime mattkime marked this pull request as ready for review April 7, 2020 04:14
@mattkime mattkime requested review from a team as code owners April 7, 2020 04:14
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages labels Apr 7, 2020
@mattkime mattkime added this to In progress in kibana-app-arch via automation Apr 7, 2020
@mattkime mattkime moved this from In progress to Review in progress in kibana-app-arch Apr 7, 2020
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollup client changes LGTM, only code review. Thanks for prioritizing ❤️

Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM.

@@ -4,7 +4,8 @@
"requiredPlugins": [
"home",
"index_management",
"metrics"
"metrics",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure before merge that the next PR was not merged: #62543

@elastic elastic deleted a comment from kibanamachine Apr 7, 2020
@cjcenizal cjcenizal self-requested a review April 7, 2020 18:50
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollup Jobs code LGTM. Didn't test locally.

@mattkime
Copy link
Contributor Author

mattkime commented Apr 8, 2020

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

mattkime commented Apr 8, 2020

@elasticmachine merge upstream

Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two minor leftovers, thanks!

ppisljar and others added 5 commits April 8, 2020 13:56
…nents/copy_to_space_flyout_footer.tsx

Co-Authored-By: Aleh Zasypkin <aleh.zasypkin@gmail.com>
…rize_copy_result.test.ts

Co-Authored-By: Aleh Zasypkin <aleh.zasypkin@gmail.com>
@elastic elastic deleted a comment from kibanamachine Apr 8, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit e0a5194 into elastic:master Apr 8, 2020
kibana-app-arch automation moved this from Review in progress to Done in current release Apr 8, 2020
mattkime added a commit to mattkime/kibana that referenced this pull request Apr 8, 2020
…=> new platform plugin (elastic#62594)

* implement index pattern management plugin in new platform
mattkime added a commit that referenced this pull request Apr 8, 2020
…=> new platform plugin (#62594) (#63019)

* implement index pattern management plugin in new platform
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 9, 2020
…chore/put-all-xjson-together

* 'master' of github.com:elastic/kibana: (35 commits)
  [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013)
  [SIEM][Detection Engine] Fix rule notification critical bugs
  Add Error Exception Type Column (elastic#59596)
  [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282)
  [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772)
  FTR: add chromium-based Edge browser support (elastic#61684)
  [Ingest] Data source configuration validation UI (elastic#61180)
  restore empty_kibana after saved objects test (elastic#62951)
  Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594)
  Add basic StatusService (elastic#60335)
  [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720)
  [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887)
  Exclude disabled datasources and streams from agent config (elastic#62869)
  [Alerting] Fix validation support for nested IErrorObjects (elastic#62833)
  [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837)
  Add --filter option to API docs script (elastic#62888)
  [Maps] fix attribution overflow with exit full screen button (elastic#62699)
  [Uptime]Alerting UI text in case filter is selected (elastic#62570)
  [Maps] Show create filter button for top-term tooltip property (elastic#62461)
  skip flaky suite (elastic#59030)
  ...

# Conflicts:
#	src/plugins/es_ui_shared/public/index.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 9, 2020
* master: (40 commits)
  [ML] Functional transform tests - stabilize source selection (elastic#63087)
  add embed flag to saved object url as well (elastic#62926)
  [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013)
  [SIEM][Detection Engine] Fix rule notification critical bugs
  Add Error Exception Type Column (elastic#59596)
  [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282)
  [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772)
  FTR: add chromium-based Edge browser support (elastic#61684)
  [Ingest] Data source configuration validation UI (elastic#61180)
  restore empty_kibana after saved objects test (elastic#62951)
  Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594)
  Add basic StatusService (elastic#60335)
  [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720)
  [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887)
  Exclude disabled datasources and streams from agent config (elastic#62869)
  [Alerting] Fix validation support for nested IErrorObjects (elastic#62833)
  [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837)
  Add --filter option to API docs script (elastic#62888)
  [Maps] fix attribution overflow with exit full screen button (elastic#62699)
  [Uptime]Alerting UI text in case filter is selected (elastic#62570)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
kibana-app-arch
  
Done in current release
Development

Successfully merging this pull request may close these issues.

None yet

9 participants