-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade hapi to @hapi/hapi 18.4.1 #61959
Closed
Closed
Commits on Mar 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 66f9476 - Browse repository at this point
Copy the full SHA 66f9476View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76b8801 - Browse repository at this point
Copy the full SHA 76b8801View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33e173b - Browse repository at this point
Copy the full SHA 33e173bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f84978a - Browse repository at this point
Copy the full SHA f84978aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1631da - Browse repository at this point
Copy the full SHA c1631daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b963b4 - Browse repository at this point
Copy the full SHA 7b963b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad23833 - Browse repository at this point
Copy the full SHA ad23833View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd793d7 - Browse repository at this point
Copy the full SHA bd793d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69d00cd - Browse repository at this point
Copy the full SHA 69d00cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7fc78b - Browse repository at this point
Copy the full SHA b7fc78bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69f43c9 - Browse repository at this point
Copy the full SHA 69f43c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0893449 - Browse repository at this point
Copy the full SHA 0893449View commit details -
TypeScript fix: Use correct ApplicationState interface
The `ApplicationState` interface has in the new version of `@types/hapi__hapi` been split up into: - `RequestApplicationState` - `ResponeApplicationState` - `ServerApplicationState` See PR for more info: DefinitelyTyped/DefinitelyTyped#36361 It looks like the one we want to use is `RequestApplicationState`.
Configuration menu - View commit details
-
Copy full SHA for 6f8ec28 - Browse repository at this point
Copy the full SHA 6f8ec28View commit details -
Without this change we would get the following TypeScript error: This condition will always return 'false' since the types 'AuthSettings' and 'boolean' have no overlap. According to the types, `authOptions` can either be an object, `undefined` (bot of which we already check for), or the litteral value `false`. Previously the types were a bit more loose and also allow a string since it was re-using the `RouteOptions` interface (which does allow you to specify the `auth` as a string). When reading it back from `request.route.settings.auth` it doesn't appear to be possible for the value to be a string however.
Configuration menu - View commit details
-
Copy full SHA for bf3f6a9 - Browse repository at this point
Copy the full SHA bf3f6a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fe5047 - Browse repository at this point
Copy the full SHA 1fe5047View commit details -
Configuration menu - View commit details
-
Copy full SHA for baa513b - Browse repository at this point
Copy the full SHA baa513bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a43da94 - Browse repository at this point
Copy the full SHA a43da94View commit details -
Revert "Clean up hapi server.register calls"
This reverts commit baa513b.
Configuration menu - View commit details
-
Copy full SHA for 04a6b5e - Browse repository at this point
Copy the full SHA 04a6b5eView commit details -
Revert "Upgrade from @elastic/good@@8.1.1-kibana2 to @hapi/good@8.2.4"
This reverts commit ad23833.
Configuration menu - View commit details
-
Copy full SHA for edf85ef - Browse repository at this point
Copy the full SHA edf85efView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.