Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update in-app links to metricbeat configuration docs #63295

Merged
merged 5 commits into from Apr 14, 2020
Merged

update in-app links to metricbeat configuration docs #63295

merged 5 commits into from Apr 14, 2020

Conversation

graphaelli
Copy link
Member

@graphaelli graphaelli commented Apr 10, 2020 •
edited

for apm-server, kibana, and beats

Summary

Documentation links for migration to external metricbeat monitoring were 404ing for apm-server, beats, and kibana.

image

For APM server, we should link to https://www.elastic.co/guide/en/apm/server/current/monitoring-metricbeat-collection.html but keeping this change small and we'll follow up with that cc @bmorelli25.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@graphaelli
update in-app links to metricbeat configuration docs
1eac7d3 
for apm-server, kibana, and beats
@graphaelli graphaelli added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Feature:Stack Monitoring labels Apr 10, 2020
@graphaelli graphaelli requested a review from a team April 10, 2020 21:32
@bmorelli25
Copy link
Member

Thanks for fixing these Gil. I wonder why these 404s aren't being picked up by the docs build anymore? AFAIK, links from Kibana to the documentation should be tested in the elasticsearch-ci/docs check. I think this is the code: https://github.com/elastic/docs/blob/0cee4e4715554515b2e297fe1113708ac03c9cda/build_docs.pl#L334-L399

@bmorelli25 bmorelli25 mentioned this pull request Apr 10, 2020
Closed
@graphaelli
Copy link
Member Author

Thanks for opening that follow up, I'm glad to see there is some automation around checking these.

@graphaelli
Copy link
Member Author

@elastic/stack-monitoring-ui The logstash links are incorrect as well - is https://www.elastic.co/guide/en/logstash/current/monitoring-with-metricbeat.html the right place?

@chrisronline
Copy link
Contributor

Yes, great finds @graphaelli!

@chrisronline
Copy link
Contributor

@graphaelli PR looks great so far. If you could get update that logstash link, that'd be great

@bmorelli25
Copy link
Member

These links are also broken in Kibana v7.6 and v7.5. I requested redirects (https://github.com/elastic/website-www.elastic.co/issues/5916) to fix those versions of Kibana. Will this change make it in to 7.7? Or do we need redirects there as well?

@graphaelli
Copy link
Member Author

@bmorelli25 Great call on those redirects. Let's do the same for 7.7 and target this change for 7.7.1+

@graphaelli graphaelli added v7.7.1 and removed v7.7.0 labels Apr 13, 2020
chrisronline
chrisronline approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmorelli25
Copy link
Member

Redirects are live for 7.6 and 7.5 documentation.

Opened https://github.com/elastic/website-www.elastic.co/issues/5918 to track 7.7 redirects.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@graphaelli graphaelli merged commit 5bc539c into elastic:master Apr 14, 2020
@graphaelli graphaelli deleted the fix-metricbeat-monitoring-links branch April 14, 2020 02:06
This was referenced Apr 14, 2020
Merged
Merged
graphaelli added a commit to graphaelli/kibana that referenced this pull request Apr 14, 2020
@graphaelli
update in-app links to metricbeat configuration docs (elastic#63295)
394abf5
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 14, 2020
@gmmorris
Merge branch 'master' into event-log/so-namespace
87f3dd1 
* master: (132 commits)
  document code splitting for client code (elastic#62593)
  Escape single quotes surrounded by double quotes (elastic#63229)
  [Endpoint] Update cli mapping to match endpoint package (elastic#63372)
  update in-app links to metricbeat configuration docs (elastic#63295)
  investigation notes field (documentation / metadata) (elastic#63386)
  [Maps] fix bug where toggling Scaling type does not re-fetch data (elastic#63326)
  [Alerting] set correct parameter for unauthented email action (elastic#63086)
  [Telemetry] force staging urls in tests (elastic#63356)
  Migrate legacy maps service to NP & update refs (elastic#60942)
  Fix task manager query to return tasks to retry (elastic#63360)
  [Endpoint] Policy list support for URL pagination state (elastic#63291)
  [Canvas] Migrate saved object mappings and migrations to Kibana Platform (elastic#58891)
  [DOCS] Add ILM tutorial (elastic#59502)
  [Maps] Add SOURCE_TYPES enumeration (elastic#62975)
  [Maps] update geospatial filters to use geo_shape query for geo_point fields (elastic#62966)
  Move away from npStart for embeddables in canvas (elastic#62680)
  Use MapInput type from Maps plugin (elastic#61539)
  Update to pagination for workpad and templates (elastic#62050)
  [SIEM] Fix AlertsTable id (elastic#63368)
  Consistent terminology around cypress test data (elastic#63279)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 14, 2020
@gmmorris
Merge branch 'master' into alerting/deleted-alert-error
af7f011 
* master:
  document code splitting for client code (elastic#62593)
  Escape single quotes surrounded by double quotes (elastic#63229)
  [Endpoint] Update cli mapping to match endpoint package (elastic#63372)
  update in-app links to metricbeat configuration docs (elastic#63295)
  investigation notes field (documentation / metadata) (elastic#63386)
  [Maps] fix bug where toggling Scaling type does not re-fetch data (elastic#63326)
  [Alerting] set correct parameter for unauthented email action (elastic#63086)
  [Telemetry] force staging urls in tests (elastic#63356)
  Migrate legacy maps service to NP & update refs (elastic#60942)
  Fix task manager query to return tasks to retry (elastic#63360)
  [Endpoint] Policy list support for URL pagination state (elastic#63291)
  [Canvas] Migrate saved object mappings and migrations to Kibana Platform (elastic#58891)
  [DOCS] Add ILM tutorial (elastic#59502)
  [Maps] Add SOURCE_TYPES enumeration (elastic#62975)
  [Maps] update geospatial filters to use geo_shape query for geo_point fields (elastic#62966)
  Move away from npStart for embeddables in canvas (elastic#62680)
graphaelli added a commit that referenced this pull request Apr 15, 2020
@graphaelli
update in-app links to metricbeat configuration docs (#63295) (#63433)
2f12e1d
graphaelli added a commit that referenced this pull request Apr 15, 2020
@graphaelli
update in-app links to metricbeat configuration docs (#63295) (#63434)
fe7859b
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 15, 2020
@gmmorris
Merge branch 'alerting/alert-services-mock' into alerting/es-query
75fe882 
* alerting/alert-services-mock: (107 commits)
  removed unused import
  added alert services mock and use it in siem
  [Metrics UI] Refactor With* containers to hooks (elastic#59503)
  [NP] Migrate logstash server side code to NP (elastic#63135)
  Clicking cancel in saved query save modal doesn't close it (elastic#62774)
  [Lens] Migration from 7.7 (elastic#62879)
  [Lens] Fix bug where suggestions didn't use filters (elastic#63293)
  Task/linux events (elastic#63400)
  [Remote clusters] guard against usageCollection plugin if unav… (elastic#63284)
  [Uptime] Remove pings graphql (elastic#59392)
  Index Pattern Field class - factor out copy_field code for future typescripting (elastic#63083)
  [EPM] add/remove package in package settings page (elastic#63389)
  Adjust API authorization logging (elastic#63350)
  Revert FTR: add chromium-based Edge browser support (elastic#61684) (elastic#63448)
  [Event Log] Adds namespace into save objects (elastic#62974)
  document code splitting for client code (elastic#62593)
  Escape single quotes surrounded by double quotes (elastic#63229)
  [Endpoint] Update cli mapping to match endpoint package (elastic#63372)
  update in-app links to metricbeat configuration docs (elastic#63295)
  investigation notes field (documentation / metadata) (elastic#63386)
  ...
wayneseymour pushed a commit that referenced this pull request Apr 15, 2020
@graphaelli @wayneseymour
update in-app links to metricbeat configuration docs (#63295)
77b7caa
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request Apr 15, 2020
@graphaelli @tsullivan
update in-app links to metricbeat configuration docs (elastic#63295) (e…
12e8bb0 
…lastic#63433)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisronline chrisronline chrisronline approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes v7.7.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@graphaelli @bmorelli25 @chrisronline @kibanamachine