Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] force staging urls in tests #63356

Merged
merged 3 commits into from
Apr 13, 2020

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Apr 13, 2020

It seems that these tests are already using the dev environment, but wouldnt hurt to enfoce the staging urls for telemetry for all of the tests.

Context: https://github.com/elastic/telemetry/issues/313

@Bamieh Bamieh added Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 13, 2020
@Bamieh Bamieh requested review from a team April 13, 2020 14:43
@Bamieh Bamieh marked this pull request as ready for review April 13, 2020 16:38
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack Endpoint Functional Tests.x-pack/test/functional_endpoint/apps/endpoint/host_list·ts.endpoint host list displays table data

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: endpoint
[00:00:00]           └-> "before all" hook
[00:01:23]           └-: host list
[00:01:23]             └-> "before all" hook
[00:01:23]             └-> "before all" hook
[00:01:23]               │ info [endpoint/metadata/api_feature] Loading "mappings.json"
[00:01:23]               │ info [endpoint/metadata/api_feature] Loading "data.json"
[00:01:23]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1586802612361037883] applying create index request using v1 templates []
[00:01:23]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1586802612361037883] [endpoint-agent-1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:01:23]               │ info [endpoint/metadata/api_feature] Created index "endpoint-agent-1"
[00:01:23]               │ debg [endpoint/metadata/api_feature] "endpoint-agent-1" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:01:23]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1586802612361037883] [endpoint-agent-1/UKfL6-PUTkes5GUkw9ik8A] update_mapping [_doc]
[00:01:23]               │ info [endpoint/metadata/api_feature] Indexed 9 docs into "endpoint-agent-1"
[00:01:23]               │ debg navigateToActualUrl http://localhost:6171/app/endpoint/hosts
[00:01:23]               │ debg browser[INFO] http://localhost:6171/app/endpoint/hosts?_t=1586807698710 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:23]               │
[00:01:23]               │ debg browser[INFO] http://localhost:6171/bundles/app/core/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:23]               │ debg currentUrl = http://localhost:6171/app/endpoint/hosts
[00:01:23]               │          appUrl = http://localhost:6171/app/endpoint/hosts
[00:01:23]               │ debg TestSubjects.find(kibanaChrome)
[00:01:23]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:01:27]               │ debg isGlobalLoadingIndicatorVisible
[00:01:27]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:01:27]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:01:27]               │ debg browser[INFO] http://localhost:6171/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-04-13T19:55:02Z
[00:01:27]               │        Adding connection to http://localhost:6171/elasticsearch
[00:01:27]               │
[00:01:27]               │      "
[00:01:27]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:01:27]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:01:27]             └-> finds title
[00:01:27]               └-> "before each" hook: global before each
[00:01:27]               │ debg TestSubjects.getVisibleText(hostListTitle)
[00:01:27]               │ debg TestSubjects.find(hostListTitle)
[00:01:27]               │ debg Find.findByCssSelector('[data-test-subj="hostListTitle"]') with timeout=10000
[00:01:27]               └- ✓ pass  (209ms) "endpoint host list finds title"
[00:01:27]             └-> displays table data
[00:01:27]               └-> "before each" hook: global before each
[00:01:27]               │ debg TestSubjects.exists(hostListTable)
[00:01:27]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="hostListTable"]') with timeout=2500
[00:01:27]               │ debg TestSubjects.find(hostListTable)
[00:01:27]               │ debg Find.findByCssSelector('[data-test-subj="hostListTable"]') with timeout=10000
[00:01:27]               │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/endpoint host list displays table data.png"
[00:01:28]               │ info Current URL is: http://localhost:6171/app/endpoint/hosts
[00:01:28]               │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/endpoint host list displays table data.html
[00:01:28]               └- ✖ fail: "endpoint host list displays table data"
[00:01:28]               │

Stack Trace

{ Error: expected [ [ 'Hostname',
    'Policy',
    'Policy Status',
    'Alerts',
    'Operating System',
    'IP Address',
    'Sensor Version',
    'Last Active' ],
  [ 'No items found' ] ] to sort of equal [ [ 'Hostname',
    'Policy',
    'Policy Status',
    'Alerts',
    'Operating System',
    'IP Address',
    'Sensor Version',
    'Last Active' ],
  [ 'cadmann-4.example.com',
    'Policy Name',
    'Policy Status',
    '0',
    'windows 10.0',
    '10.192.213.130, 10.70.28.129',
    'version',
    'xxxx' ],
  [ 'thurlow-9.example.com',
    'Policy Name',
    'Policy Status',
    '0',
    'windows 10.0',
    '10.46.229.234',
    'version',
    'xxxx' ],
  [ 'rezzani-7.example.com',
    'Policy Name',
    'Policy Status',
    '0',
    'windows 10.0',
    '10.101.149.26, 2606:a000:ffc0:39:11ef:37b9:3371:578c',
    'version',
    'xxxx' ] ]
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/functional_endpoint/apps/endpoint/host_list.ts:73:28)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  actual:
   '[\n  [\n    "Hostname"\n    "Policy"\n    "Policy Status"\n    "Alerts"\n    "Operating System"\n    "IP Address"\n    "Sensor Version"\n    "Last Active"\n  ]\n  [\n    "No items found"\n  ]\n]',
  expected:
   '[\n  [\n    "Hostname"\n    "Policy"\n    "Policy Status"\n    "Alerts"\n    "Operating System"\n    "IP Address"\n    "Sensor Version"\n    "Last Active"\n  ]\n  [\n    "cadmann-4.example.com"\n    "Policy Name"\n    "Policy Status"\n    "0"\n    "windows 10.0"\n    "10.192.213.130, 10.70.28.129"\n    "version"\n    "xxxx"\n  ]\n  [\n    "thurlow-9.example.com"\n    "Policy Name"\n    "Policy Status"\n    "0"\n    "windows 10.0"\n    "10.46.229.234"\n    "version"\n    "xxxx"\n  ]\n  [\n    "rezzani-7.example.com"\n    "Policy Name"\n    "Policy Status"\n    "0"\n    "windows 10.0"\n    "10.101.149.26, 2606:a000:ffc0:39:11ef:37b9:3371:578c"\n    "version"\n    "xxxx"\n  ]\n]',
  showDiff: true }

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh Bamieh merged commit 5bc233f into elastic:master Apr 13, 2020
@Bamieh Bamieh deleted the telemetry/force_staging_urls_in_tests branch April 13, 2020 20:45
Bamieh added a commit that referenced this pull request Apr 13, 2020
* specify telemetry url configs

* opt out by default except where we are testing telemetry
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 14, 2020
* master: (132 commits)
  document code splitting for client code (elastic#62593)
  Escape single quotes surrounded by double quotes (elastic#63229)
  [Endpoint] Update cli mapping to match endpoint package (elastic#63372)
  update in-app links to metricbeat configuration docs (elastic#63295)
  investigation notes field (documentation / metadata) (elastic#63386)
  [Maps] fix bug where toggling Scaling type does not re-fetch data (elastic#63326)
  [Alerting] set correct parameter for unauthented email action (elastic#63086)
  [Telemetry] force staging urls in tests (elastic#63356)
  Migrate legacy maps service to NP & update refs (elastic#60942)
  Fix task manager query to return tasks to retry (elastic#63360)
  [Endpoint] Policy list support for URL pagination state (elastic#63291)
  [Canvas] Migrate saved object mappings and migrations to Kibana Platform (elastic#58891)
  [DOCS] Add ILM tutorial (elastic#59502)
  [Maps] Add SOURCE_TYPES enumeration (elastic#62975)
  [Maps] update geospatial filters to use geo_shape query for geo_point fields (elastic#62966)
  Move away from npStart for embeddables in canvas (elastic#62680)
  Use MapInput type from Maps plugin (elastic#61539)
  Update to pagination for workpad and templates (elastic#62050)
  [SIEM] Fix AlertsTable id (elastic#63368)
  Consistent terminology around cypress test data (elastic#63279)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 14, 2020
* master:
  document code splitting for client code (elastic#62593)
  Escape single quotes surrounded by double quotes (elastic#63229)
  [Endpoint] Update cli mapping to match endpoint package (elastic#63372)
  update in-app links to metricbeat configuration docs (elastic#63295)
  investigation notes field (documentation / metadata) (elastic#63386)
  [Maps] fix bug where toggling Scaling type does not re-fetch data (elastic#63326)
  [Alerting] set correct parameter for unauthented email action (elastic#63086)
  [Telemetry] force staging urls in tests (elastic#63356)
  Migrate legacy maps service to NP & update refs (elastic#60942)
  Fix task manager query to return tasks to retry (elastic#63360)
  [Endpoint] Policy list support for URL pagination state (elastic#63291)
  [Canvas] Migrate saved object mappings and migrations to Kibana Platform (elastic#58891)
  [DOCS] Add ILM tutorial (elastic#59502)
  [Maps] Add SOURCE_TYPES enumeration (elastic#62975)
  [Maps] update geospatial filters to use geo_shape query for geo_point fields (elastic#62966)
  Move away from npStart for embeddables in canvas (elastic#62680)
wayneseymour pushed a commit that referenced this pull request Apr 15, 2020
* specify telemetry url configs

* opt out by default except where we are testing telemetry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants