Fix task manager query to return tasks to retry #63360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
mikecote
commented
Apr 13, 2020
| @@ -54,15 +54,16 @@ export const IdleTaskWithExpiredRunAt: MustCondition<TermFilter | RangeFilter> = | |||
| }, | |||
| }; | |||
|
|
|||
| export const InactiveTasks: MustNotCondition<TermFilter | RangeFilter> = { | |||
| // TODO: Fix query clauses to support this | |||
| export const InactiveTasks: BoolClauseWithAnyCondition<any> = { | |||
There was a problem hiding this comment.
I did not manage to get query clause TS types working within a timebox, deferring to later.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Apr 13, 2020
* Fix task manager query to also return tasks to retry * Fix failing jest tests
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Apr 13, 2020
* Fix task manager query to also return tasks to retry * Fix failing jest tests
mikecote
added a commit
that referenced
this pull request
Apr 13, 2020
mikecote
added a commit
that referenced
this pull request
Apr 13, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 14, 2020
* master: (132 commits) document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) [Maps] fix bug where toggling Scaling type does not re-fetch data (elastic#63326) [Alerting] set correct parameter for unauthented email action (elastic#63086) [Telemetry] force staging urls in tests (elastic#63356) Migrate legacy maps service to NP & update refs (elastic#60942) Fix task manager query to return tasks to retry (elastic#63360) [Endpoint] Policy list support for URL pagination state (elastic#63291) [Canvas] Migrate saved object mappings and migrations to Kibana Platform (elastic#58891) [DOCS] Add ILM tutorial (elastic#59502) [Maps] Add SOURCE_TYPES enumeration (elastic#62975) [Maps] update geospatial filters to use geo_shape query for geo_point fields (elastic#62966) Move away from npStart for embeddables in canvas (elastic#62680) Use MapInput type from Maps plugin (elastic#61539) Update to pagination for workpad and templates (elastic#62050) [SIEM] Fix AlertsTable id (elastic#63368) Consistent terminology around cypress test data (elastic#63279) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 14, 2020
* master: document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) [Maps] fix bug where toggling Scaling type does not re-fetch data (elastic#63326) [Alerting] set correct parameter for unauthented email action (elastic#63086) [Telemetry] force staging urls in tests (elastic#63356) Migrate legacy maps service to NP & update refs (elastic#60942) Fix task manager query to return tasks to retry (elastic#63360) [Endpoint] Policy list support for URL pagination state (elastic#63291) [Canvas] Migrate saved object mappings and migrations to Kibana Platform (elastic#58891) [DOCS] Add ILM tutorial (elastic#59502) [Maps] Add SOURCE_TYPES enumeration (elastic#62975) [Maps] update geospatial filters to use geo_shape query for geo_point fields (elastic#62966) Move away from npStart for embeddables in canvas (elastic#62680)
gmmorris
reviewed
Apr 14, 2020
There was a problem hiding this comment.
Given this a look over too and looks right.
I wish we could add a FT around this, but looking at the implementation it's actually quite hard because you can't have an FT run for over 5 minutes to get to the retry.
We might have to manually create a task who's retryAt is in the past through some hacky means 🤔
I'll give it some thought.
mikecote
moved this from In Progress
to Done (Ordered by most recent)
in Make it Action
wayneseymour
pushed a commit
that referenced
this pull request
Apr 15, 2020
* Fix task manager query to also return tasks to retry * Fix failing jest tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes task manager's
InactiveTasksquery to AND the filters in themust_notinstead of OR which caused tasks with statusrunningorclaimingto never return.Steps to reproduce issue:
retryAtretryAtwindow to pass