Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM][CASE] Create comments sequentially #63692

Merged
merged 1 commit into from
Apr 16, 2020
Merged

[SIEM][CASE] Create comments sequentially #63692

merged 1 commit into from
Apr 16, 2020

Conversation

cnasikas
Copy link
Member

Summary

Maintain the order of comments when pushing to ServiceNow. Ref: https://github.com/elastic/siem-team/issues/618

For maintainers

@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 labels Apr 16, 2020
@cnasikas cnasikas requested a review from XavierM April 16, 2020 12:08
@cnasikas cnasikas requested review from a team as code owners April 16, 2020 12:08
@cnasikas cnasikas self-assigned this Apr 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

mikecote
mikecote approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stephmilovic
stephmilovic approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review + manually tested. LGTM 🚀

@cnasikas cnasikas merged commit 10ccc0a into elastic:master Apr 16, 2020
@cnasikas cnasikas deleted the fix_comment_order branch April 16, 2020 18:26
@cnasikas cnasikas mentioned this pull request Apr 16, 2020
Merged
cnasikas added a commit to cnasikas/kibana that referenced this pull request Apr 16, 2020
@cnasikas
[SIEM][CASE] Create comments sequentially (elastic#63692)
bc871c2
@cnasikas cnasikas mentioned this pull request Apr 16, 2020
Merged
cnasikas added a commit to cnasikas/kibana that referenced this pull request Apr 16, 2020
@cnasikas
[SIEM][CASE] Create comments sequentially (elastic#63692)
0134596
cnasikas added a commit that referenced this pull request Apr 17, 2020
@cnasikas
[7.7] [SIEM][CASE] Create comments sequentially (#63692) (#63744)
dc44d25
cnasikas added a commit that referenced this pull request Apr 17, 2020
@cnasikas
[7.x] [SIEM][CASE] Create comments sequentially (#63692) (#63743)
5f3595b
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 17, 2020
@gmmorris
Merge branch 'master' into alerting/es-query
34e0612 
* master: (40 commits)
  [APM]Upgrade apm-rum agent to latest version to fix full page reload (elastic#63723)
  add deprecation warning for legacy 3rd party plugins (elastic#62401)
  Migrate timelion vis (elastic#62819)
  Replacebad scope link with actual values (elastic#63444)
  Index pattern management UI -> TypeScript and New Platform Ready (create_index_pattern_wizard) (elastic#63111)
  [SIEM] Threat hunting enhancements: Filter for/out value, Show top field, Copy to Clipboard, Draggable chart legends (elastic#61207)
  [Maps] fix term join agg key collision (elastic#63324)
  [Ingest] Fix agent config key sorting (elastic#63488)
  [Monitoring] Fixed server response errors (elastic#63181)
  update elastic charts to 18.3.0 (elastic#63732)
  Start services (elastic#63720)
  [APM] Encode spaces when creating ML job (elastic#63683)
  Uptime 7.7 docs (elastic#62228)
  [DOCS] Updates remote cluster and ccr docs (elastic#63517)
  [Maps] Add 3rd party vector tile support (elastic#62084)
  [Endpoint][EPM] Retrieve Index Pattern from Ingest Manager (elastic#63016)
  [Endpoint] Host Details Policy Response Panel (elastic#63518)
  [Uptime] Certificate expiration threshold settings (elastic#63682)
  Refactor saved object types to use `namespaceType` (elastic#63217)
  [SIEM][CASE] Create comments sequentially (elastic#63692)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@XavierM XavierM Awaiting requested review from XavierM

Assignees

@cnasikas cnasikas

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cnasikas @elasticmachine @kibanamachine @mikecote @stephmilovic @MindyRS