Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uptime 7.7 docs #62228

Merged
merged 14 commits into from
Apr 16, 2020
Merged

Uptime 7.7 docs #62228

merged 14 commits into from
Apr 16, 2020

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Apr 1, 2020

Summary

Docs for the 7.7 Uptime release

Checklist

@andrewvc andrewvc added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 labels Apr 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@andrewvc andrewvc added in progress release_note:skip Skip the PR/issue when compiling release notes labels Apr 1, 2020
@bmorelli25
Copy link
Member

bmorelli25 commented Apr 1, 2020 •
edited
Loading

@andrewvc Please feel free to add me as a reviewer when this is ready.

And in the meantime, let me know if I can help!

@andrewvc andrewvc requested a review from bmorelli25 April 1, 2020 22:57
bmorelli25
bmorelli25 reviewed Apr 2, 2020
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub is too flaky for me to continue this right now. Here's my first round of thoughts. Let me know if I'm way off-base with the security comments. Also, hopefully these link fixes will fix the build preview so we can see what this looks like built.

docs/uptime-guide/security.asciidoc Outdated Show resolved Hide resolved
docs/uptime-guide/security.asciidoc Outdated Show resolved Hide resolved
docs/uptime-guide/security.asciidoc Outdated Show resolved Hide resolved
docs/uptime-guide/security.asciidoc Outdated Show resolved Hide resolved
docs/uptime/settings.asciidoc Outdated Show resolved Hide resolved
@andrewvc
Copy link
Contributor Author

@elasticmachine merge upstream

@andrewvc andrewvc self-assigned this Apr 13, 2020
@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

1 similar comment
@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member 

12:10:38 INFO:build_docs:Bad cross-document links:
12:10:38 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/kibana/master/uptime-security.html:
12:10:38 INFO:build_docs:   - en/uptime/master/uptime-security.html

bmorelli25
bmorelli25 reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I'm liking this much better. A few comments

docs/uptime/overview.asciidoc Outdated Show resolved Hide resolved
docs/uptime/overview.asciidoc Outdated Show resolved Hide resolved
docs/uptime/settings.asciidoc Outdated Show resolved Hide resolved
docs/uptime/settings.asciidoc Outdated Show resolved Hide resolved
docs/uptime/settings.asciidoc Outdated Show resolved Hide resolved
docs/uptime/settings.asciidoc Outdated
Comment on lines 14 to 20
As an example, imagine your organization one team for internal IT services, and another
for public services. Each team operates independently and is only responsible for their
own services. In this scenario you might setup separate Heartbeat instances for each team,
writing out to index patterns named `it-heartbeat-\*`, and `external-heartbeat-\*`. You would
create separate roles and users for each in Elasticsearch, each with access to their own spaces,
named `it` and `external` respectively. Within each space you would navigate to the settings page
and set the correct index pattern to match only the indices that space is allowed to access.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example was a bit tough for me to read and comprehend. Here's an alternative that I came up with, but I'm not sure I like it any better:

As an example, imagine your organization has one team for internal IT services, and another for public services. Each team operates independently and is only responsible for its own services. In this scenario, you might set up separate Heartbeat instances for each team, writing to different index patterns, named it-heartbeat-*, and external-heartbeat-*. In Elasticsearch, you'd create separate roles and users, named it and external, each exclusively with access to their own spaces. Finally, within each space, you would navigate to the settings page and set an index pattern only to match the indices that the space is allowed to access.

Maybe @dedemorton can take a look. She's pretty good at word herding.

andrewvc and others added 2 commits April 13, 2020 19:56
@andrewvc @bmorelli25
Apply suggestions from code review
d66bd3d 
Co-Authored-By: Brandon Morelli <bmorelli25@gmail.com>
@andrewvc
Incorporate PR feedback
9ce7239
@andrewvc andrewvc merged commit 6652045 into elastic:master Apr 16, 2020
@andrewvc andrewvc deleted the 77docs branch April 16, 2020 20:39
@andrewvc andrewvc mentioned this pull request Apr 16, 2020
Merged
andrewvc added a commit to andrewvc/kibana that referenced this pull request Apr 16, 2020
@andrewvc
Uptime 7.7 docs (elastic#62228)
8fd33e6 
Add docs for 7.7 features:

- Alerting
- Duration anomalies
- Settings

Point security docs to heartbeat.
@andrewvc andrewvc mentioned this pull request Apr 16, 2020
Merged
andrewvc added a commit to andrewvc/kibana that referenced this pull request Apr 16, 2020
@andrewvc
Uptime 7.7 docs (elastic#62228)
24198a9 
Add docs for 7.7 features:

- Alerting
- Duration anomalies
- Settings

Point security docs to heartbeat.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 17, 2020
@gmmorris
Merge branch 'master' into alerting/es-query
34e0612 
* master: (40 commits)
  [APM]Upgrade apm-rum agent to latest version to fix full page reload (elastic#63723)
  add deprecation warning for legacy 3rd party plugins (elastic#62401)
  Migrate timelion vis (elastic#62819)
  Replacebad scope link with actual values (elastic#63444)
  Index pattern management UI -> TypeScript and New Platform Ready (create_index_pattern_wizard) (elastic#63111)
  [SIEM] Threat hunting enhancements: Filter for/out value, Show top field, Copy to Clipboard, Draggable chart legends (elastic#61207)
  [Maps] fix term join agg key collision (elastic#63324)
  [Ingest] Fix agent config key sorting (elastic#63488)
  [Monitoring] Fixed server response errors (elastic#63181)
  update elastic charts to 18.3.0 (elastic#63732)
  Start services (elastic#63720)
  [APM] Encode spaces when creating ML job (elastic#63683)
  Uptime 7.7 docs (elastic#62228)
  [DOCS] Updates remote cluster and ccr docs (elastic#63517)
  [Maps] Add 3rd party vector tile support (elastic#62084)
  [Endpoint][EPM] Retrieve Index Pattern from Ingest Manager (elastic#63016)
  [Endpoint] Host Details Policy Response Panel (elastic#63518)
  [Uptime] Certificate expiration threshold settings (elastic#63682)
  Refactor saved object types to use `namespaceType` (elastic#63217)
  [SIEM][CASE] Create comments sequentially (elastic#63692)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 20, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

andrewvc added a commit that referenced this pull request Apr 21, 2020
@andrewvc
Uptime 7.7 docs (#62228) (#63771)
2a6be8f 
Add docs for 7.7 features:

- Alerting
- Duration anomalies
- Settings

Point security docs to heartbeat.
andrewvc added a commit that referenced this pull request Apr 21, 2020
@andrewvc
Uptime 7.7 docs (#62228) (#63770)
e4fa2ce 
Add docs for 7.7 features:

- Alerting
- Duration anomalies
- Settings

Point security docs to heartbeat.
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees

@andrewvc andrewvc

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewvc @elasticmachine @bmorelli25 @kibanamachine