[Maps] Map settings: min and max zoom #63714

nreese · 2020-04-16T14:35:01Z

This PR lays the foundation for Map properties as described in #62769. This PR implements min and max zoom map properties.

elasticmachine · 2020-04-16T14:40:16Z

Pinging @elastic/kibana-gis (Team:Geo)

nreese · 2020-04-16T14:41:29Z

@elastic/kibana-design

The open button is currently a gear icon in the Legend. This is just a place holder until a better location can be found. Please advise.

cchaos · 2020-04-16T15:09:01Z

Since this isn't something that should be manipulated in the view/embedded state, I'd assume put the options in the top menu. If there's only a few, you can keep them in a popover. If there will be a long list, use a normal Flyout. Not one that pushes the maps like the edit layer.

nreese · 2020-04-16T15:42:45Z

Since this isn't something that should be manipulated in the view/embedded state, I'd assume put the options in the top menu.

If could be in the embedded state in the future. There is talk of making Dashboard the home for everything and we want all edit UIs to be part of embeddable.

If there's only a few, you can keep them in a popover.

The list will get rather large as all properties are implemented. Why would you use a

If there will be a long list, use a normal Flyout. Not one that pushes the maps like the edit layer.

Why would you not use the same flyout as the edit layer? Users will still want to see the entire map to understand how the settings effect the map.

cchaos · 2020-04-16T16:03:46Z

If could be in the embedded state in the future. There is talk of making Dashboard the home for everything and we want all edit UIs to be part of embeddable.

Then it would be handled like as part of the dashboard panel and not internal to the embedded display via the panel options menu (and then only available in edit mode).

If there will be a long list, use a normal Flyout. Not one that pushes the maps like the edit layer.

This is the same way we handle the settings for Graph, Dev tools, etc... If it is whole object-wide settings, it is a menu item. Using a regular flyout actually allows them to focus on the changes that effect the map and ignore the layers panel.

nreese · 2020-04-20T17:20:58Z

@elasticmachine merge upstream

elasticmachine · 2020-04-20T17:21:00Z

merge conflict between base and head

nreese · 2020-04-20T19:22:26Z

@cchaos I have moved the action button open the menu to the top level chrome. I would still like to use the flyout that pushes the map over for 2 reasons

consistency in the UI for the flyout panel.
To avoid covering the map legend. Settings will effect layers and those effects will be surfaced in the map legend. Users need to see those effects while setting values.

thomasneirynck

Will be nice UI to collect map-properties!

I think with these new zoom restriction, it will help if we make the parts related to zoom in the UX more consistent:

Is is possible to make the zoom-readout behave accordingly with the slider when the map snaps lower or higher?

It really only updates on move-changes, so when the map snaps to a lower/higher zoom, this is not being indicated on the map. (? The moveend event here might not be the one we want:

kibana/x-pack/plugins/maps/public/connected_components/map/mb/view.js

Line 197 in ad04aa1

this.props.extentChanged(this._getMapState());

)

Possible to validate the zoom-input to the allowed range?

(less sure about this one, maybe more of a nice2have). Since we have the immediate visual feedback with the zoom-snapping and then also the rollback behavior, if users cancel out the zoom-range settings, shouldn't the map snap back to the old setting (similar to e.g. color changes)? (this will prevent users from playing around and losing their position)

x-pack/plugins/maps/public/connected_components/map/mb/view.js

x-pack/legacy/plugins/maps/public/angular/map_controller.js

kibanamachine · 2020-04-21T21:34:42Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5ee2da9

History

💚 Build #42209 succeeded f8549bf
💚 Build #41985 succeeded 71e7d7a
💔 Build #41306 failed c6399e4
💔 Build #41290 failed 982ec5e
💔 Build #41264 failed 2d3682f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck

thx!

thomasneirynck · 2020-04-21T22:00:01Z

x-pack/legacy/plugins/maps/public/angular/map_controller.js

@@ -591,6 +608,22 @@ app.controller(
          getInspector().open(inspectorAdapters, {});
        },
      },
+      {
+        id: 'mapSettings',
+        label: i18n.translate('xpack.maps.mapController.openSettingsButtonLabel', {


good call moving this to left of save

* [Maps] Map settings: min and max zoom * eslint * header and footer * zoom range UI * save session state in mapStateJSON * disable button when flyout is open * tslint * update layer_control jest test * tslint * move settings button to top map chrome * move map_settings_panel to NP * remove merge conflict artifact * fix import for NP migration * remove unused CSS class * fix path from NP move * review feedback * load map settings in embeddable

* master: (29 commits) [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611) refactor action filter creation utils (elastic#62969) Refresh index pattern list before redirecting (elastic#63329) [APM]fixing custom link unit tests (elastic#64045) [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103) [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033) [Maps] Map settings: min and max zoom (elastic#63714) [kbn-storybook] Use raw loader for text files (elastic#64108) [EPM] /packages/{package} endpoint to support upgrades (elastic#63629) [SIEM] New Platform Saved Objects Registration (elastic#64029) [Endpoint] Hook to handle events needing navigation via Router (elastic#63863) Fixed small issue in clone functionality (elastic#64085) [Endpoint]EMT-146: use ingest agent for status info (elastic#63921) [SIEM] Server NP Followup (elastic#64010) Register uiSettings on New Platform (elastic#64015) [Reporting] Integration polling config with client code (elastic#63754) [Docs]7.7 SIEM doc updates (elastic#63951) [SIEM] [Cases] Tags suggestions (elastic#63878) Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027) [DOCS] Add file size setting for Data Visualizer (elastic#64006) ...

* [Maps] Map settings: min and max zoom * eslint * header and footer * zoom range UI * save session state in mapStateJSON * disable button when flyout is open * tslint * update layer_control jest test * tslint * move settings button to top map chrome * move map_settings_panel to NP * remove merge conflict artifact * fix import for NP migration * remove unused CSS class * fix path from NP move * review feedback * load map settings in embeddable

…ana into task-manager/cancel-logging * 'task-manager/cancel-logging' of github.com:gmmorris/kibana: (28 commits) [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611) refactor action filter creation utils (elastic#62969) Refresh index pattern list before redirecting (elastic#63329) [APM]fixing custom link unit tests (elastic#64045) [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103) [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033) [Maps] Map settings: min and max zoom (elastic#63714) [kbn-storybook] Use raw loader for text files (elastic#64108) [EPM] /packages/{package} endpoint to support upgrades (elastic#63629) [SIEM] New Platform Saved Objects Registration (elastic#64029) [Endpoint] Hook to handle events needing navigation via Router (elastic#63863) Fixed small issue in clone functionality (elastic#64085) [Endpoint]EMT-146: use ingest agent for status info (elastic#63921) [SIEM] Server NP Followup (elastic#64010) Register uiSettings on New Platform (elastic#64015) [Reporting] Integration polling config with client code (elastic#63754) [Docs]7.7 SIEM doc updates (elastic#63951) [SIEM] [Cases] Tags suggestions (elastic#63878) Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027) [DOCS] Add file size setting for Data Visualizer (elastic#64006) ...

nreese added 7 commits April 15, 2020 12:34

[Maps] Map settings: min and max zoom

a23e1e3

eslint

f1a4ba0

header and footer

f455586

zoom range UI

29a33a9

save session state in mapStateJSON

5eaeee0

Merge branch 'master' of github.com:elastic/kibana into map_settings

6b11fee

disable button when flyout is open

2d3682f

nreese requested review from a team as code owners April 16, 2020 14:35

nreese requested review from jsanz and thomasneirynck April 16, 2020 14:39

nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.8.0 v8.0.0 labels Apr 16, 2020

tslint

982ec5e

nreese changed the title ~~Map settings~~ [Maps] Map settings: min and max zoom Apr 16, 2020

update layer_control jest test

c6399e4

nreese added 3 commits April 20, 2020 11:24

merge with master

3cc6b0f

tslint

1abe6b9

move settings button to top map chrome

71e7d7a

merge with master

ad04aa1

nreese added 5 commits April 21, 2020 08:30

move map_settings_panel to NP

f945d6a

remove merge conflict artifact

07df6d6

fix import for NP migration

870d69e

remove unused CSS class

c43bee0

fix path from NP move

cd47a8b

cchaos requested a review from miukimiu April 21, 2020 14:38

thomasneirynck reviewed Apr 21, 2020

View reviewed changes

x-pack/plugins/maps/public/connected_components/map/mb/view.js Outdated Show resolved Hide resolved

x-pack/legacy/plugins/maps/public/angular/map_controller.js Outdated Show resolved Hide resolved

review feedback

f8549bf

nreese requested a review from thomasneirynck April 21, 2020 16:33

load map settings in embeddable

5ee2da9

thomasneirynck approved these changes Apr 21, 2020

View reviewed changes

nreese merged commit ea4eb33 into elastic:master Apr 21, 2020

nreese mentioned this pull request Apr 21, 2020

[7.x] [Maps] Map settings: min and max zoom (#63714) #64129

Merged

jsanz mentioned this pull request Apr 23, 2020

[Maps] Map properties #62769

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] Map settings: min and max zoom #63714

[Maps] Map settings: min and max zoom #63714

nreese commented Apr 16, 2020 •

edited

Loading

elasticmachine commented Apr 16, 2020

nreese commented Apr 16, 2020

cchaos commented Apr 16, 2020

nreese commented Apr 16, 2020

cchaos commented Apr 16, 2020

nreese commented Apr 20, 2020

elasticmachine commented Apr 20, 2020

nreese commented Apr 20, 2020 •

edited

Loading

thomasneirynck left a comment

kibanamachine commented Apr 21, 2020

thomasneirynck left a comment

thomasneirynck Apr 21, 2020

[Maps] Map settings: min and max zoom #63714

[Maps] Map settings: min and max zoom #63714

Conversation

nreese commented Apr 16, 2020 • edited Loading

elasticmachine commented Apr 16, 2020

nreese commented Apr 16, 2020

cchaos commented Apr 16, 2020

nreese commented Apr 16, 2020

cchaos commented Apr 16, 2020

nreese commented Apr 20, 2020

elasticmachine commented Apr 20, 2020

nreese commented Apr 20, 2020 • edited Loading

thomasneirynck left a comment

Choose a reason for hiding this comment

kibanamachine commented Apr 21, 2020

💚 Build Succeeded

History

thomasneirynck left a comment

Choose a reason for hiding this comment

thomasneirynck Apr 21, 2020

Choose a reason for hiding this comment

nreese commented Apr 16, 2020 •

edited

Loading

nreese commented Apr 20, 2020 •

edited

Loading