[SIEM] [Cases] External service selection per case #64775

stephmilovic · 2020-04-29T13:59:36Z

Summary

External service selection in the case view (multiple connector support)

The case begins with the default external service connected. The user can now change the service from the case page on a per case basis:

The can also remove the option for the case to have a connector entirely:

Here is 40 seconds of Case interaction, changing external services and pushing to each. Notice the "requires updates" are accurate with push data:

Also adjusted/added columns in the all_cases table

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

XavierM · 2020-05-04T09:36:01Z

x-pack/plugins/case/server/routes/api/cases/find_cases.test.ts

+    expect(response.status).toEqual(200);
+    expect(response.payload.cases[0].connector_id).toEqual('none');
+  });
+  it(`adds default connector id to cases without when 3rd party configured`, async () => {


nit -> we can get one more test to ~~male~~ make sure we get the connector_id if there is one.

I think I will apply to all the tests that applied if you agree

I think the test should female sure we get the connector_id because the future is female

x-pack/plugins/case/server/routes/api/cases/post_case.ts

cnasikas · 2020-05-04T09:54:22Z

x-pack/plugins/case/common/api/cases/user_actions.ts

@@ -14,6 +14,7 @@ import { UserRT } from '../user';
 const UserActionFieldRt = rt.array(
  rt.union([
    rt.literal('comment'),
+    rt.literal('connector_id'),


nit -> I think is better to describe the action as connector.

but we are really updating the connector_id field

i'd like to leave it. its updating the field connector_id, there is no field connector

Ok! I am not against it. For the sake of argument this is a verb that describes an action, not a field. So the user creates a comment, updates the description, updates the connector etc.

lol, maybe I did not do that correctly but the goal here was to be a field ;)

x-pack/plugins/siem/public/pages/case/components/all_cases/index.tsx

x-pack/plugins/siem/public/pages/case/components/use_push_to_service/index.tsx

x-pack/plugins/siem/public/pages/case/components/all_cases/columns.tsx

x-pack/plugins/siem/public/pages/case/components/edit_connector/index.tsx

kibanamachine · 2020-05-05T01:34:48Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b6a1641

History

💔 Build #45288 failed e175cb6
💔 Build #45238 failed e224b59
💔 Build #45206 failed bf31cf3
💔 Build #45185 failed 5d2d2bc
💔 Build #45169 failed 3a954a1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cnasikas

LGTM!! Excellent work. Can't wait to see how our PRs will work together :)

* master: (133 commits) Cleanup Typescript index pattern field editor / Expression functions for bucket agg (elastic#65254) Removes legacy infra plugin and moves saved objects registration to NP (elastic#64848) Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog (elastic#64986) [SIEM] Removes prebuilt rules number dependency (elastic#65128) [Maps] add categorical palettes with 20 and 30 categories (elastic#64701) [CI] Slack alerts - Elasticsearch snapshot failures (elastic#64724) [Uptime] Console errors in case index missing (elastic#65115) [SIEM][CASE] Dynamic fields mapping based on connector (elastic#64412) [test/functional] Tsfy page objects (elastic#64887) [Maps] [Telemetry] Track geo_point and geo_shape index patterns separately (elastic#65195) [Maps] Add global fit to data (elastic#64702) Visualize: Reload on ui state change and fix ui state for tsvb (elastic#63699) [SIEM] [Cases] External service selection per case (elastic#64775) [Uptime] Set ML anomaly look-back to 2w (from 24h) / Add spinner (elastic#65055) [Metrics UI] Remove APM Hard Dependency (elastic#64952) [Ingest] Datastream list: add icons and dashboard links (elastic#65048) disable plugins. they could access ES via SO repository (elastic#65242) Feature fleet enrollment instructions (elastic#65176) [SIEM] Adds 'Configure connector' Cypress test (elastic#64807) [TSVB] Fix std deviation band mode (elastic#64413) ...

elasticmachine · 2021-09-23T14:35:24Z

Pinging @elastic/security-solution (Team: SecuritySolution)

stephmilovic added 30 commits April 15, 2020 07:13

wip

74534fa

logs

ab037ff

Merge branch 'master' into connector-selection-case

f803e30

Merge branch 'master' into connector-selection-case

6cc292c

add connector selector to case view

f34c722

connected to current selector

7fd93b2

refactor configure cases

ba3976c

?

8823b2d

fixingish

7352699

fixed

85414df

more cleanup

9fcdc45

more cleanup

ea7390f

more cleanup

1ff3926

merged in configure refactor

c6355d3

reset configure_cases/index to match with PR

c8b6ff8

add connector id to case data

7747c54

more work for connectorId

8e092ec

fixed connectorId

f6ba967

fix unsaved changes bug

b523948

Merge branch 'use-configure-refactor' into connector-selection-case

03aca05

button and dropdown now connected to case.connectorId

7f4fe94

button/dropdown conenected

b0ed184

merge master

0870ec4

cleanup

18e1503

user action enabled for connector_id

09c7cbf

this commit is late

6099f46

by golly it works

366b3ad

tf no ver

9c30d90

big master merge

7607a8e

decision time

fc0183e

stephmilovic changed the title ~~[SIEM] [Cases] [skip-ci] External service selection per case~~ [SIEM] [Cases] External service selection per case Apr 30, 2020

stephmilovic marked this pull request as ready for review April 30, 2020 21:39

stephmilovic requested review from a team as code owners April 30, 2020 21:39

stephmilovic added 2 commits April 30, 2020 15:44

merge in master

17e9f13

test fix

29230bb

XavierM reviewed May 4, 2020

View reviewed changes

x-pack/plugins/case/server/routes/api/cases/post_case.ts Outdated Show resolved Hide resolved

cnasikas reviewed May 4, 2020

View reviewed changes

XavierM reviewed May 4, 2020

View reviewed changes

x-pack/plugins/siem/public/pages/case/components/all_cases/index.tsx Outdated Show resolved Hide resolved

XavierM reviewed May 4, 2020

View reviewed changes

x-pack/plugins/siem/public/pages/case/components/use_push_to_service/index.tsx Outdated Show resolved Hide resolved

cnasikas reviewed May 4, 2020

View reviewed changes

x-pack/plugins/siem/public/pages/case/components/all_cases/columns.tsx Outdated Show resolved Hide resolved

cnasikas reviewed May 4, 2020

View reviewed changes

x-pack/plugins/siem/public/pages/case/components/edit_connector/index.tsx Outdated Show resolved Hide resolved

stephmilovic added 2 commits May 4, 2020 12:10

PR changes

92b1d00

PR changes 2

3a954a1

XavierM unassigned stephmilovic May 4, 2020

stephmilovic added 5 commits May 4, 2020 12:42

translation changes

5d2d2bc

Merge branch 'master' into connector-selection-case

bf31cf3

Merge branch 'master' into connector-selection-case

e224b59

fix i18n whoops

e175cb6

fix jest

b6a1641

cnasikas approved these changes May 5, 2020

View reviewed changes

stephmilovic merged commit ed641ed into elastic:master May 5, 2020

stephmilovic mentioned this pull request May 5, 2020

[7.x] [SIEM] [Cases] External service selection per case (#64775) #65258

Merged

stephmilovic added a commit to stephmilovic/kibana that referenced this pull request May 5, 2020

[SIEM] [Cases] External service selection per case (elastic#64775)

19d30bc

stephmilovic added a commit that referenced this pull request May 5, 2020

[SIEM] [Cases] External service selection per case (#64775) (#65258)

4b4bab7

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM] [Cases] External service selection per case #64775

[SIEM] [Cases] External service selection per case #64775

stephmilovic commented Apr 29, 2020 •

edited

Loading

XavierM May 4, 2020 •

edited

Loading

XavierM May 4, 2020

stephmilovic May 4, 2020

cnasikas May 4, 2020 •

edited

Loading

XavierM May 4, 2020

stephmilovic May 4, 2020

cnasikas May 4, 2020 •

edited

Loading

XavierM May 4, 2020

kibanamachine commented May 5, 2020

cnasikas left a comment

elasticmachine commented Sep 23, 2021

[SIEM] [Cases] External service selection per case #64775

[SIEM] [Cases] External service selection per case #64775

Conversation

stephmilovic commented Apr 29, 2020 • edited Loading

Summary

Checklist

XavierM May 4, 2020 • edited Loading

Choose a reason for hiding this comment

XavierM May 4, 2020

Choose a reason for hiding this comment

stephmilovic May 4, 2020

Choose a reason for hiding this comment

cnasikas May 4, 2020 • edited Loading

Choose a reason for hiding this comment

XavierM May 4, 2020

Choose a reason for hiding this comment

stephmilovic May 4, 2020

Choose a reason for hiding this comment

cnasikas May 4, 2020 • edited Loading

Choose a reason for hiding this comment

XavierM May 4, 2020

Choose a reason for hiding this comment

kibanamachine commented May 5, 2020

💚 Build Succeeded

History

cnasikas left a comment

Choose a reason for hiding this comment

elasticmachine commented Sep 23, 2021

stephmilovic commented Apr 29, 2020 •

edited

Loading

XavierM May 4, 2020 •

edited

Loading

cnasikas May 4, 2020 •

edited

Loading

cnasikas May 4, 2020 •

edited

Loading