Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog #64986

Merged
merged 8 commits into from
May 5, 2020
Merged

Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog #64986

merged 8 commits into from
May 5, 2020

Conversation

YulNaumenko
Copy link
Contributor

Resolve #64308

@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 labels May 1, 2020
@YulNaumenko YulNaumenko requested review from a team as code owners May 1, 2020 01:26
@YulNaumenko YulNaumenko self-assigned this May 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote self-requested a review May 4, 2020 14:30
@YulNaumenko
Extended alert context with application capabilities
6b9f1b0
@YulNaumenko
Merge remote-tracking branch 'upstream/master' into alerting-ui-fix-d…
3069c89 
…oc-links

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/pagerduty.tsx
@YulNaumenko YulNaumenko requested review from a team as code owners May 4, 2020 17:59
pmuellr
pmuellr approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docLinks code LGTM, and worked in the UI (pointed to master when running dev mode). I noticed some uses of the TS ! suffix which I think can be removed (or could when I reviewed the PR).

I wasn't quite sure why the capabilities stuff was in here though - should that be in a separate PR? I didn't see any issues with it, but not sure what the original problem was.

...iggers_actions_ui/public/application/sections/action_connector_form/connector_add_flyout.tsx Outdated Show resolved Hide resolved
...riggers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.tsx Outdated Show resolved Hide resolved
...ggers_actions_ui/public/application/sections/action_connector_form/connector_edit_flyout.tsx Outdated Show resolved Hide resolved
...plugins/triggers_actions_ui/public/application/components/builtin_action_types/pagerduty.tsx Outdated Show resolved Hide resolved
phillipb
phillipb approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics changes look good.

@YulNaumenko
Merge remote-tracking branch 'upstream/master' into alerting-ui-fix-d…
a5dc921 
…oc-links

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@spalger
Copy link
Contributor

spalger commented May 4, 2020

@elasticmachine merge upstream

mikecote
mikecote approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

...plugins/triggers_actions_ui/public/application/components/builtin_action_types/pagerduty.tsx Outdated Show resolved Hide resolved
x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/slack.tsx Outdated Show resolved Hide resolved
...ggers_actions_ui/public/application/sections/action_connector_form/action_connector_form.tsx Outdated Show resolved Hide resolved
...ggers_actions_ui/public/application/sections/action_connector_form/connector_edit_flyout.tsx Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

rylnd
rylnd approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIEM Detection changes LGTM ; case changes look simple enough but I'll ping them just to be sure.

sorenlouv
sorenlouv approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apm changes lgtm

stephmilovic
stephmilovic approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the lone SIEM Case file change 👍

@YulNaumenko YulNaumenko merged commit 2f89069 into elastic:master May 5, 2020
@YulNaumenko YulNaumenko mentioned this pull request May 5, 2020
Merged
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request May 5, 2020
@YulNaumenko
Added support for docLinks plugin in Connectors forms and missing sav…
f7b73ec 
…e capabilities for modal dialog (elastic#64986)

* Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog

* Fixed tests

* Extended alert context with application capabilities

* Fixed due to comments

* Fixed typecheck

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/infra/public/components/alerting/inventory/alert_flyout.tsx
#	x-pack/plugins/triggers_actions_ui/public/application/context/alerts_context.tsx
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 5, 2020
@gmmorris
Merge branch 'master' into alerting/lazy-load-actions
93eaa01 
* master: (133 commits)
  Cleanup Typescript index pattern field editor / Expression functions for bucket agg (elastic#65254)
  Removes legacy infra plugin and moves saved objects registration to NP (elastic#64848)
  Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog (elastic#64986)
  [SIEM] Removes prebuilt rules number dependency (elastic#65128)
  [Maps] add categorical palettes with 20 and 30 categories (elastic#64701)
  [CI] Slack alerts - Elasticsearch snapshot failures (elastic#64724)
  [Uptime] Console errors in case index missing (elastic#65115)
  [SIEM][CASE] Dynamic fields mapping based on connector (elastic#64412)
  [test/functional] Tsfy page objects (elastic#64887)
  [Maps] [Telemetry] Track geo_point and geo_shape index patterns separately (elastic#65195)
  [Maps] Add global fit to data (elastic#64702)
  Visualize: Reload on ui state change and fix ui state for tsvb (elastic#63699)
  [SIEM] [Cases] External service selection per case (elastic#64775)
  [Uptime] Set ML anomaly look-back to 2w (from 24h) / Add spinner (elastic#65055)
  [Metrics UI] Remove APM Hard Dependency (elastic#64952)
  [Ingest] Datastream list: add icons and dashboard links (elastic#65048)
  disable plugins. they could access ES via SO repository (elastic#65242)
  Feature fleet enrollment instructions (elastic#65176)
  [SIEM] Adds 'Configure connector' Cypress test (elastic#64807)
  [TSVB] Fix std deviation band mode (elastic#64413)
  ...
YulNaumenko added a commit that referenced this pull request May 5, 2020
@YulNaumenko
Added support for docLinks plugin in Connectors forms and missing sav…
55de318 
…e capabilities for modal dialog (#64986) (#65289)

* Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog

* Fixed tests

* Extended alert context with application capabilities

* Fixed due to comments

* Fixed typecheck

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/infra/public/components/alerting/inventory/alert_flyout.tsx
#	x-pack/plugins/triggers_actions_ui/public/application/context/alerts_context.tsx
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request May 5, 2020
@YulNaumenko
Added support for docLinks plugin in Connectors forms and missing sav…
b3d08e4 
…e capabilities for modal dialog (elastic#64986)

* Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog

* Fixed tests

* Extended alert context with application capabilities

* Fixed due to comments

* Fixed typecheck

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/infra/public/components/alerting/inventory/alert_flyout.tsx
#	x-pack/plugins/triggers_actions_ui/public/application/context/alerts_context.tsx
@YulNaumenko YulNaumenko mentioned this pull request May 5, 2020
Closed
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request May 6, 2020
@YulNaumenko
Added support for docLinks plugin in Connectors forms and missing sav…
e0ecddb 
…e capabilities for modal dialog (elastic#64986)

* Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog

* Fixed tests

* Extended alert context with application capabilities

* Fixed due to comments

* Fixed typecheck

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/application/context/alerts_context.tsx
@YulNaumenko YulNaumenko mentioned this pull request May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@rylnd rylnd rylnd approved these changes

@phillipb phillipb phillipb approved these changes

@mikecote mikecote mikecote approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@XavierM XavierM Awaiting requested review from XavierM

@dgieselaar dgieselaar Awaiting requested review from dgieselaar

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some links in connector components are hardcoded to "current" version of docs
10 participants
@YulNaumenko @elasticmachine @spalger @kibanamachine @pmuellr @sorenlouv @rylnd @phillipb @mikecote @stephmilovic