[Maps] Add global fit to data #64702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
release_note:enhancement
WIP
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
reviewed
Apr 28, 2020
There was a problem hiding this comment.
Nice work getting something ready in time for 7.8
The styling on the fit to bounds button is not quite right. I looks like it has a shadow on it and is slightly different in appearance from the buttons. Also the icon is not great.
Outside of the scope of this PR, there should some UI feedback when layers are fitting to bounds. I think fit to bounds should use data request construct so layer TOC can show loading symbol when layers are fitting to bounds
x-pack/plugins/maps/public/connected_components/toolbar_overlay/fit_to_data/fit_to_data.tsx
Outdated
Show resolved
Hide resolved
miukimiu
approved these changes
May 4, 2020
x-pack/plugins/maps/public/connected_components/toolbar_overlay/_index.scss
Outdated
Show resolved
Hide resolved
|
I agree with @nreese that the icon is not great. But I think is consistent with this "fit to data":
If you agree I can think of a better icon to these "fit to data" actions. |
thomasneirynck
commented
May 4, 2020
x-pack/plugins/maps/public/connected_components/toolbar_overlay/_index.scss
Show resolved
Hide resolved
x-pack/plugins/maps/public/connected_components/toolbar_overlay/fit_to_data/fit_to_data.tsx
Outdated
Show resolved
Hide resolved
|
+1 on expand icon instead of the search icon |
nreese
approved these changes
May 4, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
May 5, 2020
thomasneirynck
added a commit
that referenced
this pull request
May 5, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 5, 2020
* master: (133 commits) Cleanup Typescript index pattern field editor / Expression functions for bucket agg (elastic#65254) Removes legacy infra plugin and moves saved objects registration to NP (elastic#64848) Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog (elastic#64986) [SIEM] Removes prebuilt rules number dependency (elastic#65128) [Maps] add categorical palettes with 20 and 30 categories (elastic#64701) [CI] Slack alerts - Elasticsearch snapshot failures (elastic#64724) [Uptime] Console errors in case index missing (elastic#65115) [SIEM][CASE] Dynamic fields mapping based on connector (elastic#64412) [test/functional] Tsfy page objects (elastic#64887) [Maps] [Telemetry] Track geo_point and geo_shape index patterns separately (elastic#65195) [Maps] Add global fit to data (elastic#64702) Visualize: Reload on ui state change and fix ui state for tsvb (elastic#63699) [SIEM] [Cases] External service selection per case (elastic#64775) [Uptime] Set ML anomaly look-back to 2w (from 24h) / Add spinner (elastic#65055) [Metrics UI] Remove APM Hard Dependency (elastic#64952) [Ingest] Datastream list: add icons and dashboard links (elastic#65048) disable plugins. they could access ES via SO repository (elastic#65242) Feature fleet enrollment instructions (elastic#65176) [SIEM] Adds 'Configure connector' Cypress test (elastic#64807) [TSVB] Fix std deviation band mode (elastic#64413) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29991
Adds a global fit button to the toolbar.