Fix vega specification parsing #67963
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
timroes
added
Feature:Vega
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
|
Jenkins, test this |
|
I filled out the CLA. Nur sure why the check fails. I noticed this was labeled for the 7.9 release. I really wish this was part of the next patch release, as this issue has been blocking me from updating for quite a while now. |
|
@thatguy7 It seems that you signed the CLA with your gmail address, while all the commits in this PR were signed from a different address. Could you please make sure to either sign also with the commit mail address (easier), or change the mail that has been used in the commit in git and push those changes. |
|
@thatguy7 We're trying to keep patch releases for really critical patches, so they stay as stable as possible. Given that Vega is still experimental and this bug doesn't fundamentally break it (though I totally agree it's very annoying), we won't backport that fix into a patch version, but only for the next minor version. Sorry that this will potentially mean you need to wait for another update :-( |
|
Can you release this sooner like 7.7.2 ? |
|
@thatguy7 thanx for signing the CLA! Can you also merge the master and resolve the conflicts in order to be able to merge it ? 🚀 |
thatguy7
force-pushed
the
fix-vega-specification-parsing
branch
from
132752a
to
9533f87
Compare
|
Jenkins, test this |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* add filter clause to es_query_parser.js * update tests to consider the filter clause * update docs to show the new filter clause Co-authored-by: Oleg Ivasenko <oleg.ivasenko@devolo.de>
* add filter clause to es_query_parser.js * update tests to consider the filter clause * update docs to show the new filter clause Co-authored-by: Oleg Ivasenko <oleg.ivasenko@devolo.de> Co-authored-by: Oleg Ivasenko <ivasenko.oleg@gmail.com> Co-authored-by: Oleg Ivasenko <oleg.ivasenko@devolo.de>
* master: (38 commits) Support migrating from reserved feature privileges (elastic#68504) add `preference` field to SavedObjectsFindOptions (elastic#68620) [ILM] Add "wait for snapshot" policy field to Delete phase (elastic#68505) Cleanup old license overwrites (elastic#68744) Bump TypeScript to v3.9 (elastic#67666) [APM] Service maps - adds new storybook stories to test out various data sets (elastic#68727) Fix vega specification parsing (elastic#67963) docs: add more api information (elastic#68717) [APM] Don't show annotations on charts with no data (elastic#68829) [Metrics UI] Fix Inventory View sorting by handling null values (elastic#67889) skip flaky suite (elastic#68836) [SIEM][Detections Engine] - Fix reference rule url overflow (elastic#68640) Index pattern public api => common (elastic#68289) [APM] Lazy-load alert triggers (elastic#68806) [DOCS] Fix table formatting in ingest manager settings (elastic#68824) [Endpoint] Functional Tests cleanup (elastic#68756) revert previous commit which was unintentional Use Github token instead for project assignments [SIEM][Exceptions] - ExceptionsViewer cleanup (elastic#68739) move @kbn/storybook to devDeps (elastic#68791) ...
Summary
After #42095 the VEGA parser was not adapted. This resulted in the issue as described in #54330. This pull request fixes the issue by adding a FILTER clause.
This also really should have appeared in the breaking changes documentation of any version since 7.4, since it breaks existing VEGA specifications using the MUST clause without any error messages. The resulting graphs just ignore dashboard filters.
Checklist
Delete any items that are not applicable to this PR.
For maintainers