Bump TypeScript to v3.9 #67666

mshustov · 2020-05-28T18:30:10Z

Summary

This PR makes an attempt to update the TypeScript version from v3.7 to v3.9.
I decided that it's better to fix all the issues at once than inviting all the teams to fix the issues twice.
I cannot fix all the problems on my own and would kindly ask teams to fix all the type errors since they know their codebase better (no worries, the most errors are rather trivial, for example when spread operation overrides a property)

List of the blockers by plugins:

Status	Plugin name	Team
✅	actions	@elastic/kibana-alerting-services
✅	apm	@elastic/apm-ui
✅	beats_management	@elastic/beats
✅	canvas	@elastic/kibana-canvas
✅	case	@elastic/siem @elastic/endpoint-app-team
✅	cross_cluster_replication	@elastic/es-ui
✅	dashboard	@elastic/kibana-app
✅	data	@elastic/kibana-app-arch
✅	index_management	@elastic/es-ui
✅	infra	@elastic/logs-metrics-ui
✅	ingest_manager	@elastic/ingest-management
✅	kibana_usage_collection	@elastic/pulse
✅	ML	@elastic/ml-ui
✅	security	@elastic/kibana-security
✅	security_solution	@elastic/siem @elastic/endpoint-app-team
✅	src/core/server	@elastic/kibana-platform
✅	telemetry	@elastic/pulse
✅	vis_type_timelion	@elastic/kibana-app
✅	visualizations	@elastic/kibana-app-arch
✅	watcher	@elastic/es-ui

Change log:

v3.8
v3.9

If your code has been already changed, please validate the changes.

How to deal with errors

1 check out the branch on your laptop
2 yarn kbn bootstrap && node scripts/type_check.js
3. fix all the errors in your plugin
4. either send PR or push directly in https://github.com/restrry/kibana/tree/ts-update

This reverts commit 04d9594.

mshustov · 2020-06-09T19:30:03Z

@patrykkopycinski 6b920ab is culprit.
tests were passing on the parent commit: Execute x-pack-intake - (45 min in self) https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/52106/flowGraphTable/
but started failing on 6b920ab: Execute x-pack-intake - (2 hr 27 min in self) https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/52288/flowGraphTable/

Would you mind taking a look?
you can run cd x-pack/ && yarn test:jest plugins/security_solution/public/resolver/view/use_camera.ts to freeze the test runner

jfsiii · 2020-06-09T21:08:48Z

x-pack/plugins/ingest_manager/server/services/output.ts

@@ -13,7 +13,7 @@ const SAVED_OBJECT_TYPE = OUTPUT_SAVED_OBJECT_TYPE;

 class OutputService {
  public async ensureDefaultOutput(soClient: SavedObjectsClientContract) {
-    const outputs = await soClient.find<OutputSOAttributes>({
+    const outputs = await soClient.find<Output>({


I would have expected this remain

const outputs = await soClient.find<OutputSOAttributes>({

but I can see it fixes the type errors. @nchaulet you're more familiar with this than me. WDYT?

@jfsiii I think you are commenting an outdated commit, I reverted that change

@nchaulet it was from 14 hours ago b49dad5

@nchaulet I committed this change to fix type error. feel free to tweak typings

mshustov · 2020-06-10T13:58:00Z

@patrykkopycinski thank you for fixing security_solutions tests. x-pack tests are executed in 53min. @spalger FYI

spalger · 2020-06-10T16:00:16Z

Looking at 4218caf I'm quite surprised... what caused this to break jest execution so dramatically?

Fixes type error for newer TypeScript

rudolf

👍 For platform changes

mshustov · 2020-06-11T05:21:29Z

@elasticmachine merge upstream

kibanamachine · 2020-06-11T08:03:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d26ff2c

History

💔 Build #53227 failed a887ff0
💚 Build #53177 succeeded cf62228
💔 Build #53145 failed babcc16
💔 Build #53042 failed 87a2846
💔 Build #53017 failed 4218caf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* add babel support for export type * bump ts version to 3.9.3 * rebuild kbn-pm * bump typescript-eslint * fix error in security plugin UI * check export as works * fix app migration type * use correct test subj attribute * fix errors from the old PR * embeddable is already passed in props * explicitly define type of fetch * add some types for viz * fix fetch type p.2 * add null to allow spreading without type errors due to override * add type guard to fix type error * cast to any, since cannot assign unknown * add timestamp to known types * fix type error in fetch * fix type error. id is always defined in attibutes * declare a type * move ts-ignore to the lines with errors * declare tuple type explicitly * mute type error. cannot assign unknown * fix errors. id is always defined * fix error type * fix override errors. id is always defined * fix error. extends any doesn't work anymore * fix type error. type is always defined * env doesn't always contain values * fix type error * cast to string * add: logs is already declared in getNodeLogsUrl * state is already passed in props * fix some errors in timelion * number of fragments is always defined * 'absolute' is not just string, but value * TEMP: option is always defined * always true if cast to promise manually * both props are always defined * explicitly define returned SO type * workaround type * bump tslib to be compatible with ts v3.9 * test private property * rebuild kbn-pm * Fix ts errors for beats management * Fix type inference broken by the TS 3.9 upgrade * Fix ingest manager saved object attributes typings * Fix TS errors in cross_cluster_replication and index_management. * Fix TS error in Watcher. * roll back colorRange wrong type * fix security plugin types * TypeScript 3.9 fixes for APM * Fix ColorRange types. * fix actions & alerts errors. ByGidi * fix lists error * More APM fixes * Remove paramaterization from `removeEmpty in agent config SettingsPage component (it's only used there and doesn't need to be parameterized.) * Add option chain for case in registerTransactionDurationAlertType * Cast `overallValue` in transform_metrics_chart * Use more specific type for custom link filters * Add more option chaining for local UI filters buckets response * Remove unused parameters from routes * Fix getProjection type parameter * Use destructuring in serviceNodesLocalFiltersRoute to hide `never` error * Revert `UnionToIntersection` change in `AggregationResponseMap` Fixes elastic#67804. * fix platform type error * Fix visualizations types. * Fix data plugin types. * bump TS version to 3.9.5 * Fix telemetry TS errors * Fix dashboard code * Adding Canvas Fixes for TS 3.9 * Fix case and security_solution types * roll back to the old export syntax. new one might cause problems in api-extractor * update docs * Fix timelion code * Fix meta * Fix types * fix type errors om ingest_manager * bump babel deps * enable private props & methods syntax * update kbn-pm dist * whitelist 0BSD license * use @babel/plugin-proposal-private-methods in default set as well * disable new babel plugins * Revert "disable new babel plugins" This reverts commit 04d9594. * cleanup security_solution types * Fixes type error for newer TypeScript * update docs Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Felix Stürmer <stuermer@weltenwort.de> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Larry Gregory <larry.gregory@elastic.co> Co-authored-by: Nathan L Smith <smith@nlsmith.com> Co-authored-by: Walter Rafelsberger <walter@elastic.co> Co-authored-by: Luke Elmers <luke.elmers@elastic.co> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> Co-authored-by: Tim Roes <tim.roes@elastic.co> Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> Co-authored-by: FrankHassanabad <frank.hassanabad@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* add babel support for export type * bump ts version to 3.9.3 * rebuild kbn-pm * bump typescript-eslint * fix error in security plugin UI * check export as works * fix app migration type * use correct test subj attribute * fix errors from the old PR * embeddable is already passed in props * explicitly define type of fetch * add some types for viz * fix fetch type p.2 * add null to allow spreading without type errors due to override * add type guard to fix type error * cast to any, since cannot assign unknown * add timestamp to known types * fix type error in fetch * fix type error. id is always defined in attibutes * declare a type * move ts-ignore to the lines with errors * declare tuple type explicitly * mute type error. cannot assign unknown * fix errors. id is always defined * fix error type * fix override errors. id is always defined * fix error. extends any doesn't work anymore * fix type error. type is always defined * env doesn't always contain values * fix type error * cast to string * add: logs is already declared in getNodeLogsUrl * state is already passed in props * fix some errors in timelion * number of fragments is always defined * 'absolute' is not just string, but value * TEMP: option is always defined * always true if cast to promise manually * both props are always defined * explicitly define returned SO type * workaround type * bump tslib to be compatible with ts v3.9 * test private property * rebuild kbn-pm * Fix ts errors for beats management * Fix type inference broken by the TS 3.9 upgrade * Fix ingest manager saved object attributes typings * Fix TS errors in cross_cluster_replication and index_management. * Fix TS error in Watcher. * roll back colorRange wrong type * fix security plugin types * TypeScript 3.9 fixes for APM * Fix ColorRange types. * fix actions & alerts errors. ByGidi * fix lists error * More APM fixes * Remove paramaterization from `removeEmpty in agent config SettingsPage component (it's only used there and doesn't need to be parameterized.) * Add option chain for case in registerTransactionDurationAlertType * Cast `overallValue` in transform_metrics_chart * Use more specific type for custom link filters * Add more option chaining for local UI filters buckets response * Remove unused parameters from routes * Fix getProjection type parameter * Use destructuring in serviceNodesLocalFiltersRoute to hide `never` error * Revert `UnionToIntersection` change in `AggregationResponseMap` Fixes #67804. * fix platform type error * Fix visualizations types. * Fix data plugin types. * bump TS version to 3.9.5 * Fix telemetry TS errors * Fix dashboard code * Adding Canvas Fixes for TS 3.9 * Fix case and security_solution types * roll back to the old export syntax. new one might cause problems in api-extractor * update docs * Fix timelion code * Fix meta * Fix types * fix type errors om ingest_manager * bump babel deps * enable private props & methods syntax * update kbn-pm dist * whitelist 0BSD license * use @babel/plugin-proposal-private-methods in default set as well * disable new babel plugins * Revert "disable new babel plugins" This reverts commit 04d9594. * cleanup security_solution types * Fixes type error for newer TypeScript * update docs Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Felix Stürmer <stuermer@weltenwort.de> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Larry Gregory <larry.gregory@elastic.co> Co-authored-by: Nathan L Smith <smith@nlsmith.com> Co-authored-by: Walter Rafelsberger <walter@elastic.co> Co-authored-by: Luke Elmers <luke.elmers@elastic.co> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> Co-authored-by: Tim Roes <tim.roes@elastic.co> Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> Co-authored-by: FrankHassanabad <frank.hassanabad@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Felix Stürmer <stuermer@weltenwort.de> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Larry Gregory <larry.gregory@elastic.co> Co-authored-by: Nathan L Smith <smith@nlsmith.com> Co-authored-by: Walter Rafelsberger <walter@elastic.co> Co-authored-by: Luke Elmers <luke.elmers@elastic.co> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> Co-authored-by: Tim Roes <tim.roes@elastic.co> Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> Co-authored-by: FrankHassanabad <frank.hassanabad@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (38 commits) Support migrating from reserved feature privileges (elastic#68504) add `preference` field to SavedObjectsFindOptions (elastic#68620) [ILM] Add "wait for snapshot" policy field to Delete phase (elastic#68505) Cleanup old license overwrites (elastic#68744) Bump TypeScript to v3.9 (elastic#67666) [APM] Service maps - adds new storybook stories to test out various data sets (elastic#68727) Fix vega specification parsing (elastic#67963) docs: add more api information (elastic#68717) [APM] Don't show annotations on charts with no data (elastic#68829) [Metrics UI] Fix Inventory View sorting by handling null values (elastic#67889) skip flaky suite (elastic#68836) [SIEM][Detections Engine] - Fix reference rule url overflow (elastic#68640) Index pattern public api => common (elastic#68289) [APM] Lazy-load alert triggers (elastic#68806) [DOCS] Fix table formatting in ingest manager settings (elastic#68824) [Endpoint] Functional Tests cleanup (elastic#68756) revert previous commit which was unintentional Use Github token instead for project assignments [SIEM][Exceptions] - ExceptionsViewer cleanup (elastic#68739) move @kbn/storybook to devDeps (elastic#68791) ...

mshustov added 30 commits May 28, 2020 14:24

add babel support for export type

a82dea3

bump ts version to 3.9.3

1209ac8

rebuild kbn-pm

ac2bc71

bump typescript-eslint

d3cd8a8

fix error in security plugin UI

090b1b7

check export as works

31ce720

fix app migration type

652af9b

use correct test subj attribute

870eb81

fix errors from the old PR

e3e68f3

embeddable is already passed in props

be07879

explicitly define type of fetch

8cae218

add some types for viz

675a225

fix fetch type p.2

e168c62

add null to allow spreading without type errors due to override

97323f9

add type guard to fix type error

82ab3ef

cast to any, since cannot assign unknown

8394514

add timestamp to known types

9f68529

fix type error in fetch

72f2296

fix type error. id is always defined in attibutes

e9ace30

declare a type

dfa2574

move ts-ignore to the lines with errors

dd7f2c8

declare tuple type explicitly

f294214

mute type error. cannot assign unknown

e84eb25

fix errors. id is always defined

3fe70e4

fix error type

a482090

fix override errors. id is always defined

09d5706

fix error. extends any doesn't work anymore

4dd6549

fix type error. type is always defined

796d839

env doesn't always contain values

1889b6c

fix type error

991ddb3

Revert "disable new babel plugins"

64f08da

This reverts commit 04d9594.

jfsiii reviewed Jun 9, 2020

View reviewed changes

patrykkopycinski and others added 3 commits June 10, 2020 14:50

cleanup security_solution types

4218caf

Merge remote-tracking branch 'origin/ts-update' into ts-update

e45065c

Merge branch 'master' into ts-update

87a2846

mshustov and others added 3 commits June 10, 2020 22:05

Merge branch 'master' into ts-update

babcc16

Fixes type error for newer TypeScript

37e3263

Merge pull request #4 from FrankHassanabad/fix-for-type

cf62228

Fixes type error for newer TypeScript

rudolf approved these changes Jun 10, 2020

View reviewed changes

elasticmachine and others added 3 commits June 10, 2020 22:21

Merge branch 'master' into ts-update

a887ff0

Merge remote-tracking branch 'origin/ts-update' into ts-update

4baf675

update docs

d26ff2c

spalger mentioned this pull request Jun 11, 2020

Update vega version #68639

Merged

7 tasks

mshustov merged commit f593455 into elastic:master Jun 11, 2020

mshustov deleted the ts-update branch June 11, 2020 08:04

mshustov mentioned this pull request Jun 11, 2020

[7.x] Bump TypeScript to v3.9 #68870

Merged

mshustov mentioned this pull request Jun 11, 2020

Update typescript related packages #53957

Closed

1 task

This was referenced Jun 15, 2020

[Maps] Security layer wizards #68290

Merged

[Maps] Migrate maps client router to react #65079

Merged

clintandrewhall mentioned this pull request Jun 18, 2020

[chore] TS 3.9: convert ts-ignore to ts-expect-error #69541

Merged

joshdover added this to Pending Review in kibana-core [DEPRECATED] via automation Jun 24, 2020

joshdover moved this from Pending Review to Done (7.9) in kibana-core [DEPRECATED] Jun 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump TypeScript to v3.9 #67666

Bump TypeScript to v3.9 #67666

mshustov commented May 28, 2020 •

edited

Loading

mshustov commented Jun 9, 2020

jfsiii Jun 9, 2020

nchaulet Jun 9, 2020

jfsiii Jun 9, 2020

mshustov Jun 10, 2020

mshustov commented Jun 10, 2020 •

edited

Loading

spalger commented Jun 10, 2020

rudolf left a comment

mshustov commented Jun 11, 2020

kibanamachine commented Jun 11, 2020

Bump TypeScript to v3.9 #67666

Bump TypeScript to v3.9 #67666

Conversation

mshustov commented May 28, 2020 • edited Loading

Summary

How to deal with errors

mshustov commented Jun 9, 2020

jfsiii Jun 9, 2020

Choose a reason for hiding this comment

nchaulet Jun 9, 2020

Choose a reason for hiding this comment

jfsiii Jun 9, 2020

Choose a reason for hiding this comment

mshustov Jun 10, 2020

Choose a reason for hiding this comment

mshustov commented Jun 10, 2020 • edited Loading

spalger commented Jun 10, 2020

rudolf left a comment

Choose a reason for hiding this comment

mshustov commented Jun 11, 2020

kibanamachine commented Jun 11, 2020

💚 Build Succeeded

History

mshustov commented May 28, 2020 •

edited

Loading

mshustov commented Jun 10, 2020 •

edited

Loading